Segfault with Faster MDCT patch and -fPIC

2010-09-17 Thread Slawomir Testowy
Hi all! For some time I have been using tremor with fastermdct patch found on http://www.rockbox.org/wiki/FasterMDCT. This patch gives huge speedup on i686/x86_64 machines and smaller, but still significant, speedup on ARM. Everything works great until I compile tremor on ARM with -fPIC flag (I

Re: Segfault with Faster MDCT patch and -fPIC

2010-09-17 Thread Dave Hooper
That's very interesting indeed. I too observed a segfault when trying to use the fastermdct patch on top of a libtremor used by an MPD server but couldn't pinpoint the reason. That's one of the reasons this patch hasn't hit upstream Tremor. I know the code well but that line seems very mysterious

Re: Segfault with Faster MDCT patch and -fPIC

2010-09-17 Thread Dave Hooper
If I remember correctly, gcc was not clever enough to maintain the ordering constraints needed by the ldmia/stmia calls, so I needed to assign the registers manually to prevent generating bad code (by the way x86 shouldn't use this file at all so compilation issues wouldn't show up on your build).

Re: Segfault with Faster MDCT patch and -fPIC

2010-09-17 Thread Rafaël Carré
On Fri, 17 Sep 2010 12:08:38 +0100 Dave Hooper d...@beermex.com wrote: If I remember correctly, gcc was not clever enough to maintain the ordering constraints needed by the ldmia/stmia calls, so I needed to assign the registers manually to prevent generating bad code Ah right, GCC can not be

Re: Segfault with Faster MDCT patch and -fPIC

2010-09-17 Thread Rafaël Carré
On Fri, 17 Sep 2010 14:01:48 +0200 Slawomir Testowy slawomir.test...@gmail.com wrote: Hi, thanks for quick response. 2010/9/17 Rafaël Carré rafael.ca...@gmail.com: I think the OP should post .S output of gcc and also give us compiler version and options being used -- Rafaël Carré

Re: Segfault with Faster MDCT patch and -fPIC

2010-09-17 Thread Rafaël Carré
On Fri, 17 Sep 2010 16:26:31 +0200 Slawomir Testowy slawomir.test...@gmail.com wrote: 2010/9/17 Rafaël Carré rafael.ca...@gmail.com: On Fri, 17 Sep 2010 14:01:48 +0200 Slawomir Testowy slawomir.test...@gmail.com wrote: Hi, thanks for quick response. 2010/9/17 Rafaël Carré

Re: Segfault with Faster MDCT patch and -fPIC

2010-09-17 Thread Dave Hooper
I think it's hard to tell - let's see what happens without optimisations (-O0) since the code won't always align easily to the source otherwise. On Fri, 17 Sep 2010 16:26:31 +0200 Slawomir Testowy slawomir.test...@gmail.com wrote: 2010/9/17 Rafaël Carré rafael.ca...@gmail.com: On Fri, 17 Sep

Open patches in Rockbox

2010-09-17 Thread tracker
Flyspray contains 391 open patches: 4 days old: Polish translation update 0 comments, 1 files: http://www.rockbox.org/tracker/11625 6 days old: Improved Synthesis of talk clips for CamelCased files and directories 3 comments, 1 files: http://www.rockbox.org/tracker/11622 7 days old: Restore

Open bugs in Rockbox

2010-09-17 Thread tracker
Flyspray contains 277 open bugs: 1 days old: Rockbox shows WPS backdrop instead of menu backdrop 1 comments, 0 files: http://www.rockbox.org/tracker/11630 1 days old: %t(timeout): timeout reverts always to 2sec default when used inside %?mp 2 comments, 0 files: