usb.c warning

2012-01-04 Thread Magnus Holmgren
Hi, Noticed a warning for this code in firmware/usb.c, line 557 (as of r31578): status = (status == USB_INSERTED) ? : USB_EXTRACTED; According to the gcc manual (section 5.7), the expression x ? : y (a gcc extension) has the value x if x is nonzero, otherwise z. So, status is set to true

having pluginlib-action handling more/all plugin.

2012-01-04 Thread Jean-Louis Biasini
Hi all, 1) what I do for now I'm working on keymaps and manual for the new fuze+ port. I suppose that you already know the kind of harrassing boring task this can be. If not you may have a look to the kind of patch that one has to provide: for manual:

Re: usb.c warning

2012-01-04 Thread Michael Sevakis
Yes. It's just like status = (status == USB_INSERTED) ? status : USB_EXTRACTED; Hi, Noticed a warning for this code in firmware/usb.c, line 557 (as of r31578): status = (status == USB_INSERTED) ? : USB_EXTRACTED; According to the gcc manual (section 5.7), the expression x ? : y (a gcc

Re: usb.c warning

2012-01-04 Thread Frank Gevaerts
On Wed, Jan 04, 2012 at 05:00:09PM +0100, Magnus Holmgren wrote: Hi, Noticed a warning for this code in firmware/usb.c, line 557 (as of r31578): status = (status == USB_INSERTED) ? : USB_EXTRACTED; According to the gcc manual (section 5.7), the expression x ? : y (a gcc extension)

Re: usb.c warning

2012-01-04 Thread Michael Sevakis
Hi, Noticed a warning for this code in firmware/usb.c, line 557 (as of r31578): status = (status == USB_INSERTED) ? : USB_EXTRACTED; According to the gcc manual (section 5.7), the expression x ? : y (a gcc extension) has the value x if x is nonzero, otherwise z. So, status is set to

Re: having pluginlib-action handling more/all plugin.

2012-01-04 Thread Paul Louden
We've more or less tried using pluginlib actions to have generalized keymaps. The problem is, it simply doesn't really work. Since the directional keys can be quite different from target to target (on wheel targets up and down are going to be wheel up and down, whereas on joystick targets it will

Re: usb.c warning

2012-01-04 Thread Michael Sevakis
Almost certainly not. This looks like a bug waiting to happen to me. Frank If that patch goes in to fix FreeBSD (why isn't it commited?), it won't matter anyway. Mike

Re: usb.c warning

2012-01-04 Thread Frank Gevaerts
On Wed, Jan 04, 2012 at 11:13:11AM -0500, Michael Sevakis wrote: If that patch goes in to fix FreeBSD (why isn't it commited?), it won't matter anyway. I still haven't seen a report of it working on a non-USB_DETECT_BY_CORE such as nano2g. Did I miss that? Ideally I'd also like to see if

Re: usb.c warning

2012-01-04 Thread Michael Sevakis
I still haven't seen a report of it working on a non-USB_DETECT_BY_CORE such as nano2g. Did I miss that? Ideally I'd also like to see if USB_DETECT_BY_CORE now magically works for those now. Frank I did test it on the Clip v1 bootloader without difficulties, which doesn't use ...BY_CORE, if

Re: having pluginlib-action handling more/all plugin.

2012-01-04 Thread Thomas Martitz
Am 04.01.2012 17:05, schrieb Jean-Louis Biasini: Hi all, 1) what I do for now I'm working on keymaps and manual for the new fuze+ port. I suppose that you already know the kind of harrassing boring task this can be. If not you may have a look to the kind of patch that one has to provide: for