Re: Please help test gerrit#890

2014-07-06 Thread Richard Quirk
On 06/07/14 10:22, Jonathan Gordon wrote: Thanks! This is fixed, please retry with the updated patch. Yep, nice one, that fixes it.

Re: Please help test gerrit#890

2014-07-05 Thread Richard Quirk
Please let me know if you find any crashes - or even better if this fixes any crashes with your troublesome skins! I didn't see any crashes, but the clock_lock2 theme I use on the WPS didn't work any more. This is on the sansa clip zip, here's a link to the theme:

Updating Lua plugin to upstream 5.2.3

2014-03-23 Thread Richard Quirk
I've updated the Lua plugin code to use the upstream 5.2.3 release. For comparison, the current code uses Lua 5.1.4. It's quite a large change, though mostly due to changes in the core Lua code. I've tried to minimise the differences between Lua upstream and modifications for Rockbox, while also

Re: review to show only the chosen file's bookmarks

2013-04-25 Thread Richard Quirk
On 4/22/13, Magnus Holmgren magnus...@gmail.com wrote: It would affect me negatively, at least. And I guess I wouldn't be alone... However, an extra bookmarking autoload option wouldn't affect users of the menu, and would allow you to tweak the bookmark selection list behavior to match your

Re: review to show only the chosen file's bookmarks

2013-04-22 Thread Richard Quirk
On 4/21/13, Magnus Holmgren magnus...@gmail.com wrote: It shows bookmarks for all tracks in the directory, because the bookmarks are created for the implicit playlist for that directory. That makes sense opening the bookmark file for a directory, but for opening an individual file it seems

review to show only the chosen file's bookmarks

2013-04-21 Thread Richard Quirk
This change is a bit larger than my last minor bookmark tweak. Again autoload bookmarks is set to ask. Opening a track showed all of the bookmarks for any track in the current directory, not just bookmarks for the track you chose to open. http://gerrit.rockbox.org/r/#/c/428/ The main change was

review for minor bookmark ui tweak

2013-04-06 Thread Richard Quirk
This minor UI change adds a way to cancel out from the bookmark list that is shown when you have autoload bookmarks = ask. http://gerrit.rockbox.org/416 Without this change, pressing a cancel button starts the track from the start, which felt unexpected to me. With the change, cancelling goes

Proposed fix for FS#6411

2012-12-11 Thread Richard Quirk
I've had a crack at fixing this old bug - http://www.rockbox.org/tracker/6411 - when you delete or add a track to a playlist, resume starts the wrong track afterwards. Happened to me all the time when copying new podcasts across. Given that there isn't much space to keep the settings in, I

Patch to add separate skip length backwards

2012-11-18 Thread Richard Quirk
I've added backwards skip length, which is handy when skipping adverts or musical interludes in podcasts - I have skip set to 30s, and the backwards skip to 7s. That way if I overshoot, it's easy to find where the section ended. http://gerrit.rockbox.org/350 I didn't updated skip length to skip

Re: [PATCH,RFC] avoid radio noise on sansa clipplus

2012-11-10 Thread Richard Quirk
On 11/09/2012 05:07 PM, Mike Giacomelli wrote: The WPS is a different screen than the FM radio screen, so it might behave differently. However, from a quick look at the code it seems to me that the WPS screen also does update 5 times per second, even if the display is turned off, but my

Re: Fix for default sleep timer duration as a shortcut

2012-10-06 Thread Richard Quirk
On 10/06/2012 11:54 AM, Jonathan Gordon wrote: On 6 October 2012 05:47, Richard Quirk richard.qu...@gmail.com wrote: A couple of patches to do with the default sleep duration setting, the first adds a set_sleeptimer_duration function that will be used in the second. http

Re: Fix for default sleep timer duration as a shortcut

2012-10-06 Thread Richard Quirk
On 10/06/2012 03:22 PM, Dominik Riebeling wrote: On Sat, Oct 6, 2012 at 2:16 PM, Richard Quirk richard.qu...@gmail.com wrote: Thanks for reviewing that. Unfortunately I missed a set_sleep_timer in 327, but did not spot the compiler output as I had 327 and 328 staged on the same branch. Clean up

Snake2 on the sansa clip zip

2012-10-02 Thread Richard Quirk
I also noticed what I think this post[1] is talking about, namely that snake2 is a bit big for the clip zip's screen. The poster just calls it snake though. I've sent a patch for review on gerrit[2] that fixes the problem. It simply adds another ifdef block, with suitable values for the zip's