Re: FS#6321 - Universal Image Viewer

2010-11-11 Thread Matthias Mohr
3) I don't see why this would be needed immediately in this plugin. Sure it would be a nice addition but there is no reason it must happen straight away. I fully agree with this. I also fully agree with this - keep the discussion focus on the functionality of the viewer itself and not how it de

Re: FS#6321 - Universal Image Viewer

2010-11-11 Thread Daniel Stenberg
On Thu, 11 Nov 2010, Jonathan Gordon wrote: 3) I don't see why this would be needed immediately in this plugin. Sure it would be a nice addition but there is no reason it must happen straight away. I fully agree with this. -- / daniel.haxx.se

Re: FS#6321 - Universal Image Viewer

2010-11-10 Thread Jonathan Gordon
1) I think this is a pointless topic because how often do people have their files wrongly extensioned? 2) as far as playback is concerned, it is at best non trivial to make it work and would slow down buffering and increase bin/ram usage for a mostly pointless addition. 3) I don't see why this woul

Re: FS#6321 - Universal Image Viewer

2010-11-10 Thread Bertrik Sikken
On 8-11-2010 2:16, Teruaki Kawashima wrote: > Hi, > > I'd like to ask for testers for FS#6321 - Universal Image Viewer > > The patch unifies jpeg viewer, png viewer, and bmp viewer to one plugin, > image viewer so that you can navigate through different image formats. &

Re: FS#6321 - Universal Image Viewer

2010-11-10 Thread Johannes Linke
Am 10.11.2010 23:03, schrieb Jonathan Gordon: 2010/11/10 Jonas Häggqvist: How do the codecs handle this? Silently ignores the file. Just tried copying a .mp3 to .flac and playing it, track is completely skipped with no reason given. What is the problem with checking for those magic numbers, p

Re: FS#6321 - Universal Image Viewer

2010-11-10 Thread Jonathan Gordon
2010/11/10 Jonas Häggqvist : > How do the codecs handle this? Silently ignores the file. Just tried copying a .mp3 to .flac and playing it, track is completely skipped with no reason given.

Re: FS#6321 - Universal Image Viewer

2010-11-10 Thread Jonathan Gordon
Probably a very sensible idea. On 10/11/2010 10:32 PM, "Teruaki Kawashima" wrote: > (2010/11/10 1:16), Alex Parker wrote: >> On 9 November 2010 16:57, Teruaki Kawashima wrote: >>> >>> Thank you for suggestion and information. >>> I agree that it would be better to look for magic number. >>> but I'

Re: FS#6321 - Universal Image Viewer

2010-11-10 Thread Jonas Häggqvist
On 09-11-2010 22:25, Paul Louden wrote: I think an error message saying "Image appears to be a .png" when a .bmp is loaded with the magic numbers for a PNG, and possibly a refusal to load it, makes some sense. Being too intelligent and acting like nothing went wrong isn't really an entirely posi

Re: FS#6321 - Universal Image Viewer

2010-11-10 Thread Teruaki Kawashima
(2010/11/10 1:16), Alex Parker wrote: On 9 November 2010 16:57, Teruaki Kawashima wrote: Thank you for suggestion and information. I agree that it would be better to look for magic number. but I'll leave it for now unless it causes serious problem that judging by file-extension. teru Wheth

Re: FS#6321 - Universal Image Viewer

2010-11-09 Thread Marcin Bukat
> I think an error message saying "Image appears to be a .png" when a .bmp is > loaded with the magic numbers for a PNG, and possibly a refusal to load it, > makes some sense. png decoder responds with 'incorrect png signature' and skips the file. I don't know the details of other decoders. wodz

Re: FS#6321 - Universal Image Viewer

2010-11-09 Thread Paul Louden
On 11/9/2010 3:20 PM, Jonas Häggqvist wrote: On 09-11-2010 18:35, Marcin Bukat wrote: BTW. Aren't viewers bind to particular file extensions? If so I wouldn't bother to do any more advanced detection. If someone rename .bmp to .jpg it's his/her problem. The thing is that the image viewer lets

Re: FS#6321 - Universal Image Viewer

2010-11-09 Thread Jonas Häggqvist
On 09-11-2010 18:35, Marcin Bukat wrote: BTW. Aren't viewers bind to particular file extensions? If so I wouldn't bother to do any more advanced detection. If someone rename .bmp to .jpg it's his/her problem. The thing is that the image viewer lets you "browse" images on its own, so it has to

Re: FS#6321 - Universal Image Viewer

2010-11-09 Thread Alex Parker
On 9 November 2010 16:57, Teruaki Kawashima wrote: > > Thank you for suggestion and information. > I agree that it would be better to look for magic number. > but I'll leave it for now unless it causes serious problem that judging by > file-extension. > > teru > Whether going on file extensions g

Re: FS#6321 - Universal Image Viewer

2010-11-09 Thread Marcin Bukat
2010/11/9 Alex Parker : > On 9 November 2010 16:57, Teruaki Kawashima wrote: >> >> Thank you for suggestion and information. >> I agree that it would be better to look for magic number. >> but I'll leave it for now unless it causes serious problem that judging by >> file-extension. BTW. Aren't vie

Re: FS#6321 - Universal Image Viewer

2010-11-09 Thread Teruaki Kawashima
(2010/11/09 1:42), Marcin Bukat wrote: 2010/11/8 Teruaki Kawashima: Hi, I'd like to ask for testers for FS#6321 - Universal Image Viewer The patch unifies jpeg viewer, png viewer, and bmp viewer to one plugin, image viewer so that you can navigate through different image formats. Dow

Re: FS#6321 - Universal Image Viewer

2010-11-08 Thread Michael Stummvoll
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 08.11.10 14:16, schrieb Teruaki Kawashima: > Hi, > > I'd like to ask for testers for FS#6321 - Universal Image Viewer I just tested it on my fuze v2 and all works fine. But figuring out the format by the file-extension isn

Re: FS#6321 - Universal Image Viewer

2010-11-08 Thread Marcin Bukat
2010/11/8 Teruaki Kawashima : > Hi, > > I'd like to ask for testers for FS#6321 - Universal Image Viewer > > The patch unifies jpeg viewer, png viewer, and bmp viewer to one plugin, > image viewer so that you can navigate through different image formats. > Downside might

FS#6321 - Universal Image Viewer

2010-11-08 Thread Teruaki Kawashima
Hi, I'd like to ask for testers for FS#6321 - Universal Image Viewer The patch unifies jpeg viewer, png viewer, and bmp viewer to one plugin, image viewer so that you can navigate through different image formats. Downside might be that the images without proper extension won't be l