RE: New rockbox logging system

2012-07-08 Thread Mike Giacomelli
> > Am 06.07.2012 23:53, schrieb Mike Giacomelli: > > We can leave the actual logf code in git, and just convert the stuff > > that makes sense over to the new system. > > Any log to disk would trigger Jonas' storage-related problems. I guess > he asks if a read-only build would be possible. >

Re: New rockbox logging system

2012-07-08 Thread Jonas Wielicki
On 08.07.2012 19:08, Thomas Martitz wrote: > Am 06.07.2012 23:53, schrieb Mike Giacomelli: >> We can leave the actual logf code in git, and just convert the stuff >> that makes sense over to the new system. > > Any log to disk would trigger Jonas' storage-related problems. I guess > he asks if a r

Re: New rockbox logging system

2012-07-08 Thread Thomas Martitz
Am 06.07.2012 23:53, schrieb Mike Giacomelli: We can leave the actual logf code in git, and just convert the stuff that makes sense over to the new system. Any log to disk would trigger Jonas' storage-related problems. I guess he asks if a read-only build would be possible. Best regards.

Re: New rockbox logging system

2012-07-07 Thread Bertrik Sikken
Hi Mike, On 6-7-2012 12:30, Mike Giacomelli wrote: > Hi Everyone. > > I've implemented a new logging system for rockbox to eventually > replace DEBUGF and LOGF. The new system is very similar to the old, > but with 2 significant improvements: > > 1) It uses the register_storage_idle_func to wr

Re: New rockbox logging system

2012-07-06 Thread Mike Giacomelli
We can leave the actual logf code in git, and just convert the stuff that makes sense over to the new system.

Re: New rockbox logging system

2012-07-06 Thread Thomas Martitz
Mike Giacomelli schrieb: >Can this be turned off? I am hunting issues which relate to disk access, >and I get freezes upon writing / reading in some cases. Turning this off would result in the system we currently have. If you want that system, just use LOGF directly and ignore my patch. What

Re: New rockbox logging system

2012-07-06 Thread Mike Giacomelli
>Can this be turned off? I am hunting issues which relate to disk access, >and I get freezes upon writing / reading in some cases. Turning this off would result in the system we currently have. If you want that system, just use LOGF directly and ignore my patch.

Re: New rockbox logging system

2012-07-06 Thread Frank Gevaerts
On Fri, Jul 06, 2012 at 09:43:24AM +0200, Jonas Wielicki wrote: > Related to your gerrit, can one see the whole diff of all patchsets > together in gerrit somehow? Yes, indirectly. In the list of patch sets, next to each patch set there's a gitweb link. If you click on that, you get to the gitweb

Re: New rockbox logging system

2012-07-06 Thread Jonas Wielicki
On 06.07.2012 09:43, Jonas Wielicki wrote: > Okay, my mail might've been to critic, I like the work, a good logging system might be really helpful. Just asking some questions back cause I'm curious :) cheers

Re: New rockbox logging system

2012-07-06 Thread Jonas Wielicki
On 06.07.2012 00:30, Mike Giacomelli wrote: > 1) It uses the register_storage_idle_func to write log files to disk > during spin up. This is similar to how config files and battery bench > logs are handled. Thus, there is no loss of battery life from > logging. Can this be turned off? I am hunti