RE: WPS line height patch

2007-04-17 Thread Zakk
ave in any case. And small size impact. -Original Message- From: Dominik Riebeling <[EMAIL PROTECTED]> Sent: Tuesday, April 17, 2007 12:03 AM To: Rockbox development Subject: Re: WPS line height patch As I have took part of the discussion on IRC I won't repeat myself in total. J

Re: WPS line height patch

2007-04-17 Thread Peter D'Hoye
>As I have took part of the discussion on IRC I won't repeat myself in >total. Just to sum it up: IMO this isn't the proper solution for the >original problem (users mixing wrong fonts with themes). Anyone who's >interested, the discussion was on 20070417 starting about 0:12h As we're all voting,

Re: WPS line height patch

2007-04-17 Thread Jonathan Gordon
On 17/04/07, Dominik Riebeling <[EMAIL PROTECTED]> wrote: As I have took part of the discussion on IRC I won't repeat myself in total. Just to sum it up: IMO this isn't the proper solution for the original problem (users mixing wrong fonts with themes). Anyone who's interested, the discussion was

Re: WPS line height patch

2007-04-17 Thread Dominik Riebeling
As I have took part of the discussion on IRC I won't repeat myself in total. Just to sum it up: IMO this isn't the proper solution for the original problem (users mixing wrong fonts with themes). Anyone who's interested, the discussion was on 20070417 starting about 0:12h On 4/17/07, Jonathan Gor

Re: WPS line height patch

2007-04-16 Thread Matthias Mohr
Just to summarize, it separates the concepts of "line height" and "font height" so that you can define the former, and use any font with equal or less line height to equal effect. I really like the idea - and I think it should be added to SVN ! And it would be still useful when viewports are imp

Re: WPS line height patch

2007-04-16 Thread Paul Louden
I'm not for band-aid fixes, but I don't think it should be seen as one. It adds functionality that will be useful, even with viewports. Though you can duplicate what this patch does with viewports, it would require that every single visible line of the WPS be defined as its own viewport for the sa

Re: WPS line height patch

2007-04-16 Thread Jonathan Gordon
On 17/04/07, Paul Louden <[EMAIL PROTECTED]> wrote: Just to summarize, it separates the concepts of "line height" and "font height" so that you can define the former, and use any font with equal or less line height to equal effect. I really think it's a beneficial feature. It has been argued tha

Re: WPS line height patch

2007-04-16 Thread Paul Louden
Just to summarize, it separates the concepts of "line height" and "font height" so that you can define the former, and use any font with equal or less line height to equal effect. I really think it's a beneficial feature. It has been argued that viewports will allow the same effect, but I think t

WPS line height patch

2007-04-16 Thread Nicolas Pennequin
I'd like to get a general feeling on http://www.rockbox.org/tracker/task/7033 After some discussion on the IRC channel, it appears there are some objections about it, but there weren't many people there so I'd like to see what the general feeling is. The patch adds one simple optional WPS tag to