Magnus, Thanks for your review and your suggestions :)
* Make rtc_tags const too.
Whay do you mean ? the array ? all_tags isn't const... But maybe I should make
them both const ?
* Use for loops where appropriate (like searching the rtc_tags or
all_tags arrays).
Not sure that'll be better.
On 29/03/07, Nicolas Pennequin [EMAIL PROTECTED] wrote:
IMaybe it's just in the sim, but the
progressbars don't work and I seem to get crashes while fast-forwarding.
On all other targets, it seems to compile and work fine.
Nicolas Pennequin
I might be wrong but I think that the sim on
Nicolas Pennequin wrote:
I've updated my WPS tokenizer patch again.
It's now reached a state where I think it's nearly committable, but before I
do so, I'd like some help from someone who knows the archos player code to
fix the issues I have with it. Maybe it's just in the sim
Nicolas Pennequin wrote:
I've updated my WPS tokenizer patch again.
...
Also, I'd appreciate it a lot if people who know what makes code big and what
helps make it smaller (and not only them !) could have a look at my code and
tell me what could be improved.
A couple of comments/nits
I've updated my WPS tokenizer patch again.
It's now reached a state where I think it's nearly committable, but before I
do so, I'd like some help from someone who knows the archos player code to
fix the issues I have with it. Maybe it's just in the sim, but the
progressbars don't work and I
On Mon, 19 Mar 2007 09:18:35 +0100, RaeNye [EMAIL PROTECTED] wrote:
I don't really care whether the intermediate represention is the same as
the WPS with comments and whitespace stripped, or with text strings
coalesced in
the end of the file and pointers attached, or an obscure binary
If we have some binary output that could be written directly to memory
lying
around on the disk, without error checking, it just screams security hole
directly
in my face. Then again, it depends where and when it is created.
And of course, I see no practical application of creating a malicious
I only suggest that the task of parsing of the text-based WPS file and
building a more efficient representation of it would be outsourced to
a viewer plugin.
I don't see how a binary intermediate format would be any more efficient
than the current highly terse WPS text format.
You surely
WPSes included with Rockbox could be provided pre-parsed, with the
core having the ability to load parsed WPSes, while unparsed WPSes go
throug the parser plugin first (which could I suppose store the
current WPS as a temporary file, to be used upon reboots)?
Then even without the plugin Rockbox
Le Monday 19 March 2007 22:08:09 Paul Louden, vous avez écrit :
WPSes included with Rockbox could be provided pre-parsed, with the
core having the ability to load parsed WPSes, while unparsed WPSes go
throug the parser plugin first (which could I suppose store the
current WPS as a temporary
WPSes included with Rockbox could be provided pre-parsed, with the
core having the ability to load parsed WPSes, while unparsed WPSes go
throug the parser plugin first (which could I suppose store the
current WPS as a temporary file, to be used upon reboots)?
Offloading the parsing to a
So I'm finally ready to present a patch for the WPS tokenizer.
The basic idea is to store the WPS as an array of tokens.
Please tell me what you think of the concept and the code.
IMHO this has the advantage of being much clearer, readable and
maintainable than the current code.
As of performance
On 18/03/07, RaeNye [EMAIL PROTECTED] wrote:
So I'm finally ready to present a patch for the WPS tokenizer.
The basic idea is to store the WPS as an array of tokens.
Please tell me what you think of the concept and the code.
IMHO this has the advantage of being much clearer, readable
I don't know exactly the details of your proposal, but I wouldn't like to
see core features of
Rockbox (like the WPS) downgraded to plugins. What about TSR plugins that
run in the
background?
Maybe I wasn't clear enough on that, but WPS displaying functionality
(interpreting) remains in the
On Mon, 2007-03-19 at 03:10 +0200, RaeNye wrote:
I only suggest that the task of parsing of the text-based WPS file and
building a more efficient representation of it would be outsourced to a
viewer plugin.
I don't see how a binary intermediate format would be any more efficient
than the
15 matches
Mail list logo
