Re: amiconn: apps settings.c,1.319,1.320

2005-11-07 Thread Ray Lambert
FWIW: I agree with those who have voted to keep this 'auto next directory' feature an option and set to OFF by default, and for the same reasons (i.e. established directory structure and usage patterns). Beyond that though, I'd like to remind folks that (IMHO) it's not generally a good idea to cha

Re: amiconn: apps settings.c,1.319,1.320

2005-11-07 Thread Tom Cole
On Mon, 7 Nov 2005 21:16:27 +0100 (MET), [EMAIL PROTECTED] wrote: >> Personally, I don't really care about which in this case. >> >> If we don't have/get what appears like a consensus, I will suggest that we >> introduce a voting-system where all committers get one vote each and the >> alternative

Re: amiconn: apps settings.c,1.319,1.320

2005-11-07 Thread Linus Nielsen Feltzing
Hardeep Sidhu wrote: I don't have access to my Archos recorder to verify this right now but I don't see why going to previous folder wouldn't work on it. If someone has one handy, would you try it out on your Archos device please. I have access to my Recorder and I have debugged it. That's ho

Re: amiconn: apps settings.c,1.319,1.320

2005-11-07 Thread jmgvb
> Personally, I don't really care about which in this case. > > If we don't have/get what appears like a consensus, I will suggest that we > introduce a voting-system where all committers get one vote each and the > alternative that gets the most votes wins. > > -- > Daniel Stenberg -- http://www

Re: amiconn: apps settings.c,1.319,1.320

2005-11-07 Thread Hardeep Sidhu
Linus Nielsen Feltzing wrote: Jens Arnold wrote: The 'skip to next folder' part of it (which was implemented before under that name) does work on archos. Yes, it works, but not fully. As I wrote in my previous email, it only works forward, not backward. You can't go to the previous director

RE: amiconn: apps settings.c,1.319,1.320

2005-11-07 Thread Anton Oleynikov
> apps/playlist.c _is_ used by the Archos devices. You are probably > confusing it with apps/playback.c Confusion came from the fact that mpeg.c has some internal procedures that have playlist name in them... Anton.

Re: amiconn: apps settings.c,1.319,1.320

2005-11-07 Thread Linus Nielsen Feltzing
Jens Arnold wrote: The 'skip to next folder' part of it (which was implemented before under that name) does work on archos. Yes, it works, but not fully. As I wrote in my previous email, it only works forward, not backward. You can't go to the previous directory. Also, there is no functional

Re: amiconn: apps settings.c,1.319,1.320

2005-11-07 Thread Dave Chapman
Anton Oleynikov wrote: >>The 'skip to next folder' part of it (which was implemented >>before under that name) does work on archos. > > > Really? The ONLY reference to global_settings.next_folder is > in the apps/playlist.c which is not used by Archos. apps/playlist.c _is_ used by the Archos d

Re: amiconn: apps settings.c,1.319,1.320

2005-11-07 Thread Daniel Stenberg
On Mon, 7 Nov 2005, Linus Nielsen Feltzing wrote: I think it might be best to have it enabled by default on the iriver. I don't believe in having different defaults for different targets, so I vote for it being on or off for all targets. Personally, I don't really care about which in this c

RE: amiconn: apps settings.c,1.319,1.320

2005-11-07 Thread Daniel Stenberg
On Mon, 7 Nov 2005, Anton Oleynikov wrote: The ONLY reference to global_settings.next_folder is in the apps/playlist.c which is not used by Archos. apps/playlist.c is used by all players that run Rockbox, including the Archos models. -- Daniel Stenberg -- http://www.rockbox.org/ -- http://

RE: amiconn: apps settings.c,1.319,1.320

2005-11-07 Thread Anton Oleynikov
> The 'skip to next folder' part of it (which was implemented > before under that name) does work on archos. Really? The ONLY reference to global_settings.next_folder is in the apps/playlist.c which is not used by Archos. Anton.

Re: amiconn: apps settings.c,1.319,1.320

2005-11-07 Thread Jens Arnold
On 07.11.2005, [IDC]Dragon wrote: >> > That was discussed with Linus way before I committed my >> > folder skip >> patch. >> It was also decided that this option would go away for good >> once moving >> to >>> the next folder implemented for Archos... > Oops, sorry then. > This is not for Arch

Re: amiconn: apps settings.c,1.319,1.320

2005-11-07 Thread Linus Nielsen Feltzing
Björn Stenberg wrote: I disagree with this. There are many occasions where next-folder is undesirable and I think it should remain an option. Just because it's possible to work around the feature by manually creating playlists does not mean the option has no value and should be removed. OK, yo

Re: amiconn: apps settings.c,1.319,1.320

2005-11-07 Thread Ronald Teune
I agree with Björn and Dave on this one too. For the rare case that I do want two or more cd's in a row, I simply add a dir to the dynamic playlist. my 2 cents Ronald On Mon, 07 Nov 2005 14:14:46 +0100, Björn Stenberg <[EMAIL PROTECTED]> wrote: Anton Oleynikov wrote: Yes, if I recall correct

Re: amiconn: apps settings.c,1.319,1.320

2005-11-07 Thread Björn Stenberg
Anton Oleynikov wrote: > Yes, if I recall correctly Linus suggested that since folder playlists are > artificial automatic playlists anyway - if user wants to stop playback at > the end he should create an actual playlist. I disagree with this. There are many occasions where next-folder is undesir

Re: amiconn: apps settings.c,1.319,1.320

2005-11-07 Thread Dave Chapman
Anton Oleynikov wrote: >>What do you mean by that? Do you mean that "directory >>navigation" will >>be the only behaviour supported by Rockbox and that the current >>behaviour (i.e. stopping playback at the end of the last track in a >>directory) will not exist? > > > Yes, if I recall correctly

RE: amiconn: apps settings.c,1.319,1.320

2005-11-07 Thread Anton Oleynikov
> What do you mean by that? Do you mean that "directory > navigation" will > be the only behaviour supported by Rockbox and that the current > behaviour (i.e. stopping playback at the end of the last track in a > directory) will not exist? Yes, if I recall correctly Linus suggested that since fo

Re: amiconn: apps settings.c,1.319,1.320

2005-11-07 Thread Dave Chapman
Anton Oleynikov wrote: > It was also decided that this option would go away for good once moving to > the > next folder implemented for Archos... What do you mean by that? Do you mean that "directory navigation" will be the only behaviour supported by Rockbox and that the current behaviour (i.e.

Re: amiconn: apps settings.c,1.319,1.320

2005-11-07 Thread Linus Nielsen Feltzing
[IDC]Dragon wrote: This is not for Archos? (See how the overview on my end degrades) The Archos playback code uses the playlist functions in a different way, so currently there is no way to go to the previous directory. Linus

RE: amiconn: apps settings.c,1.319,1.320

2005-11-07 Thread Daniel Stenberg
On Mon, 7 Nov 2005, [IDC]Dragon wrote: Most changes don't make it into the list, we (you, these days) discuss mostly on IRC. I know, but I too has had very little time to follow the development closely laltely so I feel that we lose something by doing this exclusively. I'm not saying we nee

RE: amiconn: apps settings.c,1.319,1.320

2005-11-07 Thread [IDC]Dragon
> > That was discussed with Linus way before I committed my folder skip > patch. > > It was also decided that this option would go away for good once moving > to > > the next folder implemented for Archos... Oops, sorry then. This is not for Archos? (See how the overview on my end degrades) >

RE: amiconn: apps settings.c,1.319,1.320

2005-11-07 Thread Daniel Stenberg
On Mon, 7 Nov 2005, Anton Oleynikov wrote: That was discussed with Linus way before I committed my folder skip patch. It was also decided that this option would go away for good once moving to the next folder implemented for Archos... Ok, if Linus approved of this patch then I think the actua

RE: amiconn: apps settings.c,1.319,1.320

2005-11-07 Thread Anton Oleynikov
Behalf Of Daniel Stenberg > Sent: Monday, November 07, 2005 10:09 AM > To: Rockbox Development > Subject: Re: amiconn: apps settings.c,1.319,1.320 > > On Mon, 7 Nov 2005, [EMAIL PROTECTED] wrote: > > > Please discuss default changes in the future! > > Here's th

Re: amiconn: apps settings.c,1.319,1.320

2005-11-07 Thread [IDC]Dragon
> > Please discuss default changes in the future! > > Here's the change Jens just reverted: > >http://www.rockbox.org/viewcvs.cgi/apps/settings.c?r1=1.309&r2=1.310 Not only the default was changed, also the ascii name was changed, which breaks compatibility to existing .cfg files. :-( Jörg

Re: amiconn: apps settings.c,1.319,1.320

2005-11-07 Thread Daniel Stenberg
On Mon, 7 Nov 2005, [EMAIL PROTECTED] wrote: Please discuss default changes in the future! Here's the change Jens just reverted: http://www.rockbox.org/viewcvs.cgi/apps/settings.c?r1=1.309&r2=1.310 len0x, this is the second default change you've done in very short time after only having C