how should ata_idle_notify handle SYS_USBCONNECTED and SYS_SHUTDOWN?

2006-11-07 Thread Jonathan Gordon
hey, I'm pretty sure that the idle notify callbacks should be called for these 2 events. the problem is whats the best way to do it? Because there is no way to know which thread gets the event in what order (I assume this is the case) there could be callbacks putting events on another threads que

Re: how should ata_idle_notify handle SYS_USBCONNECTED and SYS_SHUTDOWN?

2006-11-07 Thread Linus Nielsen Feltzing
Jonathan Gordon wrote: hey, I'm pretty sure that the idle notify callbacks should be called for these 2 events. I'm not. Let the callback owners deal with that. Linus

Re: how should ata_idle_notify handle SYS_USBCONNECTED and SYS_SHUTDOWN?

2006-11-07 Thread Jonathan Gordon
Are you sure? The problem is with callback owners who dont have thier own threads (i.e the delayed settings saving). unless the ata thread calls that callback it wont happen. Unless its no big deal if settings are not saved on shutdown/usb? On 08/11/06, Linus Nielsen Feltzing [EMAIL PROTECTED]

Re: how should ata_idle_notify handle SYS_USBCONNECTED and SYS_SHUTDOWN?

2006-11-07 Thread Jonathan Gordon
On 08/11/06, Jonathan Gordon [EMAIL PROTECTED] wrote: Are you sure? The problem is with callback owners who dont have thier own threads (i.e the delayed settings saving). unless the ata thread calls that callback it wont happen. Unless its no big deal if settings are not saved on shutdown/usb?