Re: usb.c warning

2012-01-04 Thread Michael Sevakis
I still haven't seen a report of it working on a non-USB_DETECT_BY_CORE such as nano2g. Did I miss that? Ideally I'd also like to see if USB_DETECT_BY_CORE now magically works for those now. Frank I did test it on the Clip v1 bootloader without difficulties, which doesn't use ...BY_CORE, if th

Re: usb.c warning

2012-01-04 Thread Frank Gevaerts
On Wed, Jan 04, 2012 at 11:13:11AM -0500, Michael Sevakis wrote: > If that patch goes in to fix FreeBSD (why isn't it commited?), it > won't matter anyway. I still haven't seen a report of it working on a non-USB_DETECT_BY_CORE such as nano2g. Did I miss that? Ideally I'd also like to see if USB_D

Re: usb.c warning

2012-01-04 Thread Michael Sevakis
Almost certainly not. This looks like a bug waiting to happen to me. Frank If that patch goes in to fix FreeBSD (why isn't it commited?), it won't matter anyway. Mike

Re: usb.c warning

2012-01-04 Thread Michael Sevakis
Hi, Noticed a warning for this code in firmware/usb.c, line 557 (as of r31578): status = (status == USB_INSERTED) ? : USB_EXTRACTED; According to the gcc manual (section 5.7), the expression "x ? : y" (a gcc extension) has the value x if x is nonzero, otherwise z. So, status is set to "

Re: usb.c warning

2012-01-04 Thread Frank Gevaerts
On Wed, Jan 04, 2012 at 05:00:09PM +0100, Magnus Holmgren wrote: > Hi, > > Noticed a warning for this code in firmware/usb.c, line 557 (as of r31578): > > status = (status == USB_INSERTED) ? : USB_EXTRACTED; > > According to the gcc manual (section 5.7), the expression "x ? : y" > (a gcc ext

Re: usb.c warning

2012-01-04 Thread Michael Sevakis
Yes. It's just like "status = (status == USB_INSERTED) ? status : USB_EXTRACTED;" Hi, Noticed a warning for this code in firmware/usb.c, line 557 (as of r31578): status = (status == USB_INSERTED) ? : USB_EXTRACTED; According to the gcc manual (section 5.7), the expression "x ? : y" (a

usb.c warning

2012-01-04 Thread Magnus Holmgren
Hi, Noticed a warning for this code in firmware/usb.c, line 557 (as of r31578): status = (status == USB_INSERTED) ? : USB_EXTRACTED; According to the gcc manual (section 5.7), the expression "x ? : y" (a gcc extension) has the value x if x is nonzero, otherwise z. So, status is set to "tr