I've taken a quick look at this and it may be me that broke it.
The fix that prevented crashing due to contexts not being ready and more than
one context with the same FD etc. You know the one thats really difficult to
explain.
It probably broke asynch operation.
I made several
I'm not sure you fixed this.
My earlier post indicates that a similar situation still exists.
Sun Feb 21 2010 14:37:29 EST from dothebart
dotheb...@uncensored.citadel.org Subject: Citadel commit log: revision
8354
I made several assumptions on the types of contexts that could be selected on
and which ones to check the fd of after select. Maybe these assumptions are
flawed.
What exactly happens to the context when an async message is sent?
Check out modules/xmpp/xmpp_queue.c arolines
Got it.
Yep, its broken, definately, Now I have that description its obvious.
To fix the problem with re-used fd-s before contexts got cleaned / removed
and crashing and all that I went to great pains to ensure we only chose
contexts with activity on the fd to bind to. I didn't consider that
IG, I'm trying to test this but my pidgin won't connect.
It reports unknown error.
In the citserver log I get Ignoring unknown tag bind just before the
connection gets closed.
Wed Feb 24 2010 08:33:14 EST from IGnatius T Foobar @ Uncensored
Subject: Re: asynch not working
r8370 | davew | 2010-02-24 11:32:08 -0500 (Wed, 24 Feb 2010) | 1 line
Changed paths:
M /trunk/citadel/sysdep.c
Fix async messages (hopefully).
Fix async messages (hopefully).
Nope.
r8372 | davew | 2010-02-24 13:26:10 -0500 (Wed, 24 Feb 2010) | 1 line
Changed paths:
M /branches/citadel_context_rework/context.c
M /branches/citadel_context_rework/housekeeping.c
M
OK, so what exactly (versions) do I need to test this.
I can't get my pidgin to connect.
Wed Feb 24 2010 12:49:35 EST from IGnatius T Foobar @ Uncensored
Subject: Re: Citadel commit log: revision 8370
Fix async messages (hopefully).
Nope.
If you send a message from Cit client to pidgin the message doesn't arrive.
Got that bit.
Question. Does the message from Cit client arrive when pidgin sends a new
message to Cit client?
Wed Feb 24 2010 08:33:14 EST from IGnatius T Foobar @ Uncensored
Subject: Re: asynch not
IG, I've got my pidgin to connect now but I have a totally different problem.
As soon as my pidgin sends to the citserver the citserver dives off into an
endless loop in dothebarts new buffered IO code.
Now thats a different problem that causes me issues instead.
More info.
The loop of error messages from Dothebart's IO code is not directly related.
Seems Citadel chat trigers that somehow and so does otherthings maybe.
IG, I just can't get it to work in either direction. I'm seeing the SEXP and
GEXP but theres nothing in them.
Perhaps there is
If you send a message from Cit client to pidgin the message doesn't arrive.
Got that bit.
Question. Does the message from Cit client arrive when pidgin sends a new
message to Cit client?
It should, at least it did when I tested it.
Pidgin should also receive
As soon as my pidgin sends to the citserver the citserver dives off into an
endless loop in dothebarts new buffered IO code.
Now thats a different problem that causes me issues instead.
I didn't see that, but perhaps I'll try it again.
By the way, Citadel clients *poll*
hm, I found a Bug in that and committed it last sunday. Messages made it from one box to another after that...
does it still loop for you?
Mi Feb 24 2010 14:31:00 EST von davew @ Uncensored Betreff: async stuff
More info.
The loop of error messages from Dothebart's IO code is not directly
r8374 | ajc | 2010-02-25 00:56:07 -0500 (Thu, 25 Feb 2010) | 1 line
Changed paths:
M /trunk/citadel/context.c
* Working on async
Ok, it seems that the buffered I/O *is* causing a problem.
sysdep.c : 1147
HaveMoreLinesWaiting() *always* returns 1, until the session ends. As a
result,
we never fall through the loop until the session is ending, which explains why
we
never get around to processing our async
17 matches
Mail list logo
