[Citadel Development] dpkg-buildpackage of latest git of webcit fails

2015-03-18 Thread harryc
webcit build note:Latest git-pull into an empty directory, followed by a dpkg-buildpackage, on Ubuntu LTS Trusty 14.04 had a build that failed with:LD: webcitmsg_renderers.o: In function `render_MAIL_markdown':msg_renderers.c:(.text+0x1d49): undefined reference to

[Citadel Development] Fix to incorrect group privilege escalation in webcit

2015-03-18 Thread harryc
Webcit has an unwelcome group privilege escalation owing to a missing line in webcit/configure.ac, and a related patch to webcit/sysdep.c Kindly notice that when webcit starts up, this appears in the syslog: ... Mar 18 17:56:56 email2 webcit[24601]: Message catalog directory:

[Citadel Development] webcit: kernel: [..] traps: webcit[24889] general protection w/patch

2015-03-18 Thread harryc
When attempting via webcit to visit the global address book room of a newly created user (no messages), this crash appears in the syslog: kernel: [112197.282170] traps: webcit[24889] general protection ip: Investigations led to a few patches, correcting the problem, as follows: Mar 18 19:12:45

[Citadel Development] Re: dpkg-buildpackage of latest git of webcit fails w/patch

2015-03-18 Thread harryc
Ref the previous webcit build bug report, the problem was in the makefile -lmarkdown was too soon in the library list. editing the makefile allowed proper completion, but the makefile got wiped out every dpkg-buildpackage.  So a similar change in configure led to the correct makefile, whichgot

[Citadel Development] Re: dpkg-buildpackage of latest git of webcit fails w/patch

2015-03-18 Thread harryc
Also, in the spirit of 'belt-and-suspenders' programming practices:   --- webcit-8.24-dfsg/webcit.h    2014-01-27 09:42:11.0 -0600+++ webcit-8.24-dfsg/webcit.h.new    2014-10-23 14:12:58.638800940 -0500@@ -64,7 +64,7 @@ #define _(string)    (string) #endif -#define IsEmptyStr(a) ((a)[0]