>From my experience using other gitlab installations, yes you have to create
a branch and then commit that branch, and then you can create a merge request.
When the merge is approved (and I haven't set any approval rules so we might
have to experiment there) there is a "delete source branch" optio
Did not mean to attach the patch in the last message.
It looks like Merge requires you to create a branch to merge. Do you have
any naming conventions you would like to use for branch names or is there a
different way you want to submit code?
> Thu Jun 01 2023 09:32:30 PM EDT from HarlowSolu
GitLab looks nice. I figured out how to clone and I created a patch. I
will go and try to use merge.
0001-IMAP_Flag_Clearing_and_User_Purge_Vist_Records.patch
Description: Binary data
Ok, I see you logged in to GitLab. Your account is registered and added to
the Citadel group as a developer. You can probably add your external email
address and make it primary if you want to at this point.
At this point you *should* be able to submit Merge Requests for patches.
This is ne
>fixed a couple of defects with the existing code that I am just going to
>include with the new flag support. Small but if you want me to submit
>separate, let me know.
I'd like it if you did that, please. If for no other reason, it would be
a great way for us both to get used to
I'm not surprised. That code has seen a lot of tweaking by a number of people
and it could use some attention.
The underlying data formats are at the front of my attention right now because
I'
m writing a utility to convert a 32-bit database to 64-bit, and it's uncovering
a number of differ
I am testing a complete replacement for the Visit handling. Looking good so
far, but since we don't have a set of tests to check for regression, I am
just running it and trying to hit as many code paths as I can. In order
to add all the IMAP flags, I had to pretty much rewrite the related code.