The branch version has 99% comments changes (// versus ;),
#define versus equ at the top for the constants,
and the last change is to tell gas its using intel syntax.
Almost the entire tree is built using gas, hence the change.
Kind regards,
Sylvain Petreolle
- Message d'origine
> De
Since fathelp was already in Intel syntax originally, why did we require a
new version from another branch? What was changed?
-Original Message-
From: ros-dev-boun...@reactos.org [mailto:ros-dev-boun...@reactos.org] On
Behalf Of Sylvain Petreolle
Sent: Friday, September 03, 2010 8:50 AM
T
I guess I'll weigh in here...
Personally I prefer Intel syntax, but that alone is not a good reason to
keep it Intel. However, I have spent many hours (measured in man-months
actually) testing, debugging, and stepping through this boot sector code
(both on real hardware and simulators/emulators) t
Hi,
why reimplementing an unsecure IoReadPartitionTable version? It even looks like
IoReadPartitionTableEx() which may arrive soon in ReactOS ;).
Best regards,
P. Schweitzer
___
Ros-dev mailing list
Ros-dev@reactos.org
http://www.reactos.org/mailman/lis
Hi,
What You say makes sense of course.
I can't find time to dig into the code, but it sounds like you acted
correctly.
We can of course improve the setup behavior as time goes and we learn how
to do it right with various boot managers, no need to take after
Microsoft here,
but there will al
