Re: [ros-dev] [ros-diffs] [jgardou] 52831: [LIBWINE] - new tentative to fix build : get rid of libwine's stricmp, we have it in our crt

2011-07-24 Thread Gabriel ilardi
Wouldn't it be advisable besides the commit message also to add a comment to the code as why stuff is commented out ? > Date: Sun, 24 Jul 2011 10:29:53 + > To: ros-di...@reactos.org > From: jgar...@svn.reactos.org > Subject: [ros-diffs] [jgardou] 52831: [LIBWINE] - new tentative to fix buil

Re: [ros-dev] cmake rant

2011-07-24 Thread caemyr
After some checks, it seems that a single header file change takes around 1m to do a quick rebuild. If cmake files are touched, CMake does recheck and it takes around 3-3.5m. The full build takes around 5m. Please mind that these values are affected by CCache. On Sat, 23 Jul 2011 18:38 -0500,

Re: [ros-dev] cmake rant

2011-07-24 Thread caemyr
The test runtime is working again. Seems that debugging is back to working state, even without umode autotracing. We should now push the cmake transition. Waiting wont change much, will only make it more difficut. On Sun, 24 Jul 2011 15:48 +0200, cae...@myopera.com wrote: > After some checks, i

Re: [ros-dev] [ros-diffs] [jgardou] 52840: [CRT] - get back atexit handling as it was before. (reverts 52838, 52829, 52828) Thanks to Kai and Timo for the explanation

2011-07-24 Thread Jérôme Gardou
Reverts 52836, 52829 and 52828, sorry. Le 24/07/2011 18:45, jgar...@svn.reactos.org a écrit : Author: jgardou Date: Sun Jul 24 16:45:41 2011 New Revision: 52840 URL: http://svn.reactos.org/svn/reactos?rev=52840&view=rev Log: [CRT] - get back atexit handling as it was before. (reverts 52838, 528