Re: [ros-dev] [ros-diffs] [tfaber] 64749: [PSDK] - Use macro version of RtlUlonglongByteSwap in winternl.h because using the fastcall version causes stack corruption CORE-8632 #resolve

2014-10-15 Thread Ged Murphy
There shouldn't really be anything using this header -Original Message- From: Ros-diffs [mailto:ros-diffs-boun...@reactos.org] On Behalf Of tfa...@svn.reactos.org Sent: 15 October 2014 17:38 To: ros-di...@reactos.org Subject: [ros-diffs] [tfaber] 64749: [PSDK] - Use macro version of

Re: [ros-dev] [ros-diffs] [tfaber] 64749: [PSDK] - Use macro version of RtlUlonglongByteSwap in winternl.h because using the fastcall version causes stack corruption CORE-8632 #resolve

2014-10-15 Thread Thomas Faber
It's there for Wine compatibility. Things we would put in NDK, they put in winternl.h. On 2014-10-15 19:08, Ged Murphy wrote: There shouldn't really be anything using this header -Original Message- From: Ros-diffs [mailto:ros-diffs-boun...@reactos.org] On Behalf Of

Re: [ros-dev] [ros-diffs] [hbelusca] 64747: [NTVDM]: Zero-fill memory with RtlZeroMemory (that exists also in NT mode), and use sizeof(object) instead of sizeof(type_of_object).

2014-10-15 Thread Timo Kreuzer
Looks like bugs Am 15.10.2014 00:46, schrieb hbelu...@svn.reactos.org: Author: hbelusca Date: Tue Oct 14 22:46:40 2014 New Revision: 64747 URL: http://svn.reactos.org/svn/reactos?rev=64747view=rev Log: [NTVDM]: Zero-fill memory with RtlZeroMemory (that exists also in NT mode), and use

Re: [ros-dev] [ros-diffs] [tfaber] 64749: [PSDK] - Use macro version of RtlUlonglongByteSwap in winternl.h because using the fastcall version causes stack corruption CORE-8632 #resolve

2014-10-15 Thread Timo Kreuzer
What I really wonder: since the function behaves like cdecl, why does wine declare it as fastcall? Or is this also our own hack, because the function has fastcall symbols and it's declared as fastcall in wdm.h for compilers with _MSC_FULL_VER = 13009037? IMO we should remove all traces of it

Re: [ros-dev] [ros-diffs] [pschweitzer] 64752: [NTFS] Implement NtfsDateTimeToFileTime() which convert epoch time (1970) to Windows time (1601)

2014-10-15 Thread Thomas Faber
On 2014-10-15 22:23, pschweit...@svn.reactos.org wrote: +/* See: + - http://msdn.microsoft.com/en-us/library/ms724228 + - http://bos.asmhackers.net/docs/filesystems/ntfs/standard.html#layout + */ +VOID +NtfsDateTimeToFileTime(ULONGLONG NtfsTime, + PLARGE_INTEGER

Re: [ros-dev] [ros-diffs] [tfaber] 64695: [ROSAUTOTEST] - DbgPrint expects a format string! ROSTESTS-145 #resolve

2014-10-15 Thread Thomas Faber
On 2014-10-12 21:37, Colin Finck wrote: tfa...@svn.reactos.org wrote: -DbgPrint(DbgString); +OutputDebugStringA(DbgString); FYI, we had OutputDebugStringA there in the first place, but I changed it to DbgPrint in r40147. IIRC, output from DbgPrint was

Re: [ros-dev] [ros-diffs] [pschweitzer] 64752: [NTFS] Implement NtfsDateTimeToFileTime() which convert epoch time (1970) to Windows time (1601)

2014-10-15 Thread Pierre Schweitzer
My link says: Values are stored in universal coordinated time, like in Linux. This is what I interpret as: stored with epoch, need to shift to 1601. On 15/10/2014 22:46, Thomas Faber wrote: On 2014-10-15 22:23, pschweit...@svn.reactos.org wrote: +/* See: + -