Re: [ros-dev] [ros-diffs] [jgardou] 66334: [NTOSKRNL/MM] - MiIsEntireRangeCommitted: Ensure the PTE we are checking is really faulted in. - Prefer MiPteToPde and MiPdeToPte (which should really be cal

2015-02-18 Thread Alex Ionescu
it might fix an assert but the patch is incorrect. will this also take 6 months to revert? Best regards, Alex Ionescu On Tue, Feb 17, 2015 at 6:19 AM, wrote: > Author: jgardou > Date: Tue Feb 17 14:19:05 2015 > New Revision: 66334 > > URL: http://svn.reactos.org/svn/reactos?rev=66334&view=rev >

Re: [ros-dev] VirtualBox Testslave

2015-02-18 Thread Pierre Schweitzer
Hi Colin, I will have a look at sysreg2. Please make sure that the NUC is setup with the latest LTS. It will make the process smoother. Cheers, Pierre On 18/02/2015 11:17, Colin Finck wrote: > Hi all, > > As tests have shown that VirtualBox doesn't work properly inside an > already virtualized

[ros-dev] VirtualBox Testslave

2015-02-18 Thread Colin Finck
Hi all, As tests have shown that VirtualBox doesn't work properly inside an already virtualized environment, ReactOS Deutschland e.V. has just ordered a tiny Intel NUC that will serve as a VirtualBox Testslave. We plan to set it up right next to our Buildslaves, so that every ISO could possibly be

Re: [ros-dev] [jira] (ROSTESTS-153) gdi32_winetest:bitmap test_mono_bitmap skipped because it takes too long and spams the debug log with too many failures

2015-02-18 Thread Thomas Faber
On 2015-02-16 11:19, Jérôme Gardou wrote: >> However I don't see a practical way to implement your solution. For one, >> the timeout seems like it would have to cause a machine reboot, which >> significantly increases test time. I guess rosautotest could keep track >> of the time and kill the child

Re: [ros-dev] [ros-diffs] [jgardou] 66342: [WIN32SS/NTGDI] - Reject bits data early in SetBitmapBits when it's clear that they can't fit in the destination bitmap. Fixes ugly Office 2007 rulers showin

2015-02-18 Thread Jérôme Gardou
I don't really see what we could be doing wrong here. We're not responsible for the data an application passes to us. If we're not capable of correctly giving back the tuple (width,height, bpp) which permits to calculate the buffer size, we'd better stop everything and start thinking about raising

Re: [ros-dev] [ros-diffs] [jgardou] 66342: [WIN32SS/NTGDI] - Reject bits data early in SetBitmapBits when it's clear that they can't fit in the destination bitmap. Fixes ugly Office 2007 rulers showin

2015-02-18 Thread Timo Kreuzer
Is this a bug in Office 2007 or are we doing something wrong here? Am 17.02.2015 um 21:41 schrieb jgar...@svn.reactos.org: Author: jgardou Date: Tue Feb 17 20:41:51 2015 New Revision: 66342 URL: http://svn.reactos.org/svn/reactos?rev=66342&view=rev Log: [WIN32SS/NTGDI] - Reject bits data ea