Re: [ros-dev] [ros-diffs] [tthompson] 71820: [NTFS] Add ability to write to resident attributes. SetAttributeDataLength() - Check if the file is memory mapped before truncating +InternalSetResidentAtt

Hi Pierre, thanks for the fast review! I'll respond inline. On Tue, Jul 5, 2016 at 4:39 PM, Pierre Schweitzer wrote: > Hi, > > Comments inline. > > Le 05/07/2016 09:00, tthomp...@svn.reactos.org a écrit : > > Modified: branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/mft.c > > URL: > http://svn.

Re: [ros-dev] [ros-diffs] [tthompson] 71820: [NTFS] Add ability to write to resident attributes. SetAttributeDataLength() - Check if the file is memory mapped before truncating +InternalSetResidentAtt

Le 06/07/2016 19:59, Trevor Thompson a écrit : > Hi Pierre, thanks for the fast review! I'll respond inline. > > On Tue, Jul 5, 2016 at 4:39 PM, Pierre Schweitzer > wrote: > >> Hi, >> >> Comments inline. >> >> Le 05/07/2016 09:00, tthomp...@svn.reactos.org a écrit : >> ==

Re: [ros-dev] [ros-diffs] [tthompson] 71807: [NTFS][FREELDR] Fix ReadAttribute() and NtfsReadAttribute() in the case when an attribute contains two data runs; Remove extra if statement that prevents s

Actually, this (duplicated) function looks quite poorly designed (not your fault, obviously :-p). The more you fix it, the more it seems natural that the first specific case should be integrated in the while loop for real. That would make the function more robust, with less duplicated code (and thu