Re: [ros-dev] [ros-diffs] 01/01: [USERSRV] HardError: Fix compilation warning; fix few comments; fix the default empty window title string.

2018-06-09 Thread Thomas Faber
On 2018-04-08 16:17, Hermès Bélusca-Maïto wrote: /* Retrieve the window title of the client, if it has one */ -RtlInitEmptyUnicodeString(&WindowTitleU, NULL, 0); +RtlInitEmptyUnicodeString(&WindowTitleU, L"", 0); This looks like a bug. Can you explain why you think it's necessary

Re: [ros-dev] [ros-diffs] 01/01: [USERSRV] HardError: Fix compilation warning; fix few comments; fix the default empty window title string.

2018-06-09 Thread Hermès BÉLUSCA-MAÏTO
This change (on my own code snippet btw, see commit 5a1a35ca5a6) was necessary because otherwise, the StringPrintf call that is done below (which would then use a WindowTitleU.Buffer == NULL) would generate the harderror dialog title: "(null)" (in addition to other strings being appended), inste

Re: [ros-dev] ReactOS mirror repo detected on GitLab

2018-06-09 Thread Mark Jansen
Well, I have not heard of anyone working on this, and considering noone replied I would say it's not official. On 8-6-2018 16:55, Stas'M wrote: I've found this mirror repo on GitLab, it was created today: https://gitlab.com/reactos/reactos Does it belong to the ReactOS team? If not, we may hav

Re: [ros-dev] ReactOS mirror repo detected on GitLab

2018-06-09 Thread Oleksandr Shaposhnikov
> Well, I have not heard of anyone working on this, > and considering noone replied I would say it's not official. Well this "Reactos Fond" clearly has nothing to do with us :P -- Cheers, Oleksandr signature.asc Description: This is a digitally signed message part. __

Re: [ros-dev] [ros-diffs] 01/01: [USERSRV] HardError: Fix compilation warning; fix few comments; fix the default empty window title string.

2018-06-09 Thread Thomas Faber
A UNICODE_STRING with Length==0 is an empty string, the value of Buffer is irrelevant. If RtlInitEmptyUnicodeString(&EmptyString, NULL, 0); printf("%wZ", &EmptyString); prints "(null)", then that's a bug in printf. This special-casing with L"" is highly irregular and should be avoided. On 2018