Re: [ros-dev] [ros-diffs] [cgutman] 46876: [PCMCIA] - Add a mostly stubbed PCMCIA driver - pcmcia.c is complete but fdo.c and pdo.c are completely unimplemented

2010-04-16 Thread Olaf Siejka
Usefull indeed, though we should be more strict on what goes into the trunk. The more code goes there, the longer build takes, also there is a bigger chance to break trunk with other changes. This is why we should isolate trunk/apps/tests from other things, then tidy it up and reorganize it. All

Re: [ros-dev] [ros-diffs] [cgutman] 46876: [PCMCIA] - Add a mostly stubbed PCMCIA driver - pcmcia.c is complete but fdo.c and pdo.c are completely unimplemented

2010-04-16 Thread Andrew Faulds
ROSLite? Sent from my iPod Andrew Faulds On 16 Apr 2010, at 10:48, Olaf Siejka cae...@gmail.com wrote: Usefull indeed, though we should be more strict on what goes into the trunk. The more code goes there, the longer build takes, also there is a bigger chance to break trunk with other changes.

Re: [ros-dev] [ros-diffs] [cgutman] 46876: [PCMCIA] - Add a mostly stubbed PCMCIA driver - pcmcia.c is complete but fdo.c and pdo.c are completely unimplemented

2010-04-16 Thread breakoutbox
Andrew Faulds schrieb: ROSLite? If then ReactOS runs more stable - do it ! ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev

Re: [ros-dev] [ros-diffs] [cgutman] 46876: [PCMCIA] - Add a mostly stubbed PCMCIA driver - pcmcia.c is complete but fdo.c and pdo.c are completely unimplemented

2010-04-16 Thread Olaf Siejka
Too soon for more than one trunk. I only concur of what devs say, trunk has to be revised and possibly - skimmed a bit. Look, why is atapi still in trunk?? Stuff like this take up precious buildtime and space. 2010/4/16 breakoutbox breakout...@web.de Andrew Faulds schrieb: ROSLite? If

Re: [ros-dev] [ros-diffs] [cgutman] 46876: [PCMCIA] - Add a mostly stubbed PCMCIA driver - pcmcia.c is complete but fdo.c and pdo.c are completely unimplemented

2010-04-15 Thread Aleksey Bragin
I fully agree with Ged. I know it's fun to create something from scratch (I used and will still do, of course) and work in an explored area, however I think there should be some control. If you really want to work on that and nothing else - we have rosapps/drivers. In my opinion, trunk has

Re: [ros-dev] [ros-diffs] [cgutman] 46876: [PCMCIA] - Add a mostly stubbed PCMCIA driver - pcmcia.c is complete but fdo.c and pdo.c are completely unimplemented

2010-04-15 Thread Andrew Faulds
You mean we're supporting an interface no-one needs before the biggest gap in ReactOS I/O support? 2010/4/15 Javier Agustìn Fernàndez Arroyo elh...@gmail.com ReactOS has PCMCIA support before USB lol :) On Thu, Apr 15, 2010 at 10:46 AM, Aleksey Bragin alek...@reactos.orgwrote: I fully

Re: [ros-dev] [ros-diffs] [cgutman] 46876: [PCMCIA] - Add a mostly stubbed PCMCIA driver - pcmcia.c is complete but fdo.c and pdo.c are completely unimplemented

2010-04-15 Thread Peter Millerchip
Yes, I agree too - trunk should ideally not contain non-working code. Maybe non-working drivers belong in a branch until they've been fully tested? Maybe trunk should be locked to everyone except a trunk manager who accepts patches from people, or merges different branches in to trunk. That way

Re: [ros-dev] [ros-diffs] [cgutman] 46876: [PCMCIA] - Add a mostly stubbed PCMCIA driver - pcmcia.c is complete but fdo.c and pdo.c are completely unimplemented

2010-04-15 Thread Peter Millerchip
To be fair: 1. The guy donated his code to ReactOS. Think of it like a gift to us - it might not be what we really wanted, but it's still rude to insult a gift. 2. This isn't support for PCMCIA, it's a stub - he said so himself. ReactOS does not support PCMCIA yet. 3. Windows supported PCMCIA

Re: [ros-dev] [ros-diffs] [cgutman] 46876: [PCMCIA] - Add a mostly stubbed PCMCIA driver - pcmcia.c is complete but fdo.c and pdo.c are completely unimplemented

2010-04-15 Thread Andrew Faulds
Yes, but we get donations on all sorts of unnecessary things. We really need donations in *useful areas* like, say, USB. On 15 April 2010 10:25, Peter Millerchip peter.millerc...@gmail.com wrote: To be fair: 1. The guy donated his code to ReactOS. Think of it like a gift to us - it might not

Re: [ros-dev] [ros-diffs] [cgutman] 46876: [PCMCIA] - Add a mostly stubbed PCMCIA driver - pcmcia.c is complete but fdo.c and pdo.c are completely unimplemented

2010-04-15 Thread Javier Agustìn Fernàndez Arroyo
bad one, i guess that would slow down development a lot On Thu, Apr 15, 2010 at 11:14 AM, Peter Millerchip peter.millerc...@gmail.com wrote: Yes, I agree too - trunk should ideally not contain non-working code. Maybe non-working drivers belong in a branch until they've been fully tested?

Re: [ros-dev] [ros-diffs] [cgutman] 46876: [PCMCIA] - Add a mostly stubbed PCMCIA driver - pcmcia.c is complete but fdo.c and pdo.c are completely unimplemented

2010-04-15 Thread Peter Millerchip
No it wouldn't slow down development, people would just develop on branches at the same speed as they do now. It would just mean that trunk would only get the features when they work, rather than having incomplete and untested code littering it. Don't knock it, it works for the Linux kernel devs

Re: [ros-dev] [ros-diffs] [cgutman] 46876: [PCMCIA] - Add a mostly stubbed PCMCIA driver - pcmcia.c is complete but fdo.c and pdo.c are completely unimplemented

2010-04-15 Thread Javier Agustìn Fernàndez Arroyo
well, it will be useful whenever it has to :) so, i dont see it as a bad commit after all, just funny :P On Thu, Apr 15, 2010 at 11:28 AM, Andrew Faulds ajf...@googlemail.comwrote: Yes, but we get donations on all sorts of unnecessary things. We really need donations in *useful areas* like,

Re: [ros-dev] [ros-diffs] [cgutman] 46876: [PCMCIA] - Add a mostly stubbed PCMCIA driver - pcmcia.c is complete but fdo.c and pdo.c are completely unimplemented

2010-04-15 Thread Andrew Faulds
But wait with Linux doesn't it work because there's one person ultimately controlling it? On 15 April 2010 10:37, Peter Millerchip peter.millerc...@gmail.com wrote: No it wouldn't slow down development, people would just develop on branches at the same speed as they do now. It would just mean

Re: [ros-dev] [ros-diffs] [cgutman] 46876: [PCMCIA] - Add a mostly stubbed PCMCIA driver - pcmcia.c is complete but fdo.c and pdo.c are completely unimplemented

2010-04-15 Thread Peter Millerchip
Exactly - so surely if we nominate a trunk manager they would perform that role? That would work, wouldn't it? Their job would be to accept fully tested patches into trunk, or reject immature or broken patches. They would be like the Linus of ReactOS, the guy who says whether stuff is good enough

Re: [ros-dev] [ros-diffs] [cgutman] 46876: [PCMCIA] - Add a mostly stubbed PCMCIA driver - pcmcia.c is complete but fdo.c and pdo.c are completely unimplemented

2010-04-15 Thread Andrew Faulds
Yes. We need a Linus Torvalds for ReactOS. If it worked for Linux, it'll work for ReactOS. On 15 April 2010 10:53, Peter Millerchip peter.millerc...@gmail.com wrote: Exactly - so surely if we nominate a trunk manager they would perform that role? That would work, wouldn't it? Their job would

Re: [ros-dev] [ros-diffs] [cgutman] 46876: [PCMCIA] - Add a mostly stubbed PCMCIA driver - pcmcia.c is complete but fdo.c and pdo.c are completely unimplemented

2010-04-15 Thread Ged Murphy
So the whole project should continue to stagnate, but that's ok because you can get debug info off your notebook... I think it's much more important to get things moving forward in virtual machines than your laptops debug output. Ged. -Original Message- From:

Re: [ros-dev] [ros-diffs] [cgutman] 46876: [PCMCIA] - Add a mostly stubbed PCMCIA driver - pcmcia.c is complete but fdo.c and pdo.c are completely unimplemented

2010-04-15 Thread Timo Kreuzer
Andrew Faulds wrote: Yes. We need a Linus Torvalds for ReactOS. If it worked for Linux, it'll work for ReactOS. No. A trunk manager selecting what he likes won't work for reactos, because we just don't have enough devs for any kind of cherry picking. We need to take what we get. It would

Re: [ros-dev] [ros-diffs] [cgutman] 46876: [PCMCIA] - Add a mostly stubbed PCMCIA driver - pcmcia.c is complete but fdo.c and pdo.c are completely unimplemented

2010-04-15 Thread Daniel Reimer
Good luck in finding hobby programmers who do what you tell em to do. As long as you cant pay them, its hard to force them in direction. If they loose interest or fun in coding for ROS then we are not just stagnating, we are deserted. If you wanna risk this, feel free to. I cant and wont stop

Re: [ros-dev] [ros-diffs] [cgutman] 46876: [PCMCIA] - Add a mostly stubbed PCMCIA driver - pcmcia.c is complete but fdo.c and pdo.c are completely unimplemented

2010-04-15 Thread Javier Agustìn Fernàndez Arroyo
hm? On Thu, Apr 15, 2010 at 8:33 PM, Samuel serapion samdwis...@gmail.comwrote: Javier this isn't funny. ReactOS is serious business. 2010/4/15 Javier Agustìn Fernàndez Arroyo elh...@gmail.com well, it will be useful whenever it has to :) so, i dont see it as a bad commit after all, just

Re: [ros-dev] [ros-diffs] [cgutman] 46876: [PCMCIA] - Add a mostly stubbed PCMCIA driver - pcmcia.c is complete but fdo.c and pdo.c are completely unimplemented

2010-04-15 Thread Ged Murphy
On 15 April 2010 19:22, Daniel Reimer daniel.rei...@stud-mail.uni-wuerzburg.de wrote: Good luck in finding hobby programmers who do what you tell em to do. As long as you cant pay them, its hard to force them in direction. If they loose interest or fun in coding for ROS then we are not just