Re: [ros-dev] [ros-diffs] [jgardou] 53481: [WIDL] - reenable -Oif flag, it's too good to be disabled With this commit, advapi32:service winetest suffers only 2 failures.

2011-08-28 Thread Jérôme Gardou
Feel free to disable it again if probems occur. "Probable bugs" are hard to test alone, so I'm waiting for test bot to confirm this fixes things without breaking others. Regards. Jérôme. Le 28/08/2011 17:37, jgar...@svn.reactos.org a écrit : Author: jgardou Date: Sun Aug 28 15:37:01 2011 New

Re: [ros-dev] [ros-diffs] [jgardou] 53481: [WIDL] - reenable -Oif flag, it's too good to be disabled With this commit, advapi32:service winetest suffers only 2 failures.

2011-08-28 Thread Eric Kohl
Hello Jérôme, your patch looks very good! I hope Alexandre accepts it without a length discussion. ;-) I just ran another set of "advapi32_winetest service" tests on my machine. Both tests, with and without -Oif option return the same results: 2 failures! Great! And as far as I can see our

Re: [ros-dev] [ros-diffs] [jgardou] 53481: [WIDL] - reenable -Oif flag, it's too good to be disabled With this commit, advapi32:service winetest suffers only 2 failures.

2011-08-28 Thread caemyr
Yes! Lets hide the bugs, so we can assume ReactOS is fixed! Please excuse my sarcasm. I couldn't really stop myself. In my opinion, useless results do happen when you reboot VM that many times until it returns no failures. Such results are then, useless. If there is an error, it should be fixed