You need to cast to volatile.
(Same for Increment).
There's also no need to return the old value.
--
Best regards,
Alex Ionescu
On 2011-06-02, at 1:43 PM, pschweit...@svn.reactos.org wrote:
> +OldValue = (*Ulong)--;
___
Ros-dev mailing list
Ros
You misunderstand the meaning of the parameter. The last entry is the RAW file
system. This parameter influences if RAWFS should be notified or not.
--
Best regards,
Alex Ionescu
On 2011-06-02, at 1:43 PM, pschweit...@svn.reactos.org wrote:
> +/* Check if we reached end and if we have t
The notification routine can change the list, as there is no lock involved.
Therefore, you should grab the next entry before notifying the driver, to
maintain a consistent list state.
--
Best regards,
Alex Ionescu
On 2011-06-02, at 1:43 PM, pschweit...@svn.reactos.org wrote:
> +DriverN
As per elementary Windows Driver Development basics, resources should ALWAYS be
acquired within a critical or guarded region.
--
Best regards,
Alex Ionescu
On 2011-06-02, at 1:43 PM, pschweit...@svn.reactos.org wrote:
> +/* Acquire the FS lock */
> +ExAcquireResourceExclusiveLite(&IopDa
You are rebrowsing the *whole* list, yet the caller gave you an argument
(DriverObjectListSize) that indicated to you how large his array is.
You should browse the minimum of the whole list while making sure that "Index"
does not grow larger than DriverObjectListSize / sizeof(pointer).
Right no
Same comment as before, resources MUST be acquired within a critical region (as
the old code did).
--
Best regards,
Alex Ionescu
On 2011-06-02, at 1:43 PM, pschweit...@svn.reactos.org wrote:
> /* Acquire the FS lock */
> -KeEnterCriticalRegion();
> -ExAcquireResourceExclusiveLite(&F
i love the way you talk with yourself :P
On Thu, Jun 2, 2011 at 8:02 PM, Alex Ionescu wrote:
> Same comment as before, resources MUST be acquired within a critical region
> (as the old code did).
>
> --
> Best regards,
> Alex Ionescu
>
> On 2011-06-02, at 1:43 PM, pschweit...@svn.reactos.org wro
He is reviewing the bloody code, Javier.
2011/6/2 Javier Agustìn Fernàndez Arroyo
> i love the way you talk with yourself :P
>
>
> On Thu, Jun 2, 2011 at 8:02 PM, Alex Ionescu wrote:
>
>> Same comment as before, resources MUST be acquired within a critical
>> region (as the old code did).
>>
>>
Do you even understand what hes talking to himself about?
Perhaps you should refrain from commenting until you do.
From: ros-dev-boun...@reactos.org [mailto:ros-dev-boun...@reactos.org] On
Behalf Of Javier Agustìn Fernàndez Arroyo
Sent: 02 June 2011 20:18
To: ReactOS Development List
Cc:
