Re: [ros-dev] [ros-diffs] [tfaber] 57485: [SHELL32] - Fix what might finally be the last missing "this->" instances left over from the C++ conversion (used a regex this time)

2012-10-05 Thread Dmitry Gorbachev
> Isn't there somewhere some compiler warning for such ambiguation? Clang has an option "-Wself-assign" which should warn about it. ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev

Re: [ros-dev] [ros-diffs] [tfaber] 57485: [SHELL32] - Fix what might finally be the last missing "this->" instances left over from the C++ conversion (used a regex this time)

2012-10-05 Thread Jérôme Gardou
Isn't there somewhere some compiler warning for such ambiguation? Le Fri, 05 Oct 2012 10:41:47 +0200, Thomas Faber a écrit : > Yeah, that would certainly be a more sensible convention. > I wasn't planning on refactoring all of shell32 any time soon > though. :| > > We accept patches™ ;) > > >

Re: [ros-dev] [ros-diffs] [tfaber] 57485: [SHELL32] - Fix what might finally be the last missing "this->" instances left over from the C++ conversion (used a regex this time)

2012-10-05 Thread Thomas Faber
Yeah, that would certainly be a more sensible convention. I wasn't planning on refactoring all of shell32 any time soon though. :| We accept patches™ ;) On 2012-10-05 10:30, Timo Kreuzer wrote: > Shouldn't member variables rather be prefixed with m_? > > > Am 05.10.2012 01:46, schrieb tfa...@s

Re: [ros-dev] [ros-diffs] [tfaber] 57485: [SHELL32] - Fix what might finally be the last missing "this->" instances left over from the C++ conversion (used a regex this time)

2012-10-05 Thread Timo Kreuzer
Shouldn't member variables rather be prefixed with m_? Am 05.10.2012 01:46, schrieb tfa...@svn.reactos.org: Author: tfaber Date: Thu Oct 4 23:46:59 2012 New Revision: 57485 URL: http://svn.reactos.org/svn/reactos?rev=57485&view=rev Log: [SHELL32] - Fix what might finally be the last missing