Re: [ros-dev] ReactOS/Wine patches. BOOLs and the art of motorcycle repair.

2014-11-20 Thread Love Nystrom
FLAG" Best Regards // Love ------------ *De :* Love Nystrom *À :* ReactOS Development List *Envoyé le :* Vendredi 14 novembre 2014 12h56 *Objet :* [ros-dev] ReactOS/Wine patches. @Sylvain, It occurred to me that since we have a lot

Re: [ros-dev] ReactOS/Wine patches.

2014-11-15 Thread Timo Kreuzer
Well said. Getting patches into wine is kinda ... a PITA. If we have code that is *definately* broken. And potentially easy to get into wine, then it makes sense to invest the time to get it into there. For some coding style things that are most likely not bugs (until proven otherwise), I don'

Re: [ros-dev] ReactOS/Wine patches.

2014-11-14 Thread Mario J. Rugiero
In defense of the topic starter, review is something that always requires someone experienced in the area. Otherwise, it's kind of worthless. Even if it's made by someone talented, we need someone who is recognized as such by Wine devs. Regards, Mario.

Re: [ros-dev] ReactOS/Wine patches.

2014-11-14 Thread Aleksey Bragin
I'm not Sylvain either, and since David revived this thread, the reply which I wanted to send to the topic starter was: "Do you volunteer? :-)" Regards, Aleksey On 14.11.2014 19:39, David Quintana (gigaherz) wrote: (I wrote this 3 hours ago but forgot to send) Hello, I'm not Sylvain, but I w

Re: [ros-dev] ReactOS/Wine patches.

2014-11-14 Thread David Quintana (gigaherz)
(I wrote this 3 hours ago but forgot to send) Hello, I'm not Sylvain, but I want to make a note regardless. Keep in mind that almost all the developers are contributors that work in their spare time. What you suggest is that those developers who donate their time for the project should also take

Re: [ros-dev] ReactOS/Wine patches.

2014-11-14 Thread Sylvain Petreolle
| Afficher sur jira.reactos.org | Aperçu par Yahoo | | | |   |  Kind regards,Sylvain Petreolle De : Love Nystrom À : ReactOS Development List Envoyé le : Vendredi 14 novembre 2014 12h56 Objet : [ros-dev] ReactOS/Wine patches. @Sylvain, It occurred to me that since we have a lot of Wine code in

[ros-dev] ReactOS/Wine patches.

2014-11-14 Thread Love Nystrom
@Sylvain, It occurred to me that since we have a lot of Wine code in ReactOS, there will often be cases where ReactOS patches target Wine code. Instead of just rejecting those patches, which is likely to make them never see the light of day, the ReactOS programmers who maintain our Wine code cou