[ros-diffs] [hbelusca] 65059: [FAST486]: We should invalidate the prefetch buffer *after* having fetched the BOP byte (but before calling its handler), not before fetching the byte :)

2014-10-28 Thread hbelusca
Author: hbelusca Date: Tue Oct 28 00:19:48 2014 New Revision: 65059 URL: http://svn.reactos.org/svn/reactos?rev=65059&view=rev Log: [FAST486]: We should invalidate the prefetch buffer *after* having fetched the BOP byte (but before calling its handler), not before fetching the byte :) Modified:

[ros-diffs] [jimtabor] 65060: [NtUser] - Revert 64363. See CORE-7797.

2014-10-28 Thread jimtabor
Author: jimtabor Date: Tue Oct 28 00:26:22 2014 New Revision: 65060 URL: http://svn.reactos.org/svn/reactos?rev=65060&view=rev Log: [NtUser] - Revert 64363. See CORE-7797. Modified: trunk/reactos/win32ss/user/ntuser/message.c Modified: trunk/reactos/win32ss/user/ntuser/message.c URL: http:/

[ros-diffs] [aandrejevic] 65061: [FAST486][NTVDM] Get rid of Fast486Interrupt, since it's not used anywhere. Also we can now remove workarounds for all of the bugs that it caused. Implement the "singl

2014-10-28 Thread aandrejevic
Author: aandrejevic Date: Tue Oct 28 00:33:03 2014 New Revision: 65061 URL: http://svn.reactos.org/svn/reactos?rev=65061&view=rev Log: [FAST486][NTVDM] Get rid of Fast486Interrupt, since it's not used anywhere. Also we can now remove workarounds for all of the bugs that it caused. Implement the "

[ros-diffs] [aandrejevic] 65062: [FAST486] Fix a typo in r65061.

2014-10-28 Thread aandrejevic
Author: aandrejevic Date: Tue Oct 28 00:53:02 2014 New Revision: 65062 URL: http://svn.reactos.org/svn/reactos?rev=65062&view=rev Log: [FAST486] Fix a typo in r65061. Modified: trunk/reactos/lib/fast486/opcodes.c Modified: trunk/reactos/lib/fast486/opcodes.c URL: http://svn.reactos.org/svn

[ros-diffs] [tkreuzer] 65063: [GDI32] - Use GdiGetDcAttr instead of GdiGetHandleUserData where appropriate - Add a few missing SetLastError() - Fix return failure return value of GetBkColor() - Improv

2014-10-28 Thread tkreuzer
Author: tkreuzer Date: Tue Oct 28 00:55:22 2014 New Revision: 65063 URL: http://svn.reactos.org/svn/reactos?rev=65063&view=rev Log: [GDI32] - Use GdiGetDcAttr instead of GdiGetHandleUserData where appropriate - Add a few missing SetLastError() - Fix return failure return value of GetBkColor() - Im

[ros-diffs] [gadamopoulos] 65064: [SHELL32] - Properly check for error in CDefaultContextMenu::DoCreateLink

2014-10-28 Thread gadamopoulos
Author: gadamopoulos Date: Tue Oct 28 00:58:19 2014 New Revision: 65064 URL: http://svn.reactos.org/svn/reactos?rev=65064&view=rev Log: [SHELL32] - Properly check for error in CDefaultContextMenu::DoCreateLink Modified: branches/shell-experiments/dll/win32/shell32/defcontextmenu.cpp Modified

[ros-diffs] [dquintana] 65065: [RSHELL] * Fix some small things that were getting in the way of fixing the start menu (which was broken and no one noticed). The actual fix will come tomorrow since my

2014-10-28 Thread dquintana
Author: dquintana Date: Tue Oct 28 01:27:02 2014 New Revision: 65065 URL: http://svn.reactos.org/svn/reactos?rev=65065&view=rev Log: [RSHELL] * Fix some small things that were getting in the way of fixing the start menu (which was broken and no one noticed). The actual fix will come tomorrow sinc

[ros-diffs] [cwittich] 65066: [DRIVERS] don't use uninitialized variables

2014-10-28 Thread cwittich
Author: cwittich Date: Tue Oct 28 08:15:49 2014 New Revision: 65066 URL: http://svn.reactos.org/svn/reactos?rev=65066&view=rev Log: [DRIVERS] don't use uninitialized variables Modified: trunk/reactos/drivers/bus/acpi/main.c trunk/reactos/drivers/bus/pcix/fdo.c Modified: trunk/reactos/dri

[ros-diffs] [tkreuzer] 65067: [GDI32] Implement separate functions for all SelectObject cases.

2014-10-28 Thread tkreuzer
Author: tkreuzer Date: Tue Oct 28 09:06:33 2014 New Revision: 65067 URL: http://svn.reactos.org/svn/reactos?rev=65067&view=rev Log: [GDI32] Implement separate functions for all SelectObject cases. Modified: trunk/reactos/win32ss/gdi/gdi32/objects/dc.c Modified: trunk/reactos/win32ss/gdi/gdi3

[ros-diffs] [pschweitzer] 65068: [NTFS] ReleaseAttributeContext() is to be used out of mft.c I believe that at some point, we're leaking memory...

2014-10-28 Thread pschweitzer
Author: pschweitzer Date: Tue Oct 28 10:26:47 2014 New Revision: 65068 URL: http://svn.reactos.org/svn/reactos?rev=65068&view=rev Log: [NTFS] ReleaseAttributeContext() is to be used out of mft.c I believe that at some point, we're leaking memory... Modified: trunk/reactos/drivers/filesystems/

[ros-diffs] [gadamopoulos] 65069: [WIN32K] - Send the HSHELL_TASKMAN notification to the shell when the windows key is pressed - Needed to open and close the start menu with the keyboard

2014-10-28 Thread gadamopoulos
Author: gadamopoulos Date: Tue Oct 28 13:45:43 2014 New Revision: 65069 URL: http://svn.reactos.org/svn/reactos?rev=65069&view=rev Log: [WIN32K] - Send the HSHELL_TASKMAN notification to the shell when the windows key is pressed - Needed to open and close the start menu with the keyboard Modifie

[ros-diffs] [gadamopoulos] 65070: [EXPLORER_NEW] - Use IMenuPopup_OnSelect to close the start menu when the win key is pressed. - Fixes closing the start menu (on windows and on reactos)

2014-10-28 Thread gadamopoulos
Author: gadamopoulos Date: Tue Oct 28 14:18:16 2014 New Revision: 65070 URL: http://svn.reactos.org/svn/reactos?rev=65070&view=rev Log: [EXPLORER_NEW] - Use IMenuPopup_OnSelect to close the start menu when the win key is pressed. - Fixes closing the start menu (on windows and on reactos) Modifie

[ros-diffs] [gadamopoulos] 65071: [RSHELL] - Actually give focus to the start menu when CMenuDeskBar::Popup is called - Fixes opening and navigating the start menu with the keyboard

2014-10-28 Thread gadamopoulos
Author: gadamopoulos Date: Tue Oct 28 14:31:19 2014 New Revision: 65071 URL: http://svn.reactos.org/svn/reactos?rev=65071&view=rev Log: [RSHELL] - Actually give focus to the start menu when CMenuDeskBar::Popup is called - Fixes opening and navigating the start menu with the keyboard Modified:

[ros-diffs] [gadamopoulos] 65072: [SHELL32] - Return a readable folder name when SHGDN_FORADDRESSBAR was specified - We no longer show GUIDs in the address bar

2014-10-28 Thread gadamopoulos
Author: gadamopoulos Date: Tue Oct 28 15:07:31 2014 New Revision: 65072 URL: http://svn.reactos.org/svn/reactos?rev=65072&view=rev Log: [SHELL32] - Return a readable folder name when SHGDN_FORADDRESSBAR was specified - We no longer show GUIDs in the address bar Modified: branches/shell-exper

[ros-diffs] [gadamopoulos] 65073: [STOBJECT] - Disable querying if audio is muted or not for now. - Hides an assert that happened in wdmaud.drv

2014-10-28 Thread gadamopoulos
Author: gadamopoulos Date: Tue Oct 28 15:27:00 2014 New Revision: 65073 URL: http://svn.reactos.org/svn/reactos?rev=65073&view=rev Log: [STOBJECT] - Disable querying if audio is muted or not for now. - Hides an assert that happened in wdmaud.drv Modified: branches/shell-experiments/dll/shelle

[ros-diffs] [dquintana] 65074: [RSHELL] * Fix executing items after the menu has closed.

2014-10-28 Thread dquintana
Author: dquintana Date: Tue Oct 28 15:39:47 2014 New Revision: 65074 URL: http://svn.reactos.org/svn/reactos?rev=65074&view=rev Log: [RSHELL] * Fix executing items after the menu has closed. Modified: branches/shell-experiments/base/shell/rshell/CMenuBand.cpp branches/shell-experiments/ba

[ros-diffs] [akhaldi] 65075: * Sync up to trunk head (r65074).

2014-10-28 Thread akhaldi
Author: akhaldi Date: Tue Oct 28 16:58:25 2014 New Revision: 65075 URL: http://svn.reactos.org/svn/reactos?rev=65075&view=rev Log: * Sync up to trunk head (r65074). Added: branches/shell-experiments/win32ss/gdi/gdi32/objects/clientobj.c - copied unchanged from r65074, trunk/reactos/win

[ros-diffs] [gedmurphy] 65076: [WINLOGON] - Stop the log from being spammed when the session is idle and no screensaver is set - Also checking if my login still works :)

2014-10-28 Thread gedmurphy
Author: gedmurphy Date: Tue Oct 28 17:07:47 2014 New Revision: 65076 URL: http://svn.reactos.org/svn/reactos?rev=65076&view=rev Log: [WINLOGON] - Stop the log from being spammed when the session is idle and no screensaver is set - Also checking if my login still works :) Modified: trunk/reac

[ros-diffs] [gadamopoulos] 65077: Merge r65001 from shell-experiments branch: [user32] - Properly notify the theme engine that the caption needs to be repainted on WM_SETICON - Fixes a classic frame a

2014-10-28 Thread gadamopoulos
Author: gadamopoulos Date: Tue Oct 28 17:32:01 2014 New Revision: 65077 URL: http://svn.reactos.org/svn/reactos?rev=65077&view=rev Log: Merge r65001 from shell-experiments branch: [user32] - Properly notify the theme engine that the caption needs to be repainted on WM_SETICON - Fixes a classic fr

[ros-diffs] [dquintana] 65078: Fix GCC build.

2014-10-28 Thread dquintana
Author: dquintana Date: Tue Oct 28 17:33:22 2014 New Revision: 65078 URL: http://svn.reactos.org/svn/reactos?rev=65078&view=rev Log: Fix GCC build. Modified: branches/shell-experiments/dll/win32/browseui/shellbrowser.cpp Modified: branches/shell-experiments/dll/win32/browseui/shellbrowser.cp

[ros-diffs] [gadamopoulos] 65079: Addendum to r65077 (svn merge info).

2014-10-28 Thread gadamopoulos
Author: gadamopoulos Date: Tue Oct 28 17:40:49 2014 New Revision: 65079 URL: http://svn.reactos.org/svn/reactos?rev=65079&view=rev Log: Addendum to r65077 (svn merge info). Modified: trunk/reactos/ (props changed) Propchange: trunk/reactos/ -

[ros-diffs] [dquintana] 65080: [BROWSEUI] * Properly return the toolbar status on QueryStatus. * Properly make use of the returned into from QueryStatus.

2014-10-28 Thread dquintana
Author: dquintana Date: Tue Oct 28 18:32:21 2014 New Revision: 65080 URL: http://svn.reactos.org/svn/reactos?rev=65080&view=rev Log: [BROWSEUI] * Properly return the toolbar status on QueryStatus. * Properly make use of the returned into from QueryStatus. Modified: branches/shell-experiments/

[ros-diffs] [dquintana] 65081: [BROWSEUI] * Disable the Tools menu items until they are implemented.

2014-10-28 Thread dquintana
Author: dquintana Date: Tue Oct 28 18:37:44 2014 New Revision: 65081 URL: http://svn.reactos.org/svn/reactos?rev=65081&view=rev Log: [BROWSEUI] * Disable the Tools menu items until they are implemented. Modified: branches/shell-experiments/dll/win32/browseui/shellbrowser.cpp Modified: branch

[ros-diffs] [pschweitzer] 65082: [NTFS] Finally, implement NtfsGetFreeClusters() which will just read the $Data stream from $BITMAP file record to get the amount of free clusters to allow estimating t

2014-10-28 Thread pschweitzer
Author: pschweitzer Date: Tue Oct 28 19:17:59 2014 New Revision: 65082 URL: http://svn.reactos.org/svn/reactos?rev=65082&view=rev Log: [NTFS] Finally, implement NtfsGetFreeClusters() which will just read the $Data stream from $BITMAP file record to get the amount of free clusters to allow estimat

[ros-diffs] [gadamopoulos] 65083: [RSHELL] - Do not release CMenuDeskBar more times than necessary - Should fix the start menu

2014-10-28 Thread gadamopoulos
Author: gadamopoulos Date: Tue Oct 28 19:50:49 2014 New Revision: 65083 URL: http://svn.reactos.org/svn/reactos?rev=65083&view=rev Log: [RSHELL] - Do not release CMenuDeskBar more times than necessary - Should fix the start menu Modified: branches/shell-experiments/base/shell/rshell/CMenuDesk

[ros-diffs] [gadamopoulos] 65084: Revert unwanted change

2014-10-28 Thread gadamopoulos
Author: gadamopoulos Date: Tue Oct 28 19:52:04 2014 New Revision: 65084 URL: http://svn.reactos.org/svn/reactos?rev=65084&view=rev Log: Revert unwanted change Modified: branches/shell-experiments/base/shell/rshell/CMenuDeskBar.cpp Modified: branches/shell-experiments/base/shell/rshell/CMenuD

[ros-diffs] [pschweitzer] 65085: [FASTFAT] For now, disable the VfatSetRenameInformation() asserts in trunk. They can be reenabled for testing by commenting "#define NASSERTS_RENAME" out. CORE-8721 #r

2014-10-28 Thread pschweitzer
Author: pschweitzer Date: Tue Oct 28 20:39:42 2014 New Revision: 65085 URL: http://svn.reactos.org/svn/reactos?rev=65085&view=rev Log: [FASTFAT] For now, disable the VfatSetRenameInformation() asserts in trunk. They can be reenabled for testing by commenting "#define NASSERTS_RENAME" out. CORE-87

[ros-diffs] [tkreuzer] 65086: [GDI32] - Move functions to the appropriate source files, zap hacks.c, stubs.c, stubsa.c and stubsw.c (sorry for the noise, but this mess had to be cleaned up)

2014-10-28 Thread tkreuzer
Author: tkreuzer Date: Tue Oct 28 21:09:01 2014 New Revision: 65086 URL: http://svn.reactos.org/svn/reactos?rev=65086&view=rev Log: [GDI32] - Move functions to the appropriate source files, zap hacks.c, stubs.c, stubsa.c and stubsw.c (sorry for the noise, but this mess had to be cleaned up) Adde

[ros-diffs] [khornicek] 65087: [WIN32K] - addendum to revision 64877 which slightly changed UserDrawCaption's logic - fixes window title being drawn over the icon

2014-10-28 Thread khornicek
Author: khornicek Date: Tue Oct 28 21:38:26 2014 New Revision: 65087 URL: http://svn.reactos.org/svn/reactos?rev=65087&view=rev Log: [WIN32K] - addendum to revision 64877 which slightly changed UserDrawCaption's logic - fixes window title being drawn over the icon Modified: trunk/reactos/win3

[ros-diffs] [dquintana] 65088: [RSHELL] * CMenuBand: Refcount before assigning a return pointer. * CMenuDeskBar: Revert change and protect the refcounting in case I was wrong to assume there will be e

2014-10-28 Thread dquintana
Author: dquintana Date: Tue Oct 28 21:40:50 2014 New Revision: 65088 URL: http://svn.reactos.org/svn/reactos?rev=65088&view=rev Log: [RSHELL] * CMenuBand: Refcount before assigning a return pointer. * CMenuDeskBar: Revert change and protect the refcounting in case I was wrong to assume there will

[ros-diffs] [ekohl] 65089: [NET] Display more password information in the NET USER command.

2014-10-28 Thread ekohl
Author: ekohl Date: Tue Oct 28 21:57:41 2014 New Revision: 65089 URL: http://svn.reactos.org/svn/reactos?rev=65089&view=rev Log: [NET] Display more password information in the NET USER command. Modified: trunk/reactos/base/applications/network/net/cmdUser.c Modified: trunk/reactos/base/appli

[ros-diffs] [pschweitzer] 65090: [DISK] Get ready to enter into the 10th dimension... So: - Implement support for IRP_MJ_FILE_SYSTEM_CONTROL. Yes... You read well! So, implemented a ScsiDiskFileSystem

2014-10-28 Thread pschweitzer
Author: pschweitzer Date: Tue Oct 28 21:59:57 2014 New Revision: 65090 URL: http://svn.reactos.org/svn/reactos?rev=65090&view=rev Log: [DISK] Get ready to enter into the 10th dimension... So: - Implement support for IRP_MJ_FILE_SYSTEM_CONTROL. Yes... You read well! So, implemented a ScsiDiskFileS

[ros-diffs] [zguo] 65091: [WIN32SS] Fix icon selection regression caused by cascading fix. In this case, this should probably go into trunk. CORE-8574

2014-10-28 Thread zguo
Author: zguo Date: Tue Oct 28 22:01:57 2014 New Revision: 65091 URL: http://svn.reactos.org/svn/reactos?rev=65091&view=rev Log: [WIN32SS] Fix icon selection regression caused by cascading fix. In this case, this should probably go into trunk. CORE-8574 Modified: branches/0.3.17/reactos/win3

[ros-diffs] [dquintana] 65092: [RSHELL] * Remove a few GCC unused-but-set-variable warnings.

2014-10-28 Thread dquintana
Author: dquintana Date: Tue Oct 28 22:13:18 2014 New Revision: 65092 URL: http://svn.reactos.org/svn/reactos?rev=65092&view=rev Log: [RSHELL] * Remove a few GCC unused-but-set-variable warnings. Modified: branches/shell-experiments/base/shell/rshell/CDesktopBrowser.cpp branches/shell-expe

[ros-diffs] [tkreuzer] 65093: [GDI32] Improve functions in coord.c: - Use GdiGetDcAttr() where appropriate - Fix SetLastError() usage - Add annotations - improve variable naming - Add some comments

2014-10-28 Thread tkreuzer
Author: tkreuzer Date: Tue Oct 28 22:16:24 2014 New Revision: 65093 URL: http://svn.reactos.org/svn/reactos?rev=65093&view=rev Log: [GDI32] Improve functions in coord.c: - Use GdiGetDcAttr() where appropriate - Fix SetLastError() usage - Add annotations - improve variable naming - Add some comment

[ros-diffs] [dquintana] 65094: [BROWSEUI] * Implement executing the items from the Favorites menu.

2014-10-28 Thread dquintana
Author: dquintana Date: Tue Oct 28 22:28:28 2014 New Revision: 65094 URL: http://svn.reactos.org/svn/reactos?rev=65094&view=rev Log: [BROWSEUI] * Implement executing the items from the Favorites menu. Modified: branches/shell-experiments/dll/win32/browseui/internettoolbar.cpp Modified: branc