[ros-diffs] [hbelusca] 74717: [USETUP]: Diverse fixes: - Convert almost all swprintf into StringCchPrintfW, and wcscpy into StringCchCopyW; - Explicitly add a trailing path separator to the "\Device\H

2017-05-30 Thread hbelusca
Author: hbelusca Date: Wed May 31 02:19:08 2017 New Revision: 74717 URL: http://svn.reactos.org/svn/reactos?rev=74717&view=rev Log: [USETUP]: Diverse fixes: - Convert almost all swprintf into StringCchPrintfW, and wcscpy into StringCchCopyW; - Explicitly add a trailing path separator to the "\De

[ros-diffs] [hbelusca] 74716: [USETUP]: Try to use correct flags for the NtCreateFile call that creates new file directories. DIRECTORY_ALL_ACCESS is not the correct flag, because it is used with the

2017-05-30 Thread hbelusca
Author: hbelusca Date: Wed May 31 02:08:16 2017 New Revision: 74716 URL: http://svn.reactos.org/svn/reactos?rev=74716&view=rev Log: [USETUP]: Try to use correct flags for the NtCreateFile call that creates new file directories. DIRECTORY_ALL_ACCESS is not the correct flag, because it is used with

[ros-diffs] [hbelusca] 74715: [USETUP]: Try to condense the different InstallFatXYBootSectorToDisk & ToFile functions into a InstallFatXYBootSector() function that is called by both the ToDisk and ToF

2017-05-30 Thread hbelusca
Author: hbelusca Date: Wed May 31 02:03:10 2017 New Revision: 74715 URL: http://svn.reactos.org/svn/reactos?rev=74715&view=rev Log: [USETUP]: Try to condense the different InstallFatXYBootSectorToDisk & ToFile functions into a InstallFatXYBootSector() function that is called by both the ToDisk a

[ros-diffs] [hbelusca] 74714: [USETUP]: Move some functions around, but no functional code changes otherwise.

2017-05-30 Thread hbelusca
Author: hbelusca Date: Wed May 31 01:47:39 2017 New Revision: 74714 URL: http://svn.reactos.org/svn/reactos?rev=74714&view=rev Log: [USETUP]: Move some functions around, but no functional code changes otherwise. Modified: branches/setup_improvements/base/setup/usetup/bootsup.c Modified: bran

[ros-diffs] [hbelusca] 74713: [USETUP]: Several additions: - Add support for other bootloaders; - Update a couple of comments; - Remove deprecated __REACTOS__ stuff.

2017-05-30 Thread hbelusca
Author: hbelusca Date: Wed May 31 01:43:12 2017 New Revision: 74713 URL: http://svn.reactos.org/svn/reactos?rev=74713&view=rev Log: [USETUP]: Several additions: - Add support for other bootloaders; - Update a couple of comments; - Remove deprecated __REACTOS__ stuff. Modified: branches/setup_

[ros-diffs] [hbelusca] 74712: [SETUPLIB]: Adjustments: - Call OpenAndMapFile() with its new ReadWrite parameter; - Add informative comments in osdetect.c; - In partlist.c, check whether a disk has a v

2017-05-30 Thread hbelusca
Author: hbelusca Date: Wed May 31 01:11:05 2017 New Revision: 74712 URL: http://svn.reactos.org/svn/reactos?rev=74712&view=rev Log: [SETUPLIB]: Adjustments: - Call OpenAndMapFile() with its new ReadWrite parameter; - Add informative comments in osdetect.c; - In partlist.c, check whether a disk has

[ros-diffs] [hbelusca] 74711: [SETUPLIB]: Additions to inicache.c: Split IniCacheLoad() and IniCacheSave() into: themselves & IniCacheLoadByHandle() and IniCacheSaveByHandle(), respectively, so that w

2017-05-30 Thread hbelusca
Author: hbelusca Date: Wed May 31 00:23:53 2017 New Revision: 74711 URL: http://svn.reactos.org/svn/reactos?rev=74711&view=rev Log: [SETUPLIB]: Additions to inicache.c: Split IniCacheLoad() and IniCacheSave() into: themselves & IniCacheLoadByHandle() and IniCacheSaveByHandle(), respectively, so

[ros-diffs] [hbelusca] 74710: [SETUPLIB]: Additions for filesup.c: - In DoesFileExist(): Call NtOpenFile with FILE_GENERIC_READ instead of the more generic GENERIC_READ access right. - OpenAndMapFile(

2017-05-30 Thread hbelusca
Author: hbelusca Date: Wed May 31 00:18:13 2017 New Revision: 74710 URL: http://svn.reactos.org/svn/reactos?rev=74710&view=rev Log: [SETUPLIB]: Additions for filesup.c: - In DoesFileExist(): Call NtOpenFile with FILE_GENERIC_READ instead of the more generic GENERIC_READ access right. - OpenAndMap

[ros-diffs] [hbelusca] 74709: [NTOS]: Underline the fact that CmpGetRegistryPath (especially when being run in 1st-stage text mode) is just a big hack (introduced in r3794 and r3795). I however need t

2017-05-30 Thread hbelusca
Author: hbelusca Date: Wed May 31 00:03:33 2017 New Revision: 74709 URL: http://svn.reactos.org/svn/reactos?rev=74709&view=rev Log: [NTOS]: Underline the fact that CmpGetRegistryPath (especially when being run in 1st-stage text mode) is just a big hack (introduced in r3794 and r3795). I however

[ros-diffs] [hbelusca] 74708: [NTOS]: Minor fixes: - Correctly specify the buffer size for RtlInitEmptyUnicodeString calls; - Prefer using RtlAppendUnicodeStringToString instead of RtlAppendStringToSt

2017-05-30 Thread hbelusca
Author: hbelusca Date: Wed May 31 00:01:31 2017 New Revision: 74708 URL: http://svn.reactos.org/svn/reactos?rev=74708&view=rev Log: [NTOS]: Minor fixes: - Correctly specify the buffer size for RtlInitEmptyUnicodeString calls; - Prefer using RtlAppendUnicodeStringToString instead of RtlAppendStrin

[ros-diffs] [pschweitzer] 74707: [NTDLL_VISTA] Fix GCC build after r74706. Patch by Thomas

2017-05-30 Thread pschweitzer
Author: pschweitzer Date: Tue May 30 22:01:13 2017 New Revision: 74707 URL: http://svn.reactos.org/svn/reactos?rev=74707&view=rev Log: [NTDLL_VISTA] Fix GCC build after r74706. Patch by Thomas Modified: trunk/reactos/dll/win32/ntdll_vista/CMakeLists.txt Modified: trunk/reactos/dll/win32/ntdl

[ros-diffs] [pschweitzer] 74705: [KERNEL32_VISTA] Add Kernel32 implementation for SRW locks and condition variables. This is based on Wine implementation. CORE-7546 CORE-8204

2017-05-30 Thread pschweitzer
Author: pschweitzer Date: Tue May 30 21:39:50 2017 New Revision: 74705 URL: http://svn.reactos.org/svn/reactos?rev=74705&view=rev Log: [KERNEL32_VISTA] Add Kernel32 implementation for SRW locks and condition variables. This is based on Wine implementation. CORE-7546 CORE-8204 Added: trunk/re

[ros-diffs] [pschweitzer] 74704: [RTL] Delete leftover CORE-7546 CORE-8204

2017-05-30 Thread pschweitzer
Author: pschweitzer Date: Tue May 30 21:36:43 2017 New Revision: 74704 URL: http://svn.reactos.org/svn/reactos?rev=74704&view=rev Log: [RTL] Delete leftover CORE-7546 CORE-8204 Removed: trunk/reactos/sdk/lib/rtl/condvar.c Removed: trunk/reactos/sdk/lib/rtl/condvar.c URL: http://svn.reactos

[ros-diffs] [pschweitzer] 74703: [NTDLL_VISTA] Create a new NTDLL library that exports some of the NTDLL Vista+ functions. This new NTDLL includes at the time of commit: - SRW locks implementation tha

2017-05-30 Thread pschweitzer
Author: pschweitzer Date: Tue May 30 21:35:05 2017 New Revision: 74703 URL: http://svn.reactos.org/svn/reactos?rev=74703&view=rev Log: [NTDLL_VISTA] Create a new NTDLL library that exports some of the NTDLL Vista+ functions. This new NTDLL includes at the time of commit: - SRW locks implementation

[ros-diffs] [mjansen] 74702: [KERNEL32] Do not use TEB->StaticUnicodeString in CreateProcessInternalA. CORE-10368

2017-05-30 Thread mjansen
Author: mjansen Date: Tue May 30 20:57:45 2017 New Revision: 74702 URL: http://svn.reactos.org/svn/reactos?rev=74702&view=rev Log: [KERNEL32] Do not use TEB->StaticUnicodeString in CreateProcessInternalA. CORE-10368 Modified: trunk/reactos/dll/win32/kernel32/client/proc.c Modified: trunk/re

[ros-diffs] [mjansen] 74701: [KERNEL32_APITEST] Add test to show that we should not spoil TEB->StaticUnicodeString in CreateProcessA. CORE-10368

2017-05-30 Thread mjansen
Author: mjansen Date: Tue May 30 20:55:15 2017 New Revision: 74701 URL: http://svn.reactos.org/svn/reactos?rev=74701&view=rev Log: [KERNEL32_APITEST] Add test to show that we should not spoil TEB->StaticUnicodeString in CreateProcessA. CORE-10368 Added: trunk/rostests/apitests/kernel32/Creat

[ros-diffs] [tfaber] 74700: [NTOS:IO] - Fix key handle leak in PipCallDriverAddDevice - Avoid double-close in failure case of IopAttachFilterDrivers - Simplify closing handles, and use sensible variab

2017-05-30 Thread tfaber
Author: tfaber Date: Tue May 30 18:14:31 2017 New Revision: 74700 URL: http://svn.reactos.org/svn/reactos?rev=74700&view=rev Log: [NTOS:IO] - Fix key handle leak in PipCallDriverAddDevice - Avoid double-close in failure case of IopAttachFilterDrivers - Simplify closing handles, and use sensible va

[ros-diffs] [tfaber] 74699: [NTOS:IO] - Save an indentation level in IopAttachFilterDrivers CORE-13336

2017-05-30 Thread tfaber
Author: tfaber Date: Tue May 30 17:22:13 2017 New Revision: 74699 URL: http://svn.reactos.org/svn/reactos?rev=74699&view=rev Log: [NTOS:IO] - Save an indentation level in IopAttachFilterDrivers CORE-13336 Modified: trunk/reactos/ntoskrnl/io/iomgr/driver.c Modified: trunk/reactos/ntoskrnl/io/