[ros-diffs] [gadamopoulos] 75973: [WINLOGON][WIN32K][WINSRV] -Silence a lot of debug prints in the shutdown sequence. Add some debug prints in case of error. Also print the name of the processes that

2017-09-26 Thread gadamopoulos
Author: gadamopoulos Date: Tue Sep 26 09:11:51 2017 New Revision: 75973 URL: http://svn.reactos.org/svn/reactos?rev=75973=rev Log: [WINLOGON][WIN32K][WINSRV] -Silence a lot of debug prints in the shutdown sequence. Add some debug prints in case of error. Also print the name of the processes

[ros-diffs] [gadamopoulos] 75714: [BROWSEUI] -Demote a fixme print to a mere comment.

2017-08-30 Thread gadamopoulos
Author: gadamopoulos Date: Wed Aug 30 12:59:05 2017 New Revision: 75714 URL: http://svn.reactos.org/svn/reactos?rev=75714=rev Log: [BROWSEUI] -Demote a fixme print to a mere comment. Modified: trunk/reactos/dll/win32/browseui/shellbars/CBandSite.cpp Modified: trunk/reactos/dll/win32

[ros-diffs] [gadamopoulos] 75712: [SHELL32][BROWSEUI] -Demote some uselass error prints and promote some others that make sense to have. Avoid a case that would logically hit an error as initializatio

2017-08-30 Thread gadamopoulos
Author: gadamopoulos Date: Wed Aug 30 12:29:43 2017 New Revision: 75712 URL: http://svn.reactos.org/svn/reactos?rev=75712=rev Log: [SHELL32][BROWSEUI] -Demote some uselass error prints and promote some others that make sense to have. Avoid a case that would logically hit an error

[ros-diffs] [gadamopoulos] 75706: [EXPLORER] -Fix a comment typo. CORE-13566

2017-08-29 Thread gadamopoulos
Author: gadamopoulos Date: Tue Aug 29 09:11:57 2017 New Revision: 75706 URL: http://svn.reactos.org/svn/reactos?rev=75706=rev Log: [EXPLORER] -Fix a comment typo. CORE-13566 Modified: trunk/reactos/base/shell/explorer/traywnd.cpp Modified: trunk/reactos/base/shell/explorer/traywnd.cpp URL

[ros-diffs] [gadamopoulos] 75696: [UXTHEME] -When calculating the size of caption buttons assume that they have the same size. Hacks in the theme files that change the way the buttons are drawn actual

2017-08-28 Thread gadamopoulos
Author: gadamopoulos Date: Mon Aug 28 13:41:16 2017 New Revision: 75696 URL: http://svn.reactos.org/svn/reactos?rev=75696=rev Log: [UXTHEME] -When calculating the size of caption buttons assume that they have the same size. Hacks in the theme files that change the way the buttons are drawn

[ros-diffs] [gadamopoulos] 75688: [UXTHEME] -Ignore the alpha channel so that TrasnparentBlt will be used when a bitmap has an alpha channel but no pixel has alpha transparency. CORE-13464

2017-08-27 Thread gadamopoulos
Author: gadamopoulos Date: Sun Aug 27 10:55:30 2017 New Revision: 75688 URL: http://svn.reactos.org/svn/reactos?rev=75688=rev Log: [UXTHEME] -Ignore the alpha channel so that TrasnparentBlt will be used when a bitmap has an alpha channel but no pixel has alpha transparency. CORE-13464 Modified

[ros-diffs] [gadamopoulos] 75687: [BROWSEUI] -CExplorerBand: Calling ILGetDisplayNameEx with a full pidl was a bit hacky after all because it doesn't work always in win10. Just get the name manually a

2017-08-27 Thread gadamopoulos
Author: gadamopoulos Date: Sun Aug 27 09:35:03 2017 New Revision: 75687 URL: http://svn.reactos.org/svn/reactos?rev=75687=rev Log: [BROWSEUI] -CExplorerBand: Calling ILGetDisplayNameEx with a full pidl was a bit hacky after all because it doesn't work always in win10. Just get the name manually

[ros-diffs] [gadamopoulos] 75677: [BROWSEUI][SHELL32] -Move bitmap resources used by browseui from shell32 to browseui. Browseui alongside filebrowser.exe can already be used in windows so it makes se

2017-08-26 Thread gadamopoulos
Author: gadamopoulos Date: Sat Aug 26 14:38:32 2017 New Revision: 75677 URL: http://svn.reactos.org/svn/reactos?rev=75677=rev Log: [BROWSEUI][SHELL32] -Move bitmap resources used by browseui from shell32 to browseui. Browseui alongside filebrowser.exe can already be used in windows so it makes

[ros-diffs] [gadamopoulos] 75670: [BROWSEUI] -CAddressEditBox: Populate address bar combobox. Patch by Barrett Karish with improvements by me to fix leaks and add error checks. CORE-10988

2017-08-25 Thread gadamopoulos
Author: gadamopoulos Date: Fri Aug 25 15:03:25 2017 New Revision: 75670 URL: http://svn.reactos.org/svn/reactos?rev=75670=rev Log: [BROWSEUI] -CAddressEditBox: Populate address bar combobox. Patch by Barrett Karish with improvements by me to fix leaks and add error checks. CORE-10988 Modified

[ros-diffs] [gadamopoulos] 75666: [SHELL32] -Silence two unneeded prints.

2017-08-25 Thread gadamopoulos
Author: gadamopoulos Date: Fri Aug 25 08:59:10 2017 New Revision: 75666 URL: http://svn.reactos.org/svn/reactos?rev=75666=rev Log: [SHELL32] -Silence two unneeded prints. Modified: trunk/reactos/dll/win32/shell32/CIDLDataObj.cpp Modified: trunk/reactos/dll/win32/shell32/CIDLDataObj.cpp URL

[ros-diffs] [gadamopoulos] 75640: [SHELL32] -CRecycleBin: Factor out a new class called CRecyclerDropTarget, which will take the data object and call SHFileOperation for its contents. Add a noisy prin

2017-08-22 Thread gadamopoulos
Author: gadamopoulos Date: Tue Aug 22 13:50:25 2017 New Revision: 75640 URL: http://svn.reactos.org/svn/reactos?rev=75640=rev Log: [SHELL32] -CRecycleBin: Factor out a new class called CRecyclerDropTarget, which will take the data object and call SHFileOperation for its contents. Add a noisy

[ros-diffs] [gadamopoulos] 75637: [OLE32] -Recreate the clipboard window if it isn't a valid window handle. Can happen if the thread that first used the ole clipboard exists which also leads to the cl

2017-08-22 Thread gadamopoulos
Author: gadamopoulos Date: Tue Aug 22 08:02:30 2017 New Revision: 75637 URL: http://svn.reactos.org/svn/reactos?rev=75637=rev Log: [OLE32] -Recreate the clipboard window if it isn't a valid window handle. Can happen if the thread that first used the ole clipboard exists which also leads

[ros-diffs] [gadamopoulos] 75634: [SHELL32] Misc fixes for CFSFolder - GetCLSIDForFileType: Check if the shell extension is blocked by the Blocked key like wine does. - CFSFolder::BindToObject: Remove

2017-08-21 Thread gadamopoulos
Author: gadamopoulos Date: Mon Aug 21 12:18:46 2017 New Revision: 75634 URL: http://svn.reactos.org/svn/reactos?rev=75634=rev Log: [SHELL32] Misc fixes for CFSFolder - GetCLSIDForFileType: Check if the shell extension is blocked by the Blocked key like wine does. - CFSFolder::BindToObject

[ros-diffs] [gadamopoulos] 75633: [SHELL32] -CFSFolder: Fix a couple of handle leaks.

2017-08-21 Thread gadamopoulos
Author: gadamopoulos Date: Mon Aug 21 09:07:41 2017 New Revision: 75633 URL: http://svn.reactos.org/svn/reactos?rev=75633=rev Log: [SHELL32] -CFSFolder: Fix a couple of handle leaks. Modified: trunk/reactos/dll/win32/shell32/folders/CFSFolder.cpp Modified: trunk/reactos/dll/win32/shell32

[ros-diffs] [gadamopoulos] 75625: [SHELL32] -CFSDropTarger: Improve the debug message that shows the first thing that is copied or moved and where. This way we sort of know what parameters we pass to

2017-08-19 Thread gadamopoulos
Author: gadamopoulos Date: Sat Aug 19 15:48:47 2017 New Revision: 75625 URL: http://svn.reactos.org/svn/reactos?rev=75625=rev Log: [SHELL32] -CFSDropTarger: Improve the debug message that shows the first thing that is copied or moved and where. This way we sort of know what parameters we pass

[ros-diffs] [gadamopoulos] 75623: [SHELL32] -CFSDropTarget: Simplyfy the code path that handles the CFSTR_SHELLIDLIST format. Don't use FOF_MULTIDESTFILES to keep things simple. CORE-13176

2017-08-19 Thread gadamopoulos
Author: gadamopoulos Date: Sat Aug 19 11:19:06 2017 New Revision: 75623 URL: http://svn.reactos.org/svn/reactos?rev=75623=rev Log: [SHELL32] -CFSDropTarget: Simplyfy the code path that handles the CFSTR_SHELLIDLIST format. Don't use FOF_MULTIDESTFILES to keep things simple. CORE-13176 Modified

[ros-diffs] [gadamopoulos] 75622: [SHELL32] -Simplify the drop target of CRecycleBin to let the data object generate the list of names that can be passed to SHFileOperationW.

2017-08-19 Thread gadamopoulos
Author: gadamopoulos Date: Sat Aug 19 11:09:28 2017 New Revision: 75622 URL: http://svn.reactos.org/svn/reactos?rev=75622=rev Log: [SHELL32] -Simplify the drop target of CRecycleBin to let the data object generate the list of names that can be passed to SHFileOperationW. Modified: trunk

[ros-diffs] [gadamopoulos] 75619: [SHELL32] -CDefaultContextMenu: Correctly differentiate the copy and the cut commands.

2017-08-18 Thread gadamopoulos
Author: gadamopoulos Date: Fri Aug 18 17:39:34 2017 New Revision: 75619 URL: http://svn.reactos.org/svn/reactos?rev=75619=rev Log: [SHELL32] -CDefaultContextMenu: Correctly differentiate the copy and the cut commands. Modified: trunk/reactos/dll/win32/shell32/CDefaultContextMenu.cpp

[ros-diffs] [gadamopoulos] 75618: [SHELL32] -CDefViewBckgrndMenu: Fix pasting in the background of a folder.

2017-08-18 Thread gadamopoulos
Author: gadamopoulos Date: Fri Aug 18 17:32:20 2017 New Revision: 75618 URL: http://svn.reactos.org/svn/reactos?rev=75618=rev Log: [SHELL32] -CDefViewBckgrndMenu: Fix pasting in the background of a folder. Modified: trunk/reactos/dll/win32/shell32/CDefViewBckgrndMenu.cpp Modified: trunk

[ros-diffs] [gadamopoulos] 75616: [WIN32K] -NtUserEmptyClipboard: Change its behaviour to wait for WM_DESTROYCLIPBOARD to return so it behaves like windows and our ole32 doesn't trip on its assumption

2017-08-18 Thread gadamopoulos
Author: gadamopoulos Date: Fri Aug 18 17:18:17 2017 New Revision: 75616 URL: http://svn.reactos.org/svn/reactos?rev=75616=rev Log: [WIN32K] -NtUserEmptyClipboard: Change its behaviour to wait for WM_DESTROYCLIPBOARD to return so it behaves like windows and our ole32 doesn't trip on its

[ros-diffs] [gadamopoulos] 75607: [SHELL32] Shell extension support for files. - CFSFolder: Implement binding to files, implement loading arbitrary extensions for GetUIObjectOf from the registry, impl

2017-08-18 Thread gadamopoulos
Author: gadamopoulos Date: Fri Aug 18 09:11:59 2017 New Revision: 75607 URL: http://svn.reactos.org/svn/reactos?rev=75607=rev Log: [SHELL32] Shell extension support for files. - CFSFolder: Implement binding to files, implement loading arbitrary extensions for GetUIObjectOf from the registry

[ros-diffs] [gadamopoulos] 75604: [STOBJECT] Fix bug that caused some resource strings not to be loaded. - These strings need to either be in every language file or have their own resource range but s

2017-08-18 Thread gadamopoulos
Author: gadamopoulos Date: Fri Aug 18 08:38:52 2017 New Revision: 75604 URL: http://svn.reactos.org/svn/reactos?rev=75604=rev Log: [STOBJECT] Fix bug that caused some resource strings not to be loaded. - These strings need to either be in every language file or have their own resource range

[ros-diffs] [gadamopoulos] 75601: [WIN32K] -Fix a bug with TransparentBlt when it should really ignore the alpha channel. CORE-13040. Approved by Timo.

2017-08-17 Thread gadamopoulos
Author: gadamopoulos Date: Thu Aug 17 22:45:51 2017 New Revision: 75601 URL: http://svn.reactos.org/svn/reactos?rev=75601=rev Log: [WIN32K] -Fix a bug with TransparentBlt when it should really ignore the alpha channel. CORE-13040. Approved by Timo. Modified: trunk/reactos/win32ss/gdi/dib

[ros-diffs] [gadamopoulos] 75600: [UXTHEME] -Remove some dead code

2017-08-17 Thread gadamopoulos
Author: gadamopoulos Date: Thu Aug 17 21:31:52 2017 New Revision: 75600 URL: http://svn.reactos.org/svn/reactos?rev=75600=rev Log: [UXTHEME] -Remove some dead code Modified: trunk/reactos/dll/win32/uxtheme/nonclient.c Modified: trunk/reactos/dll/win32/uxtheme/nonclient.c URL: http

[ros-diffs] [gadamopoulos] 75597: [SHELL32] -Simplify some coe in CShellLink.cpp

2017-08-17 Thread gadamopoulos
Author: gadamopoulos Date: Thu Aug 17 16:46:15 2017 New Revision: 75597 URL: http://svn.reactos.org/svn/reactos?rev=75597=rev Log: [SHELL32] -Simplify some coe in CShellLink.cpp Modified: trunk/reactos/dll/win32/shell32/CShellLink.cpp Modified: trunk/reactos/dll/win32/shell32/CShellLink.cpp

[ros-diffs] [gadamopoulos] 75595: [SHELL32] -AddFSClassKeysToArray: Increase the size of the buffer for the value read from the registry. There are cases when 40 are not enough.

2017-08-17 Thread gadamopoulos
Author: gadamopoulos Date: Thu Aug 17 16:35:16 2017 New Revision: 75595 URL: http://svn.reactos.org/svn/reactos?rev=75595=rev Log: [SHELL32] -AddFSClassKeysToArray: Increase the size of the buffer for the value read from the registry. There are cases when 40 are not enough. Modified: trunk

[ros-diffs] [gadamopoulos] 75593: [COM_APITEST] -Add tests for CLSID_AttachmentServices.

2017-08-17 Thread gadamopoulos
Author: gadamopoulos Date: Thu Aug 17 16:01:29 2017 New Revision: 75593 URL: http://svn.reactos.org/svn/reactos?rev=75593=rev Log: [COM_APITEST] -Add tests for CLSID_AttachmentServices. Modified: trunk/rostests/apitests/com/com_apitest.c trunk/rostests/apitests/com/com_apitest.h

[ros-diffs] [gadamopoulos] 75592: [ADVAPI32] -RegOpenKeyExW: Call NtOpenKey again with aligned parameters if STATUS_DATATYPE_MISALIGNMENT was returned the first time. CORE-13689

2017-08-17 Thread gadamopoulos
Author: gadamopoulos Date: Thu Aug 17 14:37:24 2017 New Revision: 75592 URL: http://svn.reactos.org/svn/reactos?rev=75592=rev Log: [ADVAPI32] -RegOpenKeyExW: Call NtOpenKey again with aligned parameters if STATUS_DATATYPE_MISALIGNMENT was returned the first time. CORE-13689 Modified: trunk

[ros-diffs] [gadamopoulos] 75561: [SHLWAPI] -Addendum to 75533. Pass the id offset to IContextMenu::InvokeCommand. Fixes launching applications from the start menu. CORE-13680

2017-08-15 Thread gadamopoulos
Author: gadamopoulos Date: Tue Aug 15 23:02:45 2017 New Revision: 75561 URL: http://svn.reactos.org/svn/reactos?rev=75561=rev Log: [SHLWAPI] -Addendum to 75533. Pass the id offset to IContextMenu::InvokeCommand. Fixes launching applications from the start menu. CORE-13680 Modified: trunk

[ros-diffs] [gadamopoulos] 75550: [SHELL32] -Greatly optimize the already hacky implementations of ILIsEqual, ILIsParent and ILFindChild by not using the crappy _ILSimpleGetText but the new one _ILHAC

2017-08-15 Thread gadamopoulos
Author: gadamopoulos Date: Tue Aug 15 12:13:19 2017 New Revision: 75550 URL: http://svn.reactos.org/svn/reactos?rev=75550=rev Log: [SHELL32] -Greatly optimize the already hacky implementations of ILIsEqual, ILIsParent and ILFindChild by not using the crappy _ILSimpleGetText but the new one

[ros-diffs] [gadamopoulos] 75535: [COMCTL32] -DrawShadowText: Don't print an error when GdiAlphaBlend fails. This can happen when the painting is outside the clip region. Some themes tend to move text

2017-08-14 Thread gadamopoulos
Author: gadamopoulos Date: Mon Aug 14 15:51:12 2017 New Revision: 75535 URL: http://svn.reactos.org/svn/reactos?rev=75535=rev Log: [COMCTL32] -DrawShadowText: Don't print an error when GdiAlphaBlend fails. This can happen when the painting is outside the clip region. Some themes tend to move

[ros-diffs] [gadamopoulos] 75533: [SHELL32] - CDefaultContextMenu: Make it respect the IContextMenu interface and expect menu id offsets instead of real menu ids and actually use the idCmdFirst and id

2017-08-14 Thread gadamopoulos
Author: gadamopoulos Date: Mon Aug 14 15:25:58 2017 New Revision: 75533 URL: http://svn.reactos.org/svn/reactos?rev=75533=rev Log: [SHELL32] - CDefaultContextMenu: Make it respect the IContextMenu interface and expect menu id offsets instead of real menu ids and actually use the idCmdFirst

[ros-diffs] [gadamopoulos] 75514: [UXTHEME] -Implement taking into account the flags set by SetThemeAppProperties. Now the shim that disables themes per application works.

2017-08-09 Thread gadamopoulos
Author: gadamopoulos Date: Wed Aug 9 08:14:50 2017 New Revision: 75514 URL: http://svn.reactos.org/svn/reactos?rev=75514=rev Log: [UXTHEME] -Implement taking into account the flags set by SetThemeAppProperties. Now the shim that disables themes per application works. Modified: trunk

[ros-diffs] [gadamopoulos] 75513: [UXTHEME_APITEST] -Add tests for SetThemeAppProperties.

2017-08-09 Thread gadamopoulos
Author: gadamopoulos Date: Wed Aug 9 07:14:44 2017 New Revision: 75513 URL: http://svn.reactos.org/svn/reactos?rev=75513=rev Log: [UXTHEME_APITEST] -Add tests for SetThemeAppProperties. Added: trunk/rostests/apitests/uxtheme/SetThemeAppProperties.c (with props) Modified: trunk

[ros-diffs] [gadamopoulos] 75511: [USER32] -Make it clear when VersionRegisterClass is used. This should be called after a versioned class was not found hence it should appear after some failures in w

2017-08-08 Thread gadamopoulos
Author: gadamopoulos Date: Tue Aug 8 21:09:51 2017 New Revision: 75511 URL: http://svn.reactos.org/svn/reactos?rev=75511=rev Log: [USER32] -Make it clear when VersionRegisterClass is used. This should be called after a versioned class was not found hence it should appear after some failures

[ros-diffs] [gadamopoulos] 75502: [COMCTL32] -Fix a typo.

2017-08-07 Thread gadamopoulos
Author: gadamopoulos Date: Mon Aug 7 11:08:26 2017 New Revision: 75502 URL: http://svn.reactos.org/svn/reactos?rev=75502=rev Log: [COMCTL32] -Fix a typo. Modified: trunk/reactos/dll/win32/comctl32/button.c Modified: trunk/reactos/dll/win32/comctl32/button.c URL: http://svn.reactos.org/svn

[ros-diffs] [gadamopoulos] 75500: [SHELL32] -Restore some code I incorrectly removed in r75360. CORE-13564

2017-08-07 Thread gadamopoulos
Author: gadamopoulos Date: Mon Aug 7 10:09:30 2017 New Revision: 75500 URL: http://svn.reactos.org/svn/reactos?rev=75500=rev Log: [SHELL32] -Restore some code I incorrectly removed in r75360. CORE-13564 Modified: trunk/reactos/dll/win32/shell32/folders/CDesktopFolder.cpp Modified: trunk

[ros-diffs] [gadamopoulos] 75495: [SYSSETUP] -Implement a wizard page that lets the user select lautus as the default theme. If the user keeps pressing enter, the theme will not be applied.

2017-08-06 Thread gadamopoulos
Author: gadamopoulos Date: Sun Aug 6 09:18:19 2017 New Revision: 75495 URL: http://svn.reactos.org/svn/reactos?rev=75495=rev Log: [SYSSETUP] -Implement a wizard page that lets the user select lautus as the default theme. If the user keeps pressing enter, the theme will not be applied. Added

[ros-diffs] [gadamopoulos] 75494: [COMCTL32] -Implement BUTTON_IMAGELIST_ALIGN_RIGHT, BUTTON_IMAGELIST_ALIGN_TOP, BUTTON_IMAGELIST_ALIGN_BOTTOM

2017-08-06 Thread gadamopoulos
Author: gadamopoulos Date: Sun Aug 6 09:05:58 2017 New Revision: 75494 URL: http://svn.reactos.org/svn/reactos?rev=75494=rev Log: [COMCTL32] -Implement BUTTON_IMAGELIST_ALIGN_RIGHT, BUTTON_IMAGELIST_ALIGN_TOP, BUTTON_IMAGELIST_ALIGN_BOTTOM Modified: trunk/reactos/dll/win32/comctl32

[ros-diffs] [gadamopoulos] 75488: [COMCTL32] -BUTTON_PaintWithTheme: Draw checked pushlike buttons as pressed.

2017-08-05 Thread gadamopoulos
Author: gadamopoulos Date: Sat Aug 5 10:23:07 2017 New Revision: 75488 URL: http://svn.reactos.org/svn/reactos?rev=75488=rev Log: [COMCTL32] -BUTTON_PaintWithTheme: Draw checked pushlike buttons as pressed. Modified: trunk/reactos/dll/win32/comctl32/theme_button.c Modified: trunk/reactos

[ros-diffs] [gadamopoulos] 75477: [hivecls.inf] -Add an option to immediately enable an msstyles file with right click.

2017-08-04 Thread gadamopoulos
Author: gadamopoulos Date: Fri Aug 4 09:12:33 2017 New Revision: 75477 URL: http://svn.reactos.org/svn/reactos?rev=75477=rev Log: [hivecls.inf] -Add an option to immediately enable an msstyles file with right click. Modified: trunk/reactos/boot/bootdata/hivecls.inf Modified: trunk/reactos

[ros-diffs] [gadamopoulos] 75476: [DESK.CPL] -Improve the hack that lets it process arguments by using the process command line instead of the one shell32 gives to the cpl. -Implement a new action cal

2017-08-04 Thread gadamopoulos
Author: gadamopoulos Date: Fri Aug 4 08:53:06 2017 New Revision: 75476 URL: http://svn.reactos.org/svn/reactos?rev=75476=rev Log: [DESK.CPL] -Improve the hack that lets it process arguments by using the process command line instead of the one shell32 gives to the cpl. -Implement a new action

[ros-diffs] [gadamopoulos] 75464: [SYSSETUP.INF] -Move registering comctl32.dll and ole32.dll much earlier in the setup.

2017-07-31 Thread gadamopoulos
Author: gadamopoulos Date: Mon Jul 31 16:11:09 2017 New Revision: 75464 URL: http://svn.reactos.org/svn/reactos?rev=75464=rev Log: [SYSSETUP.INF] -Move registering comctl32.dll and ole32.dll much earlier in the setup. Modified: trunk/reactos/media/inf/syssetup.inf Modified: trunk/reactos

[ros-diffs] [gadamopoulos] 75463: [COMCTL32] -Fix some failed tests for TB_GETMETRICS. Add support for button spacing.

2017-07-31 Thread gadamopoulos
Author: gadamopoulos Date: Mon Jul 31 13:10:46 2017 New Revision: 75463 URL: http://svn.reactos.org/svn/reactos?rev=75463=rev Log: [COMCTL32] -Fix some failed tests for TB_GETMETRICS. Add support for button spacing. Modified: trunk/reactos/dll/win32/comctl32/toolbar.c Modified: trunk

[ros-diffs] [gadamopoulos] 75462: [COMCTL32_APITESTS] -Add toolbar tests for TB_SETBUTTONSIZE, TB_SETPADDING, TB_GETBUTTONSIZE, TB_GETMETRICS.

2017-07-31 Thread gadamopoulos
Author: gadamopoulos Date: Mon Jul 31 13:04:09 2017 New Revision: 75462 URL: http://svn.reactos.org/svn/reactos?rev=75462=rev Log: [COMCTL32_APITESTS] -Add toolbar tests for TB_SETBUTTONSIZE, TB_SETPADDING, TB_GETBUTTONSIZE, TB_GETMETRICS. Modified: trunk/rostests/apitests/comctl32

[ros-diffs] [gadamopoulos] 75439: [UXTHEME] -Fix for the 3rd or 4th time the bug where the caption window overflows over the caption buttons which was last broken by me in 74960. CORE-13435

2017-07-29 Thread gadamopoulos
Author: gadamopoulos Date: Sat Jul 29 09:43:48 2017 New Revision: 75439 URL: http://svn.reactos.org/svn/reactos?rev=75439=rev Log: [UXTHEME] -Fix for the 3rd or 4th time the bug where the caption window overflows over the caption buttons which was last broken by me in 74960. CORE-13435

[ros-diffs] [gadamopoulos] 75437: [COMCTL32] -Take into account the upper theme margin when drawing the icon so that it doesn't look misplaced. This makes the themed taskbar buttons look more or less

2017-07-29 Thread gadamopoulos
Author: gadamopoulos Date: Sat Jul 29 08:52:04 2017 New Revision: 75437 URL: http://svn.reactos.org/svn/reactos?rev=75437=rev Log: [COMCTL32] -Take into account the upper theme margin when drawing the icon so that it doesn't look misplaced. This makes the themed taskbar buttons look more

[ros-diffs] [gadamopoulos] 75406: [COMCTL32] -Implement taking into account the contents margins from the theme when calculating the size of the toolbar button. Using it while painting the button will

2017-07-25 Thread gadamopoulos
Author: gadamopoulos Date: Tue Jul 25 22:41:26 2017 New Revision: 75406 URL: http://svn.reactos.org/svn/reactos?rev=75406=rev Log: [COMCTL32] -Implement taking into account the contents margins from the theme when calculating the size of the toolbar button. Using it while painting the button

[ros-diffs] [gadamopoulos] 75389: [EXPLORER] -Restore a call to RegLoadSettings while handling WM_DISPLAYCHANGE which was removed in r74221. This is not really correct since it resets the size and pos

2017-07-22 Thread gadamopoulos
Author: gadamopoulos Date: Sat Jul 22 17:13:06 2017 New Revision: 75389 URL: http://svn.reactos.org/svn/reactos?rev=75389=rev Log: [EXPLORER] -Restore a call to RegLoadSettings while handling WM_DISPLAYCHANGE which was removed in r74221. This is not really correct since it resets the size

[ros-diffs] [gadamopoulos] 75385: [BROWSEUI] -CBandSite: Remove CCS_NORESIZE style. This is a hack probably needed because our rebar control is buggy. [EXPLORER] -CTaskBand::GetBandInfo: Use the toolb

2017-07-21 Thread gadamopoulos
Author: gadamopoulos Date: Fri Jul 21 14:32:15 2017 New Revision: 75385 URL: http://svn.reactos.org/svn/reactos?rev=75385=rev Log: [BROWSEUI] -CBandSite: Remove CCS_NORESIZE style. This is a hack probably needed because our rebar control is buggy. [EXPLORER] -CTaskBand::GetBandInfo: Use

[ros-diffs] [gadamopoulos] 75360: [SHELL32] -CRegFolder: Implement CRegFolder::EnumObjects. Change its constructor to receive an extra parameter for the name of the key that should be enumerated. -CEn

2017-07-16 Thread gadamopoulos
Author: gadamopoulos Date: Sun Jul 16 15:13:02 2017 New Revision: 75360 URL: http://svn.reactos.org/svn/reactos?rev=75360=rev Log: [SHELL32] -CRegFolder: Implement CRegFolder::EnumObjects. Change its constructor to receive an extra parameter for the name of the key that should be enumerated

[ros-diffs] [gadamopoulos] 75352: [SHELL32] -Move CFSExtractIcon_CreateInstance to CFSFolder.cpp

2017-07-15 Thread gadamopoulos
Author: gadamopoulos Date: Sat Jul 15 09:38:45 2017 New Revision: 75352 URL: http://svn.reactos.org/svn/reactos?rev=75352=rev Log: [SHELL32] -Move CFSExtractIcon_CreateInstance to CFSFolder.cpp Modified: trunk/reactos/dll/win32/shell32/folders.cpp trunk/reactos/dll/win32/shell32/folders

[ros-diffs] [gadamopoulos] 75350: [SHELL32] - CDesktopFolder: Create the enumerators of the internal fs folders and add their items in its own list instead of calling CreateFolderEnumList which enumer

2017-07-15 Thread gadamopoulos
Author: gadamopoulos Date: Sat Jul 15 09:18:06 2017 New Revision: 75350 URL: http://svn.reactos.org/svn/reactos?rev=75350=rev Log: [SHELL32] - CDesktopFolder: Create the enumerators of the internal fs folders and add their items in its own list instead of calling CreateFolderEnumList which

[ros-diffs] [gadamopoulos] 75320: [COMCTL32_APITEST] - Log the dwDrawStage when the NM_CUSTOMDRAW is received to make the test slightly more descriptive.

2017-07-12 Thread gadamopoulos
Author: gadamopoulos Date: Wed Jul 12 12:17:05 2017 New Revision: 75320 URL: http://svn.reactos.org/svn/reactos?rev=75320=rev Log: [COMCTL32_APITEST] - Log the dwDrawStage when the NM_CUSTOMDRAW is received to make the test slightly more descriptive. Modified: trunk/rostests/apitests

[ros-diffs] [gadamopoulos] 75313: [EXPLORER] - CTrayWindow: Implement the IContextMenu interface. This will be used by the CBandSite to query the context menu of its site (the CTrayWindow) and add it

2017-07-09 Thread gadamopoulos
Author: gadamopoulos Date: Sun Jul 9 20:57:01 2017 New Revision: 75313 URL: http://svn.reactos.org/svn/reactos?rev=75313=rev Log: [EXPLORER] - CTrayWindow: Implement the IContextMenu interface. This will be used by the CBandSite to query the context menu of its site (the CTrayWindow) and add

[ros-diffs] [gadamopoulos] 75301: [SHELL32] - Simplify SHELL32_CoCreateInitSF by letting the callers fill the PERSIST_FOLDER_TARGET_INFO. This lets us stop using _ILSimpleGetTextW in it which breaks t

2017-07-07 Thread gadamopoulos
Author: gadamopoulos Date: Fri Jul 7 20:34:27 2017 New Revision: 75301 URL: http://svn.reactos.org/svn/reactos?rev=75301=rev Log: [SHELL32] - Simplify SHELL32_CoCreateInitSF by letting the callers fill the PERSIST_FOLDER_TARGET_INFO. This lets us stop using _ILSimpleGetTextW in it which breaks

[ros-diffs] [gadamopoulos] 75289: [SHELL32] -Remove IShellView_Constructor and CDefView_Constructor. Use SHCreateShellFolderView and SHCreateShellFolderViewEx instead.

2017-07-05 Thread gadamopoulos
Author: gadamopoulos Date: Wed Jul 5 21:36:20 2017 New Revision: 75289 URL: http://svn.reactos.org/svn/reactos?rev=75289=rev Log: [SHELL32] -Remove IShellView_Constructor and CDefView_Constructor. Use SHCreateShellFolderView and SHCreateShellFolderViewEx instead. Modified: trunk/reactos

[ros-diffs] [gadamopoulos] 75230: [BROWSEUI] -CBandSite: Remove the Close item menu if the band is undeletable. Remove the Show caption menu item if the band doesn't have a caption. Implement showing

2017-06-29 Thread gadamopoulos
Author: gadamopoulos Date: Thu Jun 29 09:41:00 2017 New Revision: 75230 URL: http://svn.reactos.org/svn/reactos?rev=75230=rev Log: [BROWSEUI] -CBandSite: Remove the Close item menu if the band is undeletable. Remove the Show caption menu item if the band doesn't have a caption. Implement

[ros-diffs] [gadamopoulos] 75216: [BROWSEUI] -CBandSite: Implement the context menu of the rebar. It queries the IContextMenu if the band and appends to it a static menu part that can show or hide the

2017-06-27 Thread gadamopoulos
Author: gadamopoulos Date: Tue Jun 27 10:05:59 2017 New Revision: 75216 URL: http://svn.reactos.org/svn/reactos?rev=75216=rev Log: [BROWSEUI] -CBandSite: Implement the context menu of the rebar. It queries the IContextMenu if the band and appends to it a static menu part that can show or hide

[ros-diffs] [gadamopoulos] 75154: [WIN32K:NTUSER] -IntSetThreadDesktop: Don't close the previous desktop handle. Fixes a lot of tests. Based on a patch by Sebastian Gasiorek. CORE-13463

2017-06-20 Thread gadamopoulos
Author: gadamopoulos Date: Tue Jun 20 19:26:37 2017 New Revision: 75154 URL: http://svn.reactos.org/svn/reactos?rev=75154=rev Log: [WIN32K:NTUSER] -IntSetThreadDesktop: Don't close the previous desktop handle. Fixes a lot of tests. Based on a patch by Sebastian Gasiorek. CORE-13463 Modified

[ros-diffs] [gadamopoulos] 75153: [USER32_APITEST] -Initial tests for desktop reference numbers.

2017-06-20 Thread gadamopoulos
Author: gadamopoulos Date: Tue Jun 20 19:25:10 2017 New Revision: 75153 URL: http://svn.reactos.org/svn/reactos?rev=75153=rev Log: [USER32_APITEST] -Initial tests for desktop reference numbers. Modified: trunk/rostests/apitests/user32/desktop.c Modified: trunk/rostests/apitests/user32

[ros-diffs] [gadamopoulos] 75129: [ATL] -Add a new template called CComQIIDPtr and its partner I_ID macro. Its purpose is to be a gcc compatible version of CComQIPtr. -CComQIIDPtr<I_ID(Itype)> is the

2017-06-19 Thread gadamopoulos
Author: gadamopoulos Date: Mon Jun 19 14:52:51 2017 New Revision: 75129 URL: http://svn.reactos.org/svn/reactos?rev=75129=rev Log: [ATL] -Add a new template called CComQIIDPtr and its partner I_ID macro. Its purpose is to be a gcc compatible version of CComQIPtr. -CComQIIDPtr<I_ID(It

[ros-diffs] [gadamopoulos] 75127: [SHELL32] -Rename constructors from Class_Creator to Class_CreateInstance. Prepend the ones that are exported from rshell with RSHELL_. The reasoning is that rshell w

2017-06-19 Thread gadamopoulos
Author: gadamopoulos Date: Mon Jun 19 14:27:51 2017 New Revision: 75127 URL: http://svn.reactos.org/svn/reactos?rev=75127=rev Log: [SHELL32] -Rename constructors from Class_Creator to Class_CreateInstance. Prepend the ones that are exported from rshell with RSHELL_. The reasoning is that rshell

[ros-diffs] [gadamopoulos] 75090: [SHELL32] -CMenuBand::SetSite: Don't fail if the site doesn't support the SID_STopLevelBrowser service.

2017-06-18 Thread gadamopoulos
Author: gadamopoulos Date: Sun Jun 18 12:34:30 2017 New Revision: 75090 URL: http://svn.reactos.org/svn/reactos?rev=75090=rev Log: [SHELL32] -CMenuBand::SetSite: Don't fail if the site doesn't support the SID_STopLevelBrowser service. Modified: trunk/reactos/dll/win32/shell32/shellmenu

[ros-diffs] [gadamopoulos] 75072: [SHELL32] -CMenuBand: forward WM_WININICHANGE to CMenuToolbarBase so that when themes get enabled, the menu bar in explorer becomes flat immediately.

2017-06-17 Thread gadamopoulos
Author: gadamopoulos Date: Sat Jun 17 07:43:52 2017 New Revision: 75072 URL: http://svn.reactos.org/svn/reactos?rev=75072=rev Log: [SHELL32] -CMenuBand: forward WM_WININICHANGE to CMenuToolbarBase so that when themes get enabled, the menu bar in explorer becomes flat immediately. Modified

[ros-diffs] [gadamopoulos] 75058: [SHELL32] -CMenuBand: When the flat menus style is enabled, shell menu bars should not look like toolbars.

2017-06-16 Thread gadamopoulos
Author: gadamopoulos Date: Fri Jun 16 17:53:50 2017 New Revision: 75058 URL: http://svn.reactos.org/svn/reactos?rev=75058=rev Log: [SHELL32] -CMenuBand: When the flat menus style is enabled, shell menu bars should not look like toolbars. Modified: trunk/reactos/dll/win32/shell32/shellmenu

[ros-diffs] [gadamopoulos] 75026: [WIN32K] -Use RtlStringCchCopyW instead of RtlStringCbCopyW in SubstituteFontRecurse as LF_FACESIZE is the number of characters of the buffer. Patch by Katayama Hirof

2017-06-13 Thread gadamopoulos
Author: gadamopoulos Date: Tue Jun 13 20:17:07 2017 New Revision: 75026 URL: http://svn.reactos.org/svn/reactos?rev=75026=rev Log: [WIN32K] -Use RtlStringCchCopyW instead of RtlStringCbCopyW in SubstituteFontRecurse as LF_FACESIZE is the number of characters of the buffer. Patch by Katayama

[ros-diffs] [gadamopoulos] 75025: [PSDK] -Add IShellFolderBand and IFolderBandPriv interfaces.

2017-06-13 Thread gadamopoulos
Author: gadamopoulos Date: Tue Jun 13 15:00:50 2017 New Revision: 75025 URL: http://svn.reactos.org/svn/reactos?rev=75025=rev Log: [PSDK] -Add IShellFolderBand and IFolderBandPriv interfaces. Modified: branches/GSoC_2017/shellext/reactos/sdk/include/psdk/shlobj.h branches/GSoC_2017

[ros-diffs] [gadamopoulos] 75023: [PSDK] -Add CLSID_ISFBand, IID_IShellFolderBand and IID_IFolderBandPriv.

2017-06-13 Thread gadamopoulos
Author: gadamopoulos Date: Tue Jun 13 13:56:11 2017 New Revision: 75023 URL: http://svn.reactos.org/svn/reactos?rev=75023=rev Log: [PSDK] -Add CLSID_ISFBand, IID_IShellFolderBand and IID_IFolderBandPriv. Modified: branches/GSoC_2017/shellext/reactos/sdk/include/psdk/shlguid.h Modified

[ros-diffs] [gadamopoulos] 75013: [SHELL32] -Add Comments as the 2nd column in CDesktopFolder, CDrivesFolder and CRegFolder. Add Type as the 3rd column in CRegFolder. This is not entirely correct. Our

2017-06-12 Thread gadamopoulos
Author: gadamopoulos Date: Mon Jun 12 18:38:26 2017 New Revision: 75013 URL: http://svn.reactos.org/svn/reactos?rev=75013=rev Log: [SHELL32] -Add Comments as the 2nd column in CDesktopFolder, CDrivesFolder and CRegFolder. Add Type as the 3rd column in CRegFolder. This is not entirely correct

[ros-diffs] [gadamopoulos] 75012: Fix build.

2017-06-12 Thread gadamopoulos
Author: gadamopoulos Date: Mon Jun 12 10:11:39 2017 New Revision: 75012 URL: http://svn.reactos.org/svn/reactos?rev=75012=rev Log: Fix build. Modified: trunk/reactos/dll/win32/shell32/folders/CRecycleBin.cpp Modified: trunk/reactos/dll/win32/shell32/folders/CRecycleBin.cpp URL: http

[ros-diffs] [gadamopoulos] 75011: [SHELL32] - Rename the resource identifiers for column names to make sense. Get rid of one called File. This was renamed to Name but was the same in other languages,

2017-06-12 Thread gadamopoulos
Author: gadamopoulos Date: Mon Jun 12 10:01:28 2017 New Revision: 75011 URL: http://svn.reactos.org/svn/reactos?rev=75011=rev Log: [SHELL32] - Rename the resource identifiers for column names to make sense. Get rid of one called File. This was renamed to Name but was the same in other languages

[ros-diffs] [gadamopoulos] 75005: [SHELL32] -CDrivesFolder: Implement returning the appropriate type string in GetDetailsOf. Simplify GetDetailsOf and CDrivesExtractIcon_CreateInstance.

2017-06-11 Thread gadamopoulos
Author: gadamopoulos Date: Sun Jun 11 14:02:14 2017 New Revision: 75005 URL: http://svn.reactos.org/svn/reactos?rev=75005=rev Log: [SHELL32] -CDrivesFolder: Implement returning the appropriate type string in GetDetailsOf. Simplify GetDetailsOf and CDrivesExtractIcon_CreateInstance. Modified

[ros-diffs] [gadamopoulos] 74972: [EXPLORER] -Use WM_POPUPSYSTEMMENU to open the system menu of a window. CORE-13400

2017-06-09 Thread gadamopoulos
Author: gadamopoulos Date: Fri Jun 9 09:16:44 2017 New Revision: 74972 URL: http://svn.reactos.org/svn/reactos?rev=74972=rev Log: [EXPLORER] -Use WM_POPUPSYSTEMMENU to open the system menu of a window. CORE-13400 Modified: trunk/reactos/base/shell/explorer/taskswnd.cpp Modified: trunk

[ros-diffs] [gadamopoulos] 74971: [EXPLORER] -Fix the return value in HandleShellHookMsg. Suggestion by Christoph.

2017-06-09 Thread gadamopoulos
Author: gadamopoulos Date: Fri Jun 9 08:29:04 2017 New Revision: 74971 URL: http://svn.reactos.org/svn/reactos?rev=74971=rev Log: [EXPLORER] -Fix the return value in HandleShellHookMsg. Suggestion by Christoph. Modified: trunk/reactos/base/shell/explorer/taskswnd.cpp Modified: trunk

[ros-diffs] [gadamopoulos] 74968: [EXPLORER] -Revert a hack from r63304 that caused CORE-13388. This hid another bug and the correct way to fix this is to return MA_NOACTIVATE to WM_MOUSEACTIVATE.

2017-06-08 Thread gadamopoulos
Author: gadamopoulos Date: Thu Jun 8 20:31:49 2017 New Revision: 74968 URL: http://svn.reactos.org/svn/reactos?rev=74968=rev Log: [EXPLORER] -Revert a hack from r63304 that caused CORE-13388. This hid another bug and the correct way to fix this is to return MA_NOACTIVATE to WM_MOUSEACTIVATE

[ros-diffs] [gadamopoulos] 74965: [EXPLORER] -Open the start menu on mouse down. Patch by Joachim Henze (reactosfanboy). CORE-13375

2017-06-08 Thread gadamopoulos
Author: gadamopoulos Date: Thu Jun 8 18:57:53 2017 New Revision: 74965 URL: http://svn.reactos.org/svn/reactos?rev=74965=rev Log: [EXPLORER] -Open the start menu on mouse down. Patch by Joachim Henze (reactosfanboy). CORE-13375 Modified: trunk/reactos/base/shell/explorer/traywnd.cpp

[ros-diffs] [gadamopoulos] 74960: [UXTHEME] -Implement support for non rectangular caption buttons in WM_NCHITTEST handling. Please note that non rectangular buttons or buttons with no gaps between th

2017-06-08 Thread gadamopoulos
Author: gadamopoulos Date: Thu Jun 8 14:27:52 2017 New Revision: 74960 URL: http://svn.reactos.org/svn/reactos?rev=74960=rev Log: [UXTHEME] -Implement support for non rectangular caption buttons in WM_NCHITTEST handling. Please note that non rectangular buttons or buttons with no gaps between

[ros-diffs] [gadamopoulos] 74935: [UXTHEME] -Fix parsing font styles like bold or italic.

2017-06-07 Thread gadamopoulos
Author: gadamopoulos Date: Wed Jun 7 08:35:35 2017 New Revision: 74935 URL: http://svn.reactos.org/svn/reactos?rev=74935=rev Log: [UXTHEME] -Fix parsing font styles like bold or italic. Modified: trunk/reactos/dll/win32/uxtheme/msstyles.c Modified: trunk/reactos/dll/win32/uxtheme

[ros-diffs] [gadamopoulos] 74934: [UXTHEME] -Rename ActiveThemeFile to g_ActiveThemeFile, user32ApiHook to g_user32ApiHook and gbThemeHooksActive to g_bThemeHooksActive.

2017-06-07 Thread gadamopoulos
Author: gadamopoulos Date: Wed Jun 7 08:28:14 2017 New Revision: 74934 URL: http://svn.reactos.org/svn/reactos?rev=74934=rev Log: [UXTHEME] -Rename ActiveThemeFile to g_ActiveThemeFile, user32ApiHook to g_user32ApiHook and gbThemeHooksActive to g_bThemeHooksActive. Modified: trunk/reactos

[ros-diffs] [gadamopoulos] 74931: [COMCTL32] -Fix a lot of tests for the v5 toolbar without braking the behavior of the v6 one (that needs to be tested).

2017-06-06 Thread gadamopoulos
Author: gadamopoulos Date: Tue Jun 6 12:19:17 2017 New Revision: 74931 URL: http://svn.reactos.org/svn/reactos?rev=74931=rev Log: [COMCTL32] -Fix a lot of tests for the v5 toolbar without braking the behavior of the v6 one (that needs to be tested). Modified: trunk/reactos/dll/win32

[ros-diffs] [gadamopoulos] 74929: [COMCTL32_APITEST] -Make comctl32v5.manifest really point to the v5 library.

2017-06-05 Thread gadamopoulos
Author: gadamopoulos Date: Mon Jun 5 21:50:21 2017 New Revision: 74929 URL: http://svn.reactos.org/svn/reactos?rev=74929=rev Log: [COMCTL32_APITEST] -Make comctl32v5.manifest really point to the v5 library. Modified: trunk/rostests/apitests/comctl32/comctl32v5.manifest Modified: trunk

[ros-diffs] [gadamopoulos] 74924: Fix gcc build.

2017-06-05 Thread gadamopoulos
Author: gadamopoulos Date: Mon Jun 5 14:40:48 2017 New Revision: 74924 URL: http://svn.reactos.org/svn/reactos?rev=74924=rev Log: Fix gcc build. Modified: trunk/rostests/apitests/comctl32/toolbar.c Modified: trunk/rostests/apitests/comctl32/toolbar.c URL: http://svn.reactos.org/svn

[ros-diffs] [gadamopoulos] 74923: [COMCTL32_APITEST] -Add tests for CCM_GETVERSION and CCM_SETVERSION for the v5 and v6 toolbar control.

2017-06-05 Thread gadamopoulos
Author: gadamopoulos Date: Mon Jun 5 14:25:37 2017 New Revision: 74923 URL: http://svn.reactos.org/svn/reactos?rev=74923=rev Log: [COMCTL32_APITEST] -Add tests for CCM_GETVERSION and CCM_SETVERSION for the v5 and v6 toolbar control. Added: trunk/rostests/apitests/comctl32/comctl32v5

[ros-diffs] [gadamopoulos] 74922: [COMCTL32] -Differentiate between v5 and v6 toolbar and make their CCM_SETVERSION behave correct according to their version.

2017-06-05 Thread gadamopoulos
Author: gadamopoulos Date: Mon Jun 5 14:23:42 2017 New Revision: 74922 URL: http://svn.reactos.org/svn/reactos?rev=74922=rev Log: [COMCTL32] -Differentiate between v5 and v6 toolbar and make their CCM_SETVERSION behave correct according to their version. Modified: trunk/reactos/dll/win32

[ros-diffs] [gadamopoulos] 74692: [EXPLORER] -Implement the trick that makes the start button to get clicked when the user clicks on the corner of the screen.

2017-05-28 Thread gadamopoulos
Author: gadamopoulos Date: Sun May 28 18:31:48 2017 New Revision: 74692 URL: http://svn.reactos.org/svn/reactos?rev=74692=rev Log: [EXPLORER] -Implement the trick that makes the start button to get clicked when the user clicks on the corner of the screen. Modified: trunk/reactos/base/shell

[ros-diffs] [gadamopoulos] 74680: [EXPLORER] -Make the taskbar grip get its size from the theme. This fixes one of the last theme related problems in explorer itself. Also simplify some theme drawing

2017-05-27 Thread gadamopoulos
Author: gadamopoulos Date: Sat May 27 10:44:44 2017 New Revision: 74680 URL: http://svn.reactos.org/svn/reactos?rev=74680=rev Log: [EXPLORER] -Make the taskbar grip get its size from the theme. This fixes one of the last theme related problems in explorer itself. Also simplify some theme

[ros-diffs] [gadamopoulos] 74677: [EXPLORER] -Reload the theme data only when the orientation changes (we ended up reloading it every few seconds).

2017-05-27 Thread gadamopoulos
Author: gadamopoulos Date: Sat May 27 09:09:01 2017 New Revision: 74677 URL: http://svn.reactos.org/svn/reactos?rev=74677=rev Log: [EXPLORER] -Reload the theme data only when the orientation changes (we ended up reloading it every few seconds). Modified: trunk/reactos/base/shell/explorer

[ros-diffs] [gadamopoulos] 74633: [WIN32l:NTGDI] -Check the return value IntGetOutlineTextMetrics and stop using garbage from the pool in case of error. CORE-13089, CORE-12752

2017-05-23 Thread gadamopoulos
Author: gadamopoulos Date: Tue May 23 09:40:07 2017 New Revision: 74633 URL: http://svn.reactos.org/svn/reactos?rev=74633=rev Log: [WIN32l:NTGDI] -Check the return value IntGetOutlineTextMetrics and stop using garbage from the pool in case of error. CORE-13089, CORE-12752 Modified: trunk

[ros-diffs] [gadamopoulos] 74630: [WIN32K] -Simplify the parameters passed to GetFontPenalty and FindBestFontFromList. Make SubstituteFontRecurse update a LOGFONT and get rid of some needless allocati

2017-05-22 Thread gadamopoulos
Author: gadamopoulos Date: Mon May 22 18:17:49 2017 New Revision: 74630 URL: http://svn.reactos.org/svn/reactos?rev=74630=rev Log: [WIN32K] -Simplify the parameters passed to GetFontPenalty and FindBestFontFromList. Make SubstituteFontRecurse update a LOGFONT and get rid of some needless

[ros-diffs] [gadamopoulos] 74613: [WIN32K] -Reduce the ridiculous number of string allocations done by FindBestFontFromList and GetFontPenalty. CORE-13274

2017-05-21 Thread gadamopoulos
Author: gadamopoulos Date: Sun May 21 16:47:07 2017 New Revision: 74613 URL: http://svn.reactos.org/svn/reactos?rev=74613=rev Log: [WIN32K] -Reduce the ridiculous number of string allocations done by FindBestFontFromList and GetFontPenalty. CORE-13274 Modified: trunk/reactos/win32ss/gdi

[ros-diffs] [gadamopoulos] 74593: [UXTHEME] -Use and RTL handle table for HTHEME handles. In this way we can ensure that a value we take is valid even if it is non NULL. We can also detect leaks.

2017-05-19 Thread gadamopoulos
Author: gadamopoulos Date: Fri May 19 11:02:44 2017 New Revision: 74593 URL: http://svn.reactos.org/svn/reactos?rev=74593=rev Log: [UXTHEME] -Use and RTL handle table for HTHEME handles. In this way we can ensure that a value we take is valid even if it is non NULL. We can also detect leaks

[ros-diffs] [gadamopoulos] 74592: [UXTHEME] Greatly reduce the number of times we open the theme data for the non client area. - Implement OTD_NONCLIENT for OpenThemeDataEx and OpenThemeDataFromFile.

2017-05-19 Thread gadamopoulos
Author: gadamopoulos Date: Fri May 19 10:01:50 2017 New Revision: 74592 URL: http://svn.reactos.org/svn/reactos?rev=74592=rev Log: [UXTHEME] Greatly reduce the number of times we open the theme data for the non client area. - Implement OTD_NONCLIENT for OpenThemeDataEx and OpenThemeDataFromFile

[ros-diffs] [gadamopoulos] 74587: [UXTHEME] -Rename WND_CONTEXT to WND_DATA to avoid confusion with the DRAW_CONTEXT. The WND_DATA is information valid throughout the life of a window and DRAW_CONTEXT

2017-05-19 Thread gadamopoulos
Author: gadamopoulos Date: Fri May 19 08:45:49 2017 New Revision: 74587 URL: http://svn.reactos.org/svn/reactos?rev=74587=rev Log: [UXTHEME] -Rename WND_CONTEXT to WND_DATA to avoid confusion with the DRAW_CONTEXT. The WND_DATA is information valid throughout the life of a window

[ros-diffs] [gadamopoulos] 74580: [UXTHEME] -Remove a debug print that was never meant to be committed.

2017-05-18 Thread gadamopoulos
Author: gadamopoulos Date: Thu May 18 17:53:33 2017 New Revision: 74580 URL: http://svn.reactos.org/svn/reactos?rev=74580=rev Log: [UXTHEME] -Remove a debug print that was never meant to be committed. Modified: trunk/reactos/dll/win32/uxtheme/draw.c Modified: trunk/reactos/dll/win32/uxtheme

[ros-diffs] [gadamopoulos] 74579: [UXTHEME] -Apply some suggestions by Thomas.

2017-05-18 Thread gadamopoulos
Author: gadamopoulos Date: Thu May 18 17:15:22 2017 New Revision: 74579 URL: http://svn.reactos.org/svn/reactos?rev=74579=rev Log: [UXTHEME] -Apply some suggestions by Thomas. Modified: trunk/reactos/dll/win32/uxtheme/nonclient.c Modified: trunk/reactos/dll/win32/uxtheme/nonclient.c URL

[ros-diffs] [gadamopoulos] 74552: [UXTHEME] -ThemeDrawCaptionText: Try to avoid a heap allocation when getting the window caption.

2017-05-15 Thread gadamopoulos
Author: gadamopoulos Date: Mon May 15 16:05:14 2017 New Revision: 74552 URL: http://svn.reactos.org/svn/reactos?rev=74552=rev Log: [UXTHEME] -ThemeDrawCaptionText: Try to avoid a heap allocation when getting the window caption. Modified: trunk/reactos/dll/win32/uxtheme/nonclient.c Modified

[ros-diffs] [gadamopoulos] 74551: [UXTHEME] -Simplify ThemeDrawCaptionText.

2017-05-15 Thread gadamopoulos
Author: gadamopoulos Date: Mon May 15 15:34:43 2017 New Revision: 74551 URL: http://svn.reactos.org/svn/reactos?rev=74551=rev Log: [UXTHEME] -Simplify ThemeDrawCaptionText. Modified: trunk/reactos/dll/win32/uxtheme/nonclient.c Modified: trunk/reactos/dll/win32/uxtheme/nonclient.c URL: http

[ros-diffs] [gadamopoulos] 74522: [UXTHEME] -Fix the tab background pattern hack when the background pattern is smaller than the window that we are trying to paint. CORE-13147, CORE-13192. There is st

2017-05-12 Thread gadamopoulos
Author: gadamopoulos Date: Fri May 12 12:44:49 2017 New Revision: 74522 URL: http://svn.reactos.org/svn/reactos?rev=74522=rev Log: [UXTHEME] -Fix the tab background pattern hack when the background pattern is smaller than the window that we are trying to paint. CORE-13147, CORE-13192

[ros-diffs] [gadamopoulos] 74517: [SHELL32_APITEST] -Add tests for Control_RunDLLW.

2017-05-10 Thread gadamopoulos
Author: gadamopoulos Date: Wed May 10 10:06:02 2017 New Revision: 74517 URL: http://svn.reactos.org/svn/reactos?rev=74517=rev Log: [SHELL32_APITEST] -Add tests for Control_RunDLLW. Added: trunk/rostests/apitests/shell32/Control_RunDLLW.cpp (with props) trunk/rostests/apitests/shell32

  1   2   3   4   5   6   7   8   9   10   >