[ros-diffs] [tfaber] 68218: [SHELL32] - Finally give up on that assert. It's not easily fixable CORE-9839 or CORE-9844 or CORE-9845 or whatever

2015-06-20 Thread tfaber
Author: tfaber Date: Sun Jun 21 05:21:30 2015 New Revision: 68218 URL: http://svn.reactos.org/svn/reactos?rev=68218&view=rev Log: [SHELL32] - Finally give up on that assert. It's not easily fixable CORE-9839 or CORE-9844 or CORE-9845 or whatever Modified: trunk/reactos/dll/win3

[ros-diffs] [tfaber] 68217: [SHELL32] - Test your code, Arch! Fix another assertion failure. CORE-9845 #resolve

2015-06-20 Thread tfaber
Author: tfaber Date: Sun Jun 21 04:56:38 2015 New Revision: 68217 URL: http://svn.reactos.org/svn/reactos?rev=68217&view=rev Log: [SHELL32] - Test your code, Arch! Fix another assertion failure. CORE-9845 #resolve Modified: trunk/reactos/include/reactos/shellutils.h Modified: trunk/rea

[ros-diffs] [tfaber] 68215: [SHELL32] - Fix assertion failure in 2nd stage by setting s_IsTerminated when an instance does not yet exist. - Rename CComCreatorSingleton to CComCreatorCentralInstance si

2015-06-20 Thread tfaber
Author: tfaber Date: Sat Jun 20 21:46:16 2015 New Revision: 68215 URL: http://svn.reactos.org/svn/reactos?rev=68215&view=rev Log: [SHELL32] - Fix assertion failure in 2nd stage by setting s_IsTerminated when an instance does not yet exist. - Rename CComCreatorSingleto

[ros-diffs] [tfaber] 68212: [SHELL32] - Also make My Computer a singleton, as shown by the CMyComputer test. With r68210 and this commit, SHFileOperation on a large number of files is approximately 3

2015-06-20 Thread tfaber
Author: tfaber Date: Sat Jun 20 17:52:28 2015 New Revision: 68212 URL: http://svn.reactos.org/svn/reactos?rev=68212&view=rev Log: [SHELL32] - Also make My Computer a singleton, as shown by the CMyComputer test. With r68210 and this commit, SHFileOperation on a large number of file

[ros-diffs] [tfaber] 68211: [GRML] - Fix build

2015-06-20 Thread tfaber
Author: tfaber Date: Sat Jun 20 17:04:27 2015 New Revision: 68211 URL: http://svn.reactos.org/svn/reactos?rev=68211&view=rev Log: [GRML] - Fix build Modified: trunk/reactos/include/reactos/shellutils.h Modified: trunk/reactos/include/reactos/shellutils.h URL: http://svn.reactos.org

[ros-diffs] [tfaber] 68210: [SHELL32] - Introduce a CComCreatorSingleton class and use it for CDesktopFolder. Multiple calls to SHGetDesktopFolder will now return the same instance, which provides a m

2015-06-20 Thread tfaber
Author: tfaber Date: Sat Jun 20 16:54:52 2015 New Revision: 68210 URL: http://svn.reactos.org/svn/reactos?rev=68210&view=rev Log: [SHELL32] - Introduce a CComCreatorSingleton class and use it for CDesktopFolder. Multiple calls to SHGetDesktopFolder will now return the same instance, w

[ros-diffs] [tfaber] 68209: [SHELL32_APITEST] - Add a test for CLSID_MyComputer that shows this folder object is also cached. CORE-9839

2015-06-20 Thread tfaber
Author: tfaber Date: Sat Jun 20 16:28:38 2015 New Revision: 68209 URL: http://svn.reactos.org/svn/reactos?rev=68209&view=rev Log: [SHELL32_APITEST] - Add a test for CLSID_MyComputer that shows this folder object is also cached. CORE-9839 Added: trunk/rostests/apitests/shell32/CMyComputer

[ros-diffs] [tfaber] 68208: [SHELL32] - Addendum to r68202 CORE-9839

2015-06-20 Thread tfaber
Author: tfaber Date: Sat Jun 20 15:23:25 2015 New Revision: 68208 URL: http://svn.reactos.org/svn/reactos?rev=68208&view=rev Log: [SHELL32] - Addendum to r68202 CORE-9839 Modified: trunk/reactos/dll/win32/shell32/folders/CDesktopFolder.cpp Modified: trunk/reactos/dll/win32/shell32/fol

[ros-diffs] [tfaber] 68203: [ATL] - Implement CComClassFactorySingleton

2015-06-20 Thread tfaber
Author: tfaber Date: Sat Jun 20 12:08:13 2015 New Revision: 68203 URL: http://svn.reactos.org/svn/reactos?rev=68203&view=rev Log: [ATL] - Implement CComClassFactorySingleton Modified: trunk/reactos/lib/atl/atlcom.h Modified: trunk/reactos/lib/atl/atlcom.h URL: http://svn.reactos.org

[ros-diffs] [tfaber] 68202: [SHELL32] - Separate CDesktopFolder's IDropTarget out into its own class (since each caller needs its own instance) CORE-9839

2015-06-20 Thread tfaber
Author: tfaber Date: Sat Jun 20 10:26:22 2015 New Revision: 68202 URL: http://svn.reactos.org/svn/reactos?rev=68202&view=rev Log: [SHELL32] - Separate CDesktopFolder's IDropTarget out into its own class (since each caller needs its own instance) CORE-9839 Modified: trunk/reactos/

[ros-diffs] [tfaber] 68201: [ATL] - Fix compilation when UNICODE is not defined CORE-9258 #resolve

2015-06-20 Thread tfaber
Author: tfaber Date: Sat Jun 20 09:22:55 2015 New Revision: 68201 URL: http://svn.reactos.org/svn/reactos?rev=68201&view=rev Log: [ATL] - Fix compilation when UNICODE is not defined CORE-9258 #resolve Modified: trunk/reactos/lib/atl/atlbase.h trunk/reactos/lib/atl/statreg.h Modi

[ros-diffs] [tfaber] 68200: [SHELL32_APITEST] - Add a test showing that repeated calls to SHGetDesktopFolder return pointers to the same object, and that its CreateViewObject method instead creates ne

2015-06-20 Thread tfaber
Author: tfaber Date: Sat Jun 20 09:07:29 2015 New Revision: 68200 URL: http://svn.reactos.org/svn/reactos?rev=68200&view=rev Log: [SHELL32_APITEST] - Add a test showing that repeated calls to SHGetDesktopFolder return pointers to the same object, and that its CreateViewObject method ins

[ros-diffs] [tfaber] 68199: [APITESTS] - Make CUnknownBase constructor parameters optional

2015-06-20 Thread tfaber
Author: tfaber Date: Sat Jun 20 08:51:07 2015 New Revision: 68199 URL: http://svn.reactos.org/svn/reactos?rev=68199&view=rev Log: [APITESTS] - Make CUnknownBase constructor parameters optional Modified: trunk/rostests/apitests/include/unknownbase.h Modified: trunk/rostests/apitests/inc

[ros-diffs] [tfaber] 68196: [ADVAPI32] - Use a separate heap allocation for the thread parameters to ScServiceMainStub, since the thread can live longer than the ACTIVE_SERVICE structure CORE-9235

2015-06-19 Thread tfaber
Author: tfaber Date: Fri Jun 19 18:16:27 2015 New Revision: 68196 URL: http://svn.reactos.org/svn/reactos?rev=68196&view=rev Log: [ADVAPI32] - Use a separate heap allocation for the thread parameters to ScServiceMainStub, since the thread can live longer than the ACTIVE_SERVICE structure

[ros-diffs] [tfaber] 68190: [WIN32K:NTUSER] - Restructure co_UserProcessHotKeys to correctly process modifier-only hotkeys. Fixes start menu opening after Win+X shortcuts, and probably several other h

2015-06-18 Thread tfaber
Author: tfaber Date: Thu Jun 18 15:45:32 2015 New Revision: 68190 URL: http://svn.reactos.org/svn/reactos?rev=68190&view=rev Log: [WIN32K:NTUSER] - Restructure co_UserProcessHotKeys to correctly process modifier-only hotkeys. Fixes start menu opening after Win+X shortcuts, and probably sev

[ros-diffs] [tfaber] 68189: [USER32_APITEST] - Arch, will you stop only testing your code with MSVC?!

2015-06-18 Thread tfaber
Author: tfaber Date: Thu Jun 18 14:02:55 2015 New Revision: 68189 URL: http://svn.reactos.org/svn/reactos?rev=68189&view=rev Log: [USER32_APITEST] - Arch, will you stop only testing your code with MSVC?! Modified: trunk/rostests/apitests/user32/RegisterHotKey.c Modified: trunk/rost

[ros-diffs] [tfaber] 68188: [USER32_APITEST] - Fail if we get too many WM_HOTKEY messages CORE-9728

2015-06-18 Thread tfaber
Author: tfaber Date: Thu Jun 18 13:59:51 2015 New Revision: 68188 URL: http://svn.reactos.org/svn/reactos?rev=68188&view=rev Log: [USER32_APITEST] - Fail if we get too many WM_HOTKEY messages CORE-9728 Modified: trunk/rostests/apitests/user32/RegisterHotKey.c Modified: trunk/rost

[ros-diffs] [tfaber] 68187: [INCLUDE] - Fix undocshell.h build without UNICODE defined

2015-06-18 Thread tfaber
Author: tfaber Date: Thu Jun 18 13:45:17 2015 New Revision: 68187 URL: http://svn.reactos.org/svn/reactos?rev=68187&view=rev Log: [INCLUDE] - Fix undocshell.h build without UNICODE defined Modified: trunk/reactos/include/reactos/undocshell.h Modified: trunk/reactos/include/rea

[ros-diffs] [tfaber] 68186: [USER32_APITEST] - Add a simple test for RegisterHotKey with regular vs modifier-only hotkeys CORE-9728

2015-06-18 Thread tfaber
Author: tfaber Date: Thu Jun 18 13:41:52 2015 New Revision: 68186 URL: http://svn.reactos.org/svn/reactos?rev=68186&view=rev Log: [USER32_APITEST] - Add a simple test for RegisterHotKey with regular vs modifier-only hotkeys CORE-9728 Added: trunk/rostests/apitests/user32/RegisterHotK

[ros-diffs] [tfaber] 68175: [FASTFAT] - Set the correct length in FsdGetFsVolumeInformation/FsdGetFsAttributeInformation, and write back partial data when returning STATUS_BUFFER_OVERFLOW - Replace un

2015-06-17 Thread tfaber
Author: tfaber Date: Wed Jun 17 19:19:39 2015 New Revision: 68175 URL: http://svn.reactos.org/svn/reactos?rev=68175&view=rev Log: [FASTFAT] - Set the correct length in FsdGetFsVolumeInformation/FsdGetFsAttributeInformation, and write back partial data when returning STATUS_BUFFER_OVER

[ros-diffs] [tfaber] 68166: [NTDLL_APITEST] - Also test FileFsAttributeInformation in NtQueryVolumeInformationFile

2015-06-16 Thread tfaber
Author: tfaber Date: Wed Jun 17 06:54:17 2015 New Revision: 68166 URL: http://svn.reactos.org/svn/reactos?rev=68166&view=rev Log: [NTDLL_APITEST] - Also test FileFsAttributeInformation in NtQueryVolumeInformationFile Modified: trunk/rostests/apitests/ntdll/NtQueryVolumeInformationFi

[ros-diffs] [tfaber] 68161: [NTDLL_APITEST] - Fix GCC build

2015-06-16 Thread tfaber
Author: tfaber Date: Tue Jun 16 11:40:51 2015 New Revision: 68161 URL: http://svn.reactos.org/svn/reactos?rev=68161&view=rev Log: [NTDLL_APITEST] - Fix GCC build Modified: trunk/rostests/apitests/ntdll/NtQueryVolumeInformationFile.c Modified: trunk/rostests/apitests/n

[ros-diffs] [tfaber] 68160: [NTDLL_APITEST] - Test FileFsVolumeInformation in NtQueryVolumeInformationFile test CORE-9820

2015-06-16 Thread tfaber
Author: tfaber Date: Tue Jun 16 11:33:35 2015 New Revision: 68160 URL: http://svn.reactos.org/svn/reactos?rev=68160&view=rev Log: [NTDLL_APITEST] - Test FileFsVolumeInformation in NtQueryVolumeInformationFile test CORE-9820 Modified: trunk/rostests/apitests/n

[ros-diffs] [tfaber] 68152: [NTOS:CC] - Properly stub CcCanIWrite, CcDeferWrite, CcFastCopyRead, CcFastCopyWrite CORE-9624

2015-06-15 Thread tfaber
Author: tfaber Date: Mon Jun 15 18:44:08 2015 New Revision: 68152 URL: http://svn.reactos.org/svn/reactos?rev=68152&view=rev Log: [NTOS:CC] - Properly stub CcCanIWrite, CcDeferWrite, CcFastCopyRead, CcFastCopyWrite CORE-9624 Modified: trunk/reactos/ntoskrnl/cc/copy.c Modified: trunk/rea

[ros-diffs] [tfaber] 68133: [MC] - Add missing status codes STATUS_SMARTCARD_CERT_EXPIRED through STATUS_NO_S4U_PROT_SUPPORT. CORE-8373

2015-06-14 Thread tfaber
Author: tfaber Date: Sun Jun 14 11:19:02 2015 New Revision: 68133 URL: http://svn.reactos.org/svn/reactos?rev=68133&view=rev Log: [MC] - Add missing status codes STATUS_SMARTCARD_CERT_EXPIRED through STATUS_NO_S4U_PROT_SUPPORT. CORE-8373 Modified: trunk/reactos/include/reacto

[ros-diffs] [tfaber] 68132: [MSAFD] - Fix error mapping for STATUS_INVALID_CONNECTION CORE-9810 CORE-9807 #resolve

2015-06-14 Thread tfaber
Author: tfaber Date: Sun Jun 14 08:03:15 2015 New Revision: 68132 URL: http://svn.reactos.org/svn/reactos?rev=68132&view=rev Log: [MSAFD] - Fix error mapping for STATUS_INVALID_CONNECTION CORE-9810 CORE-9807 #resolve Modified: trunk/reactos/dll/win32/msafd/misc/dllmain.c Modified: t

[ros-diffs] [tfaber] 68131: [AFD] - Immediately finish a zero-length request in TdiSendDatagram. This may not be completely correct (should possibly get forwarded to tcpip instead) but is better than

2015-06-14 Thread tfaber
Author: tfaber Date: Sun Jun 14 07:58:58 2015 New Revision: 68131 URL: http://svn.reactos.org/svn/reactos?rev=68131&view=rev Log: [AFD] - Immediately finish a zero-length request in TdiSendDatagram. This may not be completely correct (should possibly get forwarded to tcpip instead) bu

[ros-diffs] [tfaber] 68130: [AFD] - Don't leave the IRP queued if TdiSendDatagram does not perform its downcall. Complete it instead. CORE-9810

2015-06-14 Thread tfaber
Author: tfaber Date: Sun Jun 14 07:54:19 2015 New Revision: 68130 URL: http://svn.reactos.org/svn/reactos?rev=68130&view=rev Log: [AFD] - Don't leave the IRP queued if TdiSendDatagram does not perform its downcall. Complete it instead. CORE-9810 Modified: trunk/reactos/drivers/ne

[ros-diffs] [tfaber] 68129: [AFD] - Fail sends on sockets that are not connected in AfdConnectedSocketWriteData CORE-9810

2015-06-14 Thread tfaber
Author: tfaber Date: Sun Jun 14 07:48:28 2015 New Revision: 68129 URL: http://svn.reactos.org/svn/reactos?rev=68129&view=rev Log: [AFD] - Fail sends on sockets that are not connected in AfdConnectedSocketWriteData CORE-9810 Modified: trunk/reactos/drivers/network/afd/afd/write.c Modi

[ros-diffs] [tfaber] 68128: [PSDK] - Add STATUS_INVALID_SIGNATURE through STATUS_PROTOCOL_NOT_SUPPORTED

2015-06-14 Thread tfaber
Author: tfaber Date: Sun Jun 14 07:44:06 2015 New Revision: 68128 URL: http://svn.reactos.org/svn/reactos?rev=68128&view=rev Log: [PSDK] - Add STATUS_INVALID_SIGNATURE through STATUS_PROTOCOL_NOT_SUPPORTED Modified: trunk/reactos/include/psdk/ntstatus.h trunk/reactos/include/reacto

[ros-diffs] [tfaber] 68121: [AFD] - Probe for read access only in TdiSend/TdiSendDatagram CORE-9807 resolve

2015-06-13 Thread tfaber
Author: tfaber Date: Sat Jun 13 12:30:33 2015 New Revision: 68121 URL: http://svn.reactos.org/svn/reactos?rev=68121&view=rev Log: [AFD] - Probe for read access only in TdiSend/TdiSendDatagram CORE-9807 resolve Modified: trunk/reactos/drivers/network/afd/afd/tdi.c Modified: trunk/rea

[ros-diffs] [tfaber] 68120: [WS2_32_APITEST] - Add a test for send/sendto with a read-only buffer CORE-9807

2015-06-13 Thread tfaber
Author: tfaber Date: Sat Jun 13 12:29:07 2015 New Revision: 68120 URL: http://svn.reactos.org/svn/reactos?rev=68120&view=rev Log: [WS2_32_APITEST] - Add a test for send/sendto with a read-only buffer CORE-9807 Added: trunk/rostests/apitests/ws2_32/send.c (with props) Modified: t

[ros-diffs] [tfaber] 67907: [WIN32K:NTUSER] - Use UserRefObjectCo in IntNotifyWinEvent to avoid a reference leak in case the call-out does not return - Sanitize list walk

2015-05-25 Thread tfaber
Author: tfaber Date: Mon May 25 15:28:06 2015 New Revision: 67907 URL: http://svn.reactos.org/svn/reactos?rev=67907&view=rev Log: [WIN32K:NTUSER] - Use UserRefObjectCo in IntNotifyWinEvent to avoid a reference leak in case the call-out does not return - Sanitize list walk Modified: t

[ros-diffs] [tfaber] 67906: [RTL][NTOSKRNL] - Don't cast CONTAINING_RECORD

2015-05-25 Thread tfaber
Author: tfaber Date: Mon May 25 15:04:09 2015 New Revision: 67906 URL: http://svn.reactos.org/svn/reactos?rev=67906&view=rev Log: [RTL][NTOSKRNL] - Don't cast CONTAINING_RECORD Modified: trunk/reactos/lib/rtl/generictable.c trunk/reactos/ntoskrnl/ex/sysinfo.c trunk/reactos

[ros-diffs] [tfaber] 67850: [ADVAPI32] - Do not fail in RegQueryInfoKeyW if NtQuerySecurityObject fails, as shown by the test CORE-9719

2015-05-22 Thread tfaber
Author: tfaber Date: Fri May 22 16:19:23 2015 New Revision: 67850 URL: http://svn.reactos.org/svn/reactos?rev=67850&view=rev Log: [ADVAPI32] - Do not fail in RegQueryInfoKeyW if NtQuerySecurityObject fails, as shown by the test CORE-9719 Modified: trunk/reactos/dll/win32/advapi32/reg/r

[ros-diffs] [tfaber] 67849: [ADVAPI32_APITEST] - Fix test failures on Win 2003: unlike on Win7, write rights don't imply read CORE-9719

2015-05-22 Thread tfaber
Author: tfaber Date: Fri May 22 16:06:58 2015 New Revision: 67849 URL: http://svn.reactos.org/svn/reactos?rev=67849&view=rev Log: [ADVAPI32_APITEST] - Fix test failures on Win 2003: unlike on Win7, write rights don't imply read CORE-9719 Modified: trunk/rostests/apitests

[ros-diffs] [tfaber] 67848: [ADVAPI32_APITEST] - Add a test for calling RegQueryInfoKey with different access rights CORE-9719

2015-05-22 Thread tfaber
Author: tfaber Date: Fri May 22 15:47:02 2015 New Revision: 67848 URL: http://svn.reactos.org/svn/reactos?rev=67848&view=rev Log: [ADVAPI32_APITEST] - Add a test for calling RegQueryInfoKey with different access rights CORE-9719 Added: trunk/rostests/apitests/advapi32/RegQueryInfoK

[ros-diffs] [tfaber] 67843: [ADVAPI32] - Add a debug print in unusual failure case of RegQueryInfoKeyW CORE-9719

2015-05-21 Thread tfaber
Author: tfaber Date: Thu May 21 22:16:39 2015 New Revision: 67843 URL: http://svn.reactos.org/svn/reactos?rev=67843&view=rev Log: [ADVAPI32] - Add a debug print in unusual failure case of RegQueryInfoKeyW CORE-9719 Modified: trunk/reactos/dll/win32/advapi32/reg/reg.c Modified: trunk/rea

[ros-diffs] [tfaber] 67712: [ADVAPI32_WINETEST] - Replace test_reg_query_info with the upstream version as promised in r67424. CORE-6976

2015-05-14 Thread tfaber
Author: tfaber Date: Thu May 14 13:08:07 2015 New Revision: 67712 URL: http://svn.reactos.org/svn/reactos?rev=67712&view=rev Log: [ADVAPI32_WINETEST] - Replace test_reg_query_info with the upstream version as promised in r67424. CORE-6976 Modified: trunk/rostests/winetests/adva

[ros-diffs] [tfaber] 67711: [ADVAPI32] - Add parameter check to RegQueryInfoKeyA CORE-6976

2015-05-14 Thread tfaber
Author: tfaber Date: Thu May 14 13:02:49 2015 New Revision: 67711 URL: http://svn.reactos.org/svn/reactos?rev=67711&view=rev Log: [ADVAPI32] - Add parameter check to RegQueryInfoKeyA CORE-6976 Modified: trunk/reactos/dll/win32/advapi32/reg/reg.c Modified: trunk/reactos/dll/win32/adva

[ros-diffs] [tfaber] 67666: [PSDK] - Add __field_bcount_full - Add a stub definition for __deref_out_range

2015-05-11 Thread tfaber
Author: tfaber Date: Mon May 11 16:15:18 2015 New Revision: 67666 URL: http://svn.reactos.org/svn/reactos?rev=67666&view=rev Log: [PSDK] - Add __field_bcount_full - Add a stub definition for __deref_out_range Modified: trunk/reactos/include/psdk/sal_old.h trunk/reactos/include/

[ros-diffs] [tfaber] 67664: [DDK] - Add NTSTRSAFE_UNICODE_STRING_MAX_CCH

2015-05-11 Thread tfaber
Author: tfaber Date: Mon May 11 14:09:02 2015 New Revision: 67664 URL: http://svn.reactos.org/svn/reactos?rev=67664&view=rev Log: [DDK] - Add NTSTRSAFE_UNICODE_STRING_MAX_CCH Modified: trunk/reactos/include/ddk/ntstrsafe.h Modified: trunk/reactos/include/ddk/ntstrsafe.h URL:

[ros-diffs] [tfaber] 67653: [CRT] - Add missing __INTRIN_INLINE for x64 intrinsics

2015-05-11 Thread tfaber
Author: tfaber Date: Mon May 11 12:27:54 2015 New Revision: 67653 URL: http://svn.reactos.org/svn/reactos?rev=67653&view=rev Log: [CRT] - Add missing __INTRIN_INLINE for x64 intrinsics Modified: trunk/reactos/include/crt/mingw32/intrin_x86.h Modified: trunk/reactos/include/crt/min

[ros-diffs] [tfaber] 67652: [CRT] - Fix some x64 GCC intrinsics

2015-05-11 Thread tfaber
Author: tfaber Date: Mon May 11 12:10:19 2015 New Revision: 67652 URL: http://svn.reactos.org/svn/reactos?rev=67652&view=rev Log: [CRT] - Fix some x64 GCC intrinsics Modified: trunk/reactos/include/crt/mingw32/intrin_x86.h Modified: trunk/reactos/include/crt/mingw32/intrin_x86.h URL:

[ros-diffs] [tfaber] 67621: [CDFS] - Mark volumes as read-only. Patch by Barrett Karish. CORE-9655 #resolve

2015-05-10 Thread tfaber
Author: tfaber Date: Sun May 10 14:09:47 2015 New Revision: 67621 URL: http://svn.reactos.org/svn/reactos?rev=67621&view=rev Log: [CDFS] - Mark volumes as read-only. Patch by Barrett Karish. CORE-9655 #resolve Modified: trunk/reactos/drivers/filesystems/cdfs/volinfo.c Modified: t

[ros-diffs] [tfaber] 67608: [DDK] - Include from wdm.h to satisfy __WARNING_MEMORY_NOT_ACQUIRED. Patch by Mark Jansen. CORE-9657 #resolve

2015-05-09 Thread tfaber
Author: tfaber Date: Sat May 9 22:49:37 2015 New Revision: 67608 URL: http://svn.reactos.org/svn/reactos?rev=67608&view=rev Log: [DDK] - Include from wdm.h to satisfy __WARNING_MEMORY_NOT_ACQUIRED. Patch by Mark Jansen. CORE-9657 #resolve Modified: trunk/reactos/include/ddk/w

[ros-diffs] [tfaber] 67607: [CMAKE] - Enable C4189 (local variable initialized but not referenced) on MSVC builds and make it an error. CORE-9676 #resolve

2015-05-09 Thread tfaber
Author: tfaber Date: Sat May 9 22:44:52 2015 New Revision: 67607 URL: http://svn.reactos.org/svn/reactos?rev=67607&view=rev Log: [CMAKE] - Enable C4189 (local variable initialized but not referenced) on MSVC builds and make it an error. CORE-9676 #resolve Modified: trunk/reactos/c

[ros-diffs] [tfaber] 67555: [C++] - Add nothrow versions of new/delete operators - Add - Fix a TODO and add missing dependency to header

2015-05-04 Thread tfaber
Author: tfaber Date: Tue May 5 02:44:17 2015 New Revision: 67555 URL: http://svn.reactos.org/svn/reactos?rev=67555&view=rev Log: [C++] - Add nothrow versions of new/delete operators - Add - Fix a TODO and add missing dependency to header Added: trunk/reactos/include/c++/cassert (

[ros-diffs] [tfaber] 67503: [NPFS] - Correctly check for write quota in NpCommonWrite. Should fix test regressions after enabling fast I/O.

2015-05-01 Thread tfaber
Author: tfaber Date: Fri May 1 19:40:04 2015 New Revision: 67503 URL: http://svn.reactos.org/svn/reactos?rev=67503&view=rev Log: [NPFS] - Correctly check for write quota in NpCommonWrite. Should fix test regressions after enabling fast I/O. Modified: trunk/reactos/drivers/filesystems/

[ros-diffs] [tfaber] 67497: [BLUE] - Arch, learn how to properly revert things?

2015-05-01 Thread tfaber
Author: tfaber Date: Fri May 1 13:58:37 2015 New Revision: 67497 URL: http://svn.reactos.org/svn/reactos?rev=67497&view=rev Log: [BLUE] - Arch, learn how to properly revert things? Modified: trunk/reactos/drivers/setup/blue/blue.c Modified: trunk/reactos/drivers/setup/blue/blue.c

[ros-diffs] [tfaber] 67496: [BLUE][CDFS] - Arch, don't assume the driver you see in the backtrace is one that needs fixing. CDFS is the one who's a file system driver here...

2015-05-01 Thread tfaber
Author: tfaber Date: Fri May 1 13:56:37 2015 New Revision: 67496 URL: http://svn.reactos.org/svn/reactos?rev=67496&view=rev Log: [BLUE][CDFS] - Arch, don't assume the driver you see in the backtrace is one that needs fixing. CDFS is the one who's a file system driver her

[ros-diffs] [tfaber] 67495: [BLUE] - FastIoDispatch is not optional for file system drivers!

2015-05-01 Thread tfaber
Author: tfaber Date: Fri May 1 13:46:08 2015 New Revision: 67495 URL: http://svn.reactos.org/svn/reactos?rev=67495&view=rev Log: [BLUE] - FastIoDispatch is not optional for file system drivers! Modified: trunk/reactos/drivers/setup/blue/blue.c Modified: trunk/reactos/drivers/setup/

[ros-diffs] [tfaber] 67494: [NTOS:IO] - Implement Fast I/O support in NtReadFile/NtWriteFile CORE-9624

2015-05-01 Thread tfaber
Author: tfaber Date: Fri May 1 13:20:26 2015 New Revision: 67494 URL: http://svn.reactos.org/svn/reactos?rev=67494&view=rev Log: [NTOS:IO] - Implement Fast I/O support in NtReadFile/NtWriteFile CORE-9624 Modified: trunk/reactos/ntoskrnl/io/iomgr/iofunc.c Modified: trunk/reactos/ntoskrn

[ros-diffs] [tfaber] 67493: [KMTESTS:IO] - Also test write operations in IoReadWrite - Add some nonzero success statuses CORE-9624

2015-05-01 Thread tfaber
Author: tfaber Date: Fri May 1 12:50:12 2015 New Revision: 67493 URL: http://svn.reactos.org/svn/reactos?rev=67493&view=rev Log: [KMTESTS:IO] - Also test write operations in IoReadWrite - Add some nonzero success statuses CORE-9624 Modified: trunk/rostests/kmtests/ntos_io/IoReadWri

[ros-diffs] [tfaber] 67491: [NTOS:IO] - Free the correct event pointer when out of memory in IopDeviceFsIoControl

2015-05-01 Thread tfaber
Author: tfaber Date: Fri May 1 12:00:50 2015 New Revision: 67491 URL: http://svn.reactos.org/svn/reactos?rev=67491&view=rev Log: [NTOS:IO] - Free the correct event pointer when out of memory in IopDeviceFsIoControl Modified: trunk/reactos/ntoskrnl/io/iomgr/iofunc.c Modified: trunk/rea

[ros-diffs] [tfaber] 67490: [NTOS:IO] - Don't leak event object reference when out of memory in NtReadFile/NtWriteFile

2015-05-01 Thread tfaber
Author: tfaber Date: Fri May 1 11:57:51 2015 New Revision: 67490 URL: http://svn.reactos.org/svn/reactos?rev=67490&view=rev Log: [NTOS:IO] - Don't leak event object reference when out of memory in NtReadFile/NtWriteFile Modified: trunk/reactos/ntoskrnl/io/iomgr/iofunc.c Modifi

[ros-diffs] [tfaber] 67489: [NTOS:IO] - IopCompleteRequest: in case of an exception, fail the IRP as shown by kmtest:IoReadWrite CORE-9624

2015-05-01 Thread tfaber
Author: tfaber Date: Fri May 1 11:52:32 2015 New Revision: 67489 URL: http://svn.reactos.org/svn/reactos?rev=67489&view=rev Log: [NTOS:IO] - IopCompleteRequest: in case of an exception, fail the IRP as shown by kmtest:IoReadWrite CORE-9624 Modified: trunk/reactos/ntoskrnl/io/iomgr/i

[ros-diffs] [tfaber] 67488: [KMTESTS:IO] - Fix GCC build

2015-05-01 Thread tfaber
Author: tfaber Date: Fri May 1 11:07:40 2015 New Revision: 67488 URL: http://svn.reactos.org/svn/reactos?rev=67488&view=rev Log: [KMTESTS:IO] - Fix GCC build Modified: trunk/rostests/kmtests/ntos_io/IoReadWrite_drv.c Modified: trunk/rostests/kmtests/ntos_io/IoReadWrite_drv.c URL:

[ros-diffs] [tfaber] 67487: [KMTESTS:IO] - Add a test for the interaction between NtReadFile and a file system driver CORE-9624

2015-05-01 Thread tfaber
Author: tfaber Date: Fri May 1 11:03:21 2015 New Revision: 67487 URL: http://svn.reactos.org/svn/reactos?rev=67487&view=rev Log: [KMTESTS:IO] - Add a test for the interaction between NtReadFile and a file system driver CORE-9624 Added: trunk/rostests/kmtests/ntos_io/IoReadWrite.h (

[ros-diffs] [tfaber] 67486: [KMTEST] - Add TESTENTRY_NO_READONLY_DEVICE and TESTENTRY_BUFFERED_IO_DEVICE flags for standalone drivers

2015-05-01 Thread tfaber
Author: tfaber Date: Fri May 1 10:52:37 2015 New Revision: 67486 URL: http://svn.reactos.org/svn/reactos?rev=67486&view=rev Log: [KMTEST] - Add TESTENTRY_NO_READONLY_DEVICE and TESTENTRY_BUFFERED_IO_DEVICE flags for standalone drivers Modified: trunk/rostests/kmtests/include/kmt_te

[ros-diffs] [tfaber] 67485: [NTOS:IO] - Add missing SEH around user buffer access in IopCompleteRequest - Remove a redundant condition CORE-9624

2015-05-01 Thread tfaber
Author: tfaber Date: Fri May 1 10:49:50 2015 New Revision: 67485 URL: http://svn.reactos.org/svn/reactos?rev=67485&view=rev Log: [NTOS:IO] - Add missing SEH around user buffer access in IopCompleteRequest - Remove a redundant condition CORE-9624 Modified: trunk/reactos/ntoskrnl/io/i

[ros-diffs] [tfaber] 67464: [NTOS:MM] - Consistently return STATUS_INVALID_IMAGE_PROTECT from PeFmtCreateSection if the PE signature is missing. Patch by V. CORE-9618 #resolve

2015-04-28 Thread tfaber
Author: tfaber Date: Tue Apr 28 07:07:57 2015 New Revision: 67464 URL: http://svn.reactos.org/svn/reactos?rev=67464&view=rev Log: [NTOS:MM] - Consistently return STATUS_INVALID_IMAGE_PROTECT from PeFmtCreateSection if the PE signature is missing. Patch by V. CORE-9618 #resolve Modi

[ros-diffs] [tfaber] 67431: [KERNEL32_VISTA] - Silence debug prints

2015-04-25 Thread tfaber
Author: tfaber Date: Sun Apr 26 06:10:03 2015 New Revision: 67431 URL: http://svn.reactos.org/svn/reactos?rev=67431&view=rev Log: [KERNEL32_VISTA] - Silence debug prints Modified: trunk/reactos/dll/win32/kernel32_vista/IdnToAscii.c trunk/reactos/dll/win32/kernel32_vista/IdnToUnico

[ros-diffs] [tfaber] 67430: [CMD] - Account for null terminator returned from RegQueryInfoKey CORE-6976

2015-04-25 Thread tfaber
Author: tfaber Date: Sun Apr 26 05:31:16 2015 New Revision: 67430 URL: http://svn.reactos.org/svn/reactos?rev=67430&view=rev Log: [CMD] - Account for null terminator returned from RegQueryInfoKey CORE-6976 Modified: trunk/reactos/base/shell/cmd/assoc.c Modified: trunk/reactos/base/shell

[ros-diffs] [tfaber] 67429: [DHCPCSVC] - Account for null terminator space after RegQueryInfoKey CORE-6976

2015-04-25 Thread tfaber
Author: tfaber Date: Sun Apr 26 04:52:05 2015 New Revision: 67429 URL: http://svn.reactos.org/svn/reactos?rev=67429&view=rev Log: [DHCPCSVC] - Account for null terminator space after RegQueryInfoKey CORE-6976 Modified: trunk/reactos/dll/win32/dhcpcsvc/dhcp/adapter.c Modified: trunk/rea

[ros-diffs] [tfaber] 67428: [USERENV] - Add space for terminator to values returned from RegQueryInfoKey CORE-6976

2015-04-25 Thread tfaber
Author: tfaber Date: Sun Apr 26 04:10:25 2015 New Revision: 67428 URL: http://svn.reactos.org/svn/reactos?rev=67428&view=rev Log: [USERENV] - Add space for terminator to values returned from RegQueryInfoKey CORE-6976 Modified: trunk/reactos/dll/win32/userenv/environment.c trunk/rea

[ros-diffs] [tfaber] 67426: [ADVAPI32] - Account for RegQueryInfoKey no longer including the null terminator in EnumHKCRKey/EnumHKCRValue CORE-6976

2015-04-25 Thread tfaber
Author: tfaber Date: Sat Apr 25 20:34:35 2015 New Revision: 67426 URL: http://svn.reactos.org/svn/reactos?rev=67426&view=rev Log: [ADVAPI32] - Account for RegQueryInfoKey no longer including the null terminator in EnumHKCRKey/EnumHKCRValue CORE-6976 Modified: trunk/reactos/dll/w

[ros-diffs] [tfaber] 67425: [ADVAPI32] Fix RegQueryInfoKey - Return a value in lpcClass if lpClass is NULL - Return correct error codes as shown by tests - Correctly name parameters -- most of these a

2015-04-25 Thread tfaber
Author: tfaber Date: Sat Apr 25 19:57:27 2015 New Revision: 67425 URL: http://svn.reactos.org/svn/reactos?rev=67425&view=rev Log: [ADVAPI32] Fix RegQueryInfoKey - Return a value in lpcClass if lpClass is NULL - Return correct error codes as shown by tests - Correctly name parameters -- mos

[ros-diffs] [tfaber] 67424: [ADVAPI32_WINETEST] - Add a test for RegQueryInfoKey. This serves as a placeholder to be replaced with the upstream version once accepted -- however it tests against Win 20

2015-04-25 Thread tfaber
Author: tfaber Date: Sat Apr 25 19:14:03 2015 New Revision: 67424 URL: http://svn.reactos.org/svn/reactos?rev=67424&view=rev Log: [ADVAPI32_WINETEST] - Add a test for RegQueryInfoKey. This serves as a placeholder to be replaced with the upstream version once accepted -- however it tests aga

[ros-diffs] [tfaber] 67415: [NTOS:CM] - Fix an ASSERT CORE-6976

2015-04-25 Thread tfaber
Author: tfaber Date: Sat Apr 25 15:18:37 2015 New Revision: 67415 URL: http://svn.reactos.org/svn/reactos?rev=67415&view=rev Log: [NTOS:CM] - Fix an ASSERT CORE-6976 Modified: trunk/reactos/ntoskrnl/config/cmapi.c Modified: trunk/reactos/ntoskrnl/config/cmapi.c URL: http://svn.reactos

[ros-diffs] [tfaber] 67414: [NTDLL_APITEST] - Add a test for NtQueryKey(KeyFullInformation) CORE-6976

2015-04-25 Thread tfaber
Author: tfaber Date: Sat Apr 25 15:05:36 2015 New Revision: 67414 URL: http://svn.reactos.org/svn/reactos?rev=67414&view=rev Log: [NTDLL_APITEST] - Add a test for NtQueryKey(KeyFullInformation) CORE-6976 Modified: trunk/rostests/apitests/ntdll/NtQueryKey.c Modified: trunk/rostests/apit

[ros-diffs] [tfaber] 67391: [GDI32_APITEST] - Add a test for NtGdiAddFontResourceW. This goes in gdi32_apitest until we fix w32knapi to be Testman-compatible (ROSTESTS-167). Patch by Víctor Martínez C

2015-04-25 Thread tfaber
Author: tfaber Date: Sat Apr 25 10:41:32 2015 New Revision: 67391 URL: http://svn.reactos.org/svn/reactos?rev=67391&view=rev Log: [GDI32_APITEST] - Add a test for NtGdiAddFontResourceW. This goes in gdi32_apitest until we fix w32knapi to be Testman-compatible (ROSTESTS-167). Patch by Ví

[ros-diffs] [tfaber] 67390: [NETSHELL] - Don't use the connection's name as the tab title in the Connection Properties dialog. Patch by Lee Schroeder. CORE-9603 #resolve

2015-04-25 Thread tfaber
Author: tfaber Date: Sat Apr 25 10:26:04 2015 New Revision: 67390 URL: http://svn.reactos.org/svn/reactos?rev=67390&view=rev Log: [NETSHELL] - Don't use the connection's name as the tab title in the Connection Properties dialog. Patch by Lee Schroeder. CORE-9603 #resolve Modif

[ros-diffs] [tfaber] 67382: [NTDLL_WINETEST] - Avoid printing an unterminated string in registry test. Powered by DPH. - Add a ROS hack to avoid a buffer overflow when one of our DPRINTs is returned b

2015-04-24 Thread tfaber
Author: tfaber Date: Fri Apr 24 17:37:31 2015 New Revision: 67382 URL: http://svn.reactos.org/svn/reactos?rev=67382&view=rev Log: [NTDLL_WINETEST] - Avoid printing an unterminated string in registry test. Powered by DPH. - Add a ROS hack to avoid a buffer overflow when one of our DPRINT

[ros-diffs] [tfaber] 67372: [MSI] - Apply Wine commit 55b678e1 (msi: Fix an invalid memory access (valgrind).) by Hans Leidekker

2015-04-23 Thread tfaber
Author: tfaber Date: Thu Apr 23 19:56:02 2015 New Revision: 67372 URL: http://svn.reactos.org/svn/reactos?rev=67372&view=rev Log: [MSI] - Apply Wine commit 55b678e1 (msi: Fix an invalid memory access (valgrind).) by Hans Leidekker Modified: trunk/reactos/dll/win32/msi/table.c Modi

[ros-diffs] [tfaber] 67370: [NTDLL_APITEST] - Gracefully handle failures in NtMapViewOfSection test. CORE-9189 - Correctly handle unterminated strings in NtQueryKey test. Powered by DPH.

2015-04-23 Thread tfaber
Author: tfaber Date: Thu Apr 23 18:41:08 2015 New Revision: 67370 URL: http://svn.reactos.org/svn/reactos?rev=67370&view=rev Log: [NTDLL_APITEST] - Gracefully handle failures in NtMapViewOfSection test. CORE-9189 - Correctly handle unterminated strings in NtQueryKey test. Powered by

[ros-diffs] [tfaber] 67366: [URLMON_WINETEST] - Re-enable skipped protocol tests ROSTESTS-165 #resolve

2015-04-23 Thread tfaber
Author: tfaber Date: Thu Apr 23 11:32:20 2015 New Revision: 67366 URL: http://svn.reactos.org/svn/reactos?rev=67366&view=rev Log: [URLMON_WINETEST] - Re-enable skipped protocol tests ROSTESTS-165 #resolve Modified: trunk/rostests/winetests/urlmon/protocol.c Modified: trunk/rost

[ros-diffs] [tfaber] 67365: [WININET] - Add back our Winsock initialization ROS-diff. Wine has only partially fixed this at this point. CORE-9588

2015-04-23 Thread tfaber
Author: tfaber Date: Thu Apr 23 10:57:11 2015 New Revision: 67365 URL: http://svn.reactos.org/svn/reactos?rev=67365&view=rev Log: [WININET] - Add back our Winsock initialization ROS-diff. Wine has only partially fixed this at this point. CORE-9588 Modified: trunk/reactos/dll/win32/win

[ros-diffs] [tfaber] 67353: [GDI32][WIN32K:NTGDI] - Correctly handle relative paths passed to AddFontResource*. - Fix the user->kernel interface between GdiAddFontResourceW and NtGdiAddFontResourceW P

2015-04-22 Thread tfaber
Author: tfaber Date: Wed Apr 22 20:24:29 2015 New Revision: 67353 URL: http://svn.reactos.org/svn/reactos?rev=67353&view=rev Log: [GDI32][WIN32K:NTGDI] - Correctly handle relative paths passed to AddFontResource*. - Fix the user->kernel interface between GdiAddFontResour

[ros-diffs] [tfaber] 67349: [NTDLL_APITEST] - Ensure 4-byte alignment for ATOM_BASIC_INFORMATION CORE-6994 #resolve

2015-04-22 Thread tfaber
Author: tfaber Date: Wed Apr 22 15:50:00 2015 New Revision: 67349 URL: http://svn.reactos.org/svn/reactos?rev=67349&view=rev Log: [NTDLL_APITEST] - Ensure 4-byte alignment for ATOM_BASIC_INFORMATION CORE-6994 #resolve Modified: trunk/rostests/winetests/ntdll/atom.c Modified: trunk/rost

[ros-diffs] [tfaber] 67342: [SHELL32] - Add colon after driver letter in Check Disk dialog title. Patch by Barrett Karish CORE-9583 #resolve

2015-04-22 Thread tfaber
Author: tfaber Date: Wed Apr 22 07:23:49 2015 New Revision: 67342 URL: http://svn.reactos.org/svn/reactos?rev=67342&view=rev Log: [SHELL32] - Add colon after driver letter in Check Disk dialog title. Patch by Barrett Karish CORE-9583 #resolve Modified: trunk/reactos/dll/win32/she

[ros-diffs] [tfaber] 67334: [NTDLL_APITEST] - Add some more tests for RtlDoesFileExists_*, in particular passing NT paths CORE-9523

2015-04-21 Thread tfaber
Author: tfaber Date: Tue Apr 21 10:50:12 2015 New Revision: 67334 URL: http://svn.reactos.org/svn/reactos?rev=67334&view=rev Log: [NTDLL_APITEST] - Add some more tests for RtlDoesFileExists_*, in particular passing NT paths CORE-9523 Modified: trunk/rostests/apitests/n

[ros-diffs] [tfaber] 67333: [WIN32K:NTUSER] - Fix some GetWindowPlacement tests CORE-9578

2015-04-21 Thread tfaber
Author: tfaber Date: Tue Apr 21 10:14:12 2015 New Revision: 67333 URL: http://svn.reactos.org/svn/reactos?rev=67333&view=rev Log: [WIN32K:NTUSER] - Fix some GetWindowPlacement tests CORE-9578 Modified: trunk/reactos/win32ss/user/ntuser/winpos.c trunk/rostests/apitests/us

[ros-diffs] [tfaber] 67331: [USER32_APITEST] - Use correct format specifiers aka fix GCC build

2015-04-21 Thread tfaber
Author: tfaber Date: Tue Apr 21 09:25:51 2015 New Revision: 67331 URL: http://svn.reactos.org/svn/reactos?rev=67331&view=rev Log: [USER32_APITEST] - Use correct format specifiers aka fix GCC build Modified: trunk/rostests/apitests/user32/GetWindowPlacement.c Modified: trunk/rost

[ros-diffs] [tfaber] 67330: [USER32_APITEST] - Add a test for GetWindowPlacement CORE-9578

2015-04-21 Thread tfaber
Author: tfaber Date: Tue Apr 21 09:21:22 2015 New Revision: 67330 URL: http://svn.reactos.org/svn/reactos?rev=67330&view=rev Log: [USER32_APITEST] - Add a test for GetWindowPlacement CORE-9578 Added: trunk/rostests/apitests/user32/GetWindowPlacement.c (with props) Modified: t

[ros-diffs] [tfaber] 67328: [COMCTL32] - Fix use after free in DPA_Merge

2015-04-20 Thread tfaber
Author: tfaber Date: Mon Apr 20 20:01:48 2015 New Revision: 67328 URL: http://svn.reactos.org/svn/reactos?rev=67328&view=rev Log: [COMCTL32] - Fix use after free in DPA_Merge Modified: trunk/reactos/dll/win32/comctl32/dpa.c Modified: trunk/reactos/dll/win32/comctl32/dpa.c URL:

[ros-diffs] [tfaber] 67324: [SYSSETUP] - Addendum to r66069: also install tcpip on the livecd CORE-9564 CORE-9113

2015-04-20 Thread tfaber
Author: tfaber Date: Mon Apr 20 09:35:39 2015 New Revision: 67324 URL: http://svn.reactos.org/svn/reactos?rev=67324&view=rev Log: [SYSSETUP] - Addendum to r66069: also install tcpip on the livecd CORE-9564 CORE-9113 Modified: trunk/reactos/dll/win32/syssetup/install.c trunk/reactos

[ros-diffs] [tfaber] 67323: [NETSHELL] - Fix spelling in README. Patch by Jared Smudde. CORE-9568 #resolve

2015-04-20 Thread tfaber
Author: tfaber Date: Mon Apr 20 07:32:03 2015 New Revision: 67323 URL: http://svn.reactos.org/svn/reactos?rev=67323&view=rev Log: [NETSHELL] - Fix spelling in README. Patch by Jared Smudde. CORE-9568 #resolve Modified: trunk/reactos/dll/shellext/netshell/README Modified: trunk/reactos

[ros-diffs] [tfaber] 67318: [IPCONFIG] - Add missing newlines

2015-04-19 Thread tfaber
Author: tfaber Date: Mon Apr 20 00:03:34 2015 New Revision: 67318 URL: http://svn.reactos.org/svn/reactos?rev=67318&view=rev Log: [IPCONFIG] - Add missing newlines Modified: trunk/reactos/base/applications/network/ipconfig/ipconfig.c Modified: trunk/reactos/base/applications/net

[ros-diffs] [tfaber] 67316: [NETSHELL][COM_APITEST] - Remove another MessageBox... - Also test some more interfaces found in netshell classes

2015-04-19 Thread tfaber
Author: tfaber Date: Sun Apr 19 22:50:25 2015 New Revision: 67316 URL: http://svn.reactos.org/svn/reactos?rev=67316&view=rev Log: [NETSHELL][COM_APITEST] - Remove another MessageBox... - Also test some more interfaces found in netshell classes Added: trunk/rostests/apitests/com/netcf

[ros-diffs] [tfaber] 67314: [NETSHELL] - Do not display a message box in CLanStatus::QueryInterface. Fixes hang when running com_apitest:netshell - Change the order of some interfaces in CNetworkConne

2015-04-19 Thread tfaber
Author: tfaber Date: Sun Apr 19 22:16:34 2015 New Revision: 67314 URL: http://svn.reactos.org/svn/reactos?rev=67314&view=rev Log: [NETSHELL] - Do not display a message box in CLanStatus::QueryInterface. Fixes hang when running com_apitest:netshell - Change the order of some interface

[ros-diffs] [tfaber] 67313: [COM_APITEST] - Add test for netshell classes - Add some interfaces

2015-04-19 Thread tfaber
Author: tfaber Date: Sun Apr 19 21:28:09 2015 New Revision: 67313 URL: http://svn.reactos.org/svn/reactos?rev=67313&view=rev Log: [COM_APITEST] - Add test for netshell classes - Add some interfaces Added: trunk/rostests/apitests/com/netshell.c (with props) Modified: trunk/rost

[ros-diffs] [tfaber] 67312: [NETSHELL] - Use the correct names for netshell's CLSIDs as indicated by the registry and public symbols

2015-04-19 Thread tfaber
Author: tfaber Date: Sun Apr 19 21:14:49 2015 New Revision: 67312 URL: http://svn.reactos.org/svn/reactos?rev=67312&view=rev Log: [NETSHELL] - Use the correct names for netshell's CLSIDs as indicated by the registry and public symbols Modified: trunk/reactos/dll/shellext/netshe

[ros-diffs] [tfaber] 67311: [NETSHELL] - Keep a CLanStatus instance around in CNetworkConnections (as before r65758) and properly manage its lifetime. Fixes Status context menu item for network connec

2015-04-19 Thread tfaber
Author: tfaber Date: Sun Apr 19 21:07:35 2015 New Revision: 67311 URL: http://svn.reactos.org/svn/reactos?rev=67311&view=rev Log: [NETSHELL] - Keep a CLanStatus instance around in CNetworkConnections (as before r65758) and properly manage its lifetime. Fixes Status context menu item for net

[ros-diffs] [tfaber] 67310: [NETSHELL] - Some additions to the previous commit - Make destructors private - Use delete to free object allocated using new - Try to fix some ITEMIDLIST typing

2015-04-19 Thread tfaber
Author: tfaber Date: Sun Apr 19 20:56:42 2015 New Revision: 67310 URL: http://svn.reactos.org/svn/reactos?rev=67310&view=rev Log: [NETSHELL] - Some additions to the previous commit - Make destructors private - Use delete to free object allocated using new - Try to fix some ITEMIDLIST ty

[ros-diffs] [tfaber] 67307: [NETSHELL] Fix artifacts from incomplete C++ conversion: - Add m_ prefix to member variables to avoid shadowing locals - Use initializer lists in constructors - Use destruc

2015-04-19 Thread tfaber
Author: tfaber Date: Sun Apr 19 20:18:25 2015 New Revision: 67307 URL: http://svn.reactos.org/svn/reactos?rev=67307&view=rev Log: [NETSHELL] Fix artifacts from incomplete C++ conversion: - Add m_ prefix to member variables to avoid shadowing locals - Use initializer lists in constructors -

[ros-diffs] [tfaber] 67298: [NETSHELL]{NCPA] - Move Network Connections back to Control Panel, where it belongs. Was accidentally moved to My Computer in r66485. CORE-9495 #resolve CORE-9564

2015-04-19 Thread tfaber
Author: tfaber Date: Sun Apr 19 15:01:54 2015 New Revision: 67298 URL: http://svn.reactos.org/svn/reactos?rev=67298&view=rev Log: [NETSHELL]{NCPA] - Move Network Connections back to Control Panel, where it belongs. Was accidentally moved to My Computer in r66485. CORE-9495 #resolve CORE-

[ros-diffs] [tfaber] 67293: [WIN32K:NTUSER] - Remove a useless assert (-Wtype-limits)

2015-04-19 Thread tfaber
Author: tfaber Date: Sun Apr 19 09:39:47 2015 New Revision: 67293 URL: http://svn.reactos.org/svn/reactos?rev=67293&view=rev Log: [WIN32K:NTUSER] - Remove a useless assert (-Wtype-limits) Modified: trunk/reactos/win32ss/user/ntuser/object.c Modified: trunk/reactos/win32ss/user/nt

[ros-diffs] [tfaber] 67292: [COMDLG32] - Revert DIALOG resource changes from r67286. Fixes test regressions. CORE-9563

2015-04-19 Thread tfaber
Author: tfaber Date: Sun Apr 19 08:53:57 2015 New Revision: 67292 URL: http://svn.reactos.org/svn/reactos?rev=67292&view=rev Log: [COMDLG32] - Revert DIALOG resource changes from r67286. Fixes test regressions. CORE-9563 Modified: trunk/reactos/dll/win32/comdlg32/lang/cdlg_Bg.rc t

[ros-diffs] [tfaber] 67291: [CMAKE] We have a zero-warnings policy in trunk, accordingly: - Disable overflow warnings in mciwave - Remove all -Wno-error directives - Remove all allow_warnings invocati

2015-04-19 Thread tfaber
Author: tfaber Date: Sun Apr 19 08:39:58 2015 New Revision: 67291 URL: http://svn.reactos.org/svn/reactos?rev=67291&view=rev Log: [CMAKE] We have a zero-warnings policy in trunk, accordingly: - Disable overflow warnings in mciwave - Remove all -Wno-error directives - Remove all allow_warn

<    5   6   7   8   9   10   11   12   13   14   >