Author: akhaldi
Date: Thu May 9 14:06:21 2013
New Revision: 58975
URL: http://svn.reactos.org/svn/reactos?rev=58975&view=rev
Log:
[ISAPNP]
* Add some function annotations.
* Fix several debug print specifiers.
* Properly mark some unreferenced parameters as such.
Modified:
trunk/reactos/drivers/bus/isapnp/fdo.c
trunk/reactos/drivers/bus/isapnp/hardware.c
trunk/reactos/drivers/bus/isapnp/isapnp.c
trunk/reactos/drivers/bus/isapnp/isapnp.h
Modified: trunk/reactos/drivers/bus/isapnp/fdo.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/isapnp/fdo.c?rev=58975&r1=58974&r2=58975&view=diff
==============================================================================
--- trunk/reactos/drivers/bus/isapnp/fdo.c [iso-8859-1] (original)
+++ trunk/reactos/drivers/bus/isapnp/fdo.c [iso-8859-1] Thu May 9
14:06:21 2013
@@ -18,6 +18,9 @@
{
NTSTATUS Status;
KIRQL OldIrql;
+
+ UNREFERENCED_PARAMETER(Irp);
+ UNREFERENCED_PARAMETER(IrpSp);
KeAcquireSpinLock(&FdoExt->Lock, &OldIrql);
Modified: trunk/reactos/drivers/bus/isapnp/hardware.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/isapnp/hardware.c?rev=58975&r1=58974&r2=58975&view=diff
==============================================================================
--- trunk/reactos/drivers/bus/isapnp/hardware.c [iso-8859-1] (original)
+++ trunk/reactos/drivers/bus/isapnp/hardware.c [iso-8859-1] Thu May 9
14:06:21 2013
@@ -319,7 +319,7 @@
INT Csn = 0;
USHORT Byte, Data;
- DPRINT("Setting read data port: 0x%x\n", ReadDataPort);
+ DPRINT("Setting read data port: 0x%p\n", ReadDataPort);
WaitForKey();
SendKey();
@@ -408,7 +408,7 @@
if (Csn > 0)
{
- DPRINT("Found %d cards at read port 0x%x\n", Csn, ReadDataPort);
+ DPRINT("Found %d cards at read port 0x%p\n", Csn, ReadDataPort);
}
return Csn;
@@ -543,7 +543,7 @@
return STATUS_UNSUCCESSFUL;
}
- DPRINT1("Detected read data port at 0x%x\n", FdoExt->ReadDataPort);
+ DPRINT1("Detected read data port at 0x%p\n", FdoExt->ReadDataPort);
return STATUS_SUCCESS;
}
Modified: trunk/reactos/drivers/bus/isapnp/isapnp.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/isapnp/isapnp.c?rev=58975&r1=58974&r2=58975&view=diff
==============================================================================
--- trunk/reactos/drivers/bus/isapnp/isapnp.c [iso-8859-1] (original)
+++ trunk/reactos/drivers/bus/isapnp/isapnp.c [iso-8859-1] Thu May 9
14:06:21 2013
@@ -9,6 +9,8 @@
#define NDEBUG
#include <debug.h>
+static IO_COMPLETION_ROUTINE ForwardIrpCompletion;
+
static
NTSTATUS
NTAPI
@@ -17,6 +19,9 @@
IN PIRP Irp,
IN PVOID Context)
{
+
+ UNREFERENCED_PARAMETER(DeviceObject);
+
if (Irp->PendingReturned)
KeSetEvent((PKEVENT)Context, IO_NO_INCREMENT, FALSE);
@@ -48,6 +53,7 @@
return Status;
}
+static DRIVER_DISPATCH IsaCreateClose;
static
NTSTATUS
@@ -65,6 +71,8 @@
return STATUS_SUCCESS;
}
+
+static DRIVER_DISPATCH IsaIoctl;
static
NTSTATUS
@@ -91,6 +99,8 @@
return Status;
}
+
+static DRIVER_DISPATCH IsaReadWrite;
static
NTSTATUS
@@ -153,6 +163,8 @@
return STATUS_SUCCESS;
}
+static DRIVER_DISPATCH IsaPnp;
+
static
NTSTATUS
NTAPI
Modified: trunk/reactos/drivers/bus/isapnp/isapnp.h
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/isapnp/isapnp.h?rev=58975&r1=58974&r2=58975&view=diff
==============================================================================
--- trunk/reactos/drivers/bus/isapnp/isapnp.h [iso-8859-1] (original)
+++ trunk/reactos/drivers/bus/isapnp/isapnp.h [iso-8859-1] Thu May 9
14:06:21 2013
@@ -40,6 +40,9 @@
} ISAPNP_LOGICAL_DEVICE, *PISAPNP_LOGICAL_DEVICE;
/* isapnp.c */
+
+DRIVER_INITIALIZE DriverEntry;
+
NTSTATUS
NTAPI
DriverEntry(
