Re: [Rosegarden-devel] status of the guitar code ?

2006-07-29 Thread Stephen Torri
On Sun, 2006-07-30 at 03:35 +0200, Pedro Lopez-Cabanillas wrote: > On Saturday, 29 July 2006 21:01, I wrote: > > The problem must be at the rendering part, I guess. > > I've committed a patch trying to fix this issue. First, the Event constructor > at Fingering::getAsEvent() was wrong (it needs

Re: [Rosegarden-devel] status of the guitar code ?

2006-07-29 Thread Pedro Lopez-Cabanillas
On Saturday, 29 July 2006 21:01, I wrote: > The problem must be at the rendering part, I guess. I've committed a patch trying to fix this issue. First, the Event constructor at Fingering::getAsEvent() was wrong (it needs four arguments). It now sets the sub-ordering property to -60 as you want

Re: [Rosegarden-devel] status of the guitar code ?

2006-07-29 Thread D. Michael McIntyre
On Saturday 29 July 2006 2:19 pm, Guillaume Laurent wrote: > That's Michelle, right ? I wish she had replied to my request to provide a > patch using standard tools :-). Me too. -- D. Michael 'Silvan' McIntyre Silvan <[EMAIL PROTECTED]> Linux fanatic, and certified Geek; registered Lin

Re: [Rosegarden-devel] step recording chords

2006-07-29 Thread Heikki Johannes Junes
I had in mind that this Chord Overlapping Mode would be the default mode. In addition to this mode there would be two other modes: - Solo Mode (no chords at all) instead of chord overlapping mode;this was the earlier mode, and  - Chord Mode (do not proceed in time at all); as it also was previously

Re: [Rosegarden-devel] step recording chords

2006-07-29 Thread D. Michael 'Silvan' McIntyre
On Saturday 29 July 2006 4:45 pm, Pedro Lopez-Cabanillas wrote: > Don't worry, it is fixed now. I saw. Nice turnaround. > Except if you are writting music for a monophonic instrument like a flute. > In this case the old behavior helps a bit avoiding to enter a chord by > mistake. This is true,

Re: [Rosegarden-devel] step recording chords

2006-07-29 Thread Pedro Lopez-Cabanillas
On Saturday, 29 July 2006 21:11, D. Michael 'Silvan' McIntyre wrote: > On Saturday 29 July 2006 2:45 pm, Pedro Lopez-Cabanillas wrote: > > What I don't like is that the notation view starts now in select mode, > > instead of insert mode with quarter note duration enabled. This changed > > in SVN af

Re: [Rosegarden-devel] step recording chords

2006-07-29 Thread D. Michael 'Silvan' McIntyre
On Saturday 29 July 2006 3:10 pm, Chris Cannam wrote: > We should probably update the notation view mode logic so that it only > checks for notes, rather than reverting Michael's change (which was > sound I think). Ah. That makes sense. I knew there would be at least one unintended consequence

Re: [Rosegarden-devel] step recording chords

2006-07-29 Thread Pedro Lopez-Cabanillas
On Saturday, 29 July 2006 21:10, Chris Cannam wrote: > On Saturday 29 Jul 2006 19:45, Pedro Lopez-Cabanillas wrote: > > What I don't like is that the notation view starts now in select > > mode, instead of insert mode with quarter note duration enabled. > > I haven't checked, but I think this is an

Re: [Rosegarden-devel] status of the guitar code ?

2006-07-29 Thread Stephen Torri
On Sat, 2006-07-29 at 20:19 +0200, Guillaume Laurent wrote: > On Saturday 29 July 2006 19:05, Stephen Torri wrote: > > > > I am working on the next generation of the guitar chord. What you see at > > present is a prototype which is going to be radically changed. The > > present prototype allows the

Re: [Rosegarden-devel] step recording chords

2006-07-29 Thread Chris Cannam
On Saturday 29 Jul 2006 20:11, D. Michael 'Silvan' McIntyre wrote: > I agree with the principle of not breaking things users have come to > expect, but I honestly think the old behavior in this case was > actually broken all along, and this new behavior is a bug fix. OK, the consensus seems to be

Re: [Rosegarden-devel] step recording chords

2006-07-29 Thread D. Michael 'Silvan' McIntyre
On Saturday 29 July 2006 2:45 pm, Pedro Lopez-Cabanillas wrote: > What I don't like is that the notation view starts now in select mode, > instead of insert mode with quarter note duration enabled. This changed in > SVN after 1.2.3, I think. So it does. I can't think if I would have broken that.

Re: [Rosegarden-devel] step recording chords

2006-07-29 Thread Chris Cannam
On Saturday 29 Jul 2006 19:45, Pedro Lopez-Cabanillas wrote: > What I don't like is that the notation view starts now in select > mode, instead of insert mode with quarter note duration enabled. I haven't checked, but I think this is an unintended consequence of Michael's having changed the segme

Re: [Rosegarden-devel] status of the guitar code ?

2006-07-29 Thread D. Michael 'Silvan' McIntyre
On Saturday 29 July 2006 3:01 pm, Pedro Lopez-Cabanillas wrote: > I think that there is nothing wrong in this code fragment. You are > calculating the insertionTime correctly, and you can see in the event list > editor that your fingering events have the right times. The problem must be > at the r

Re: [Rosegarden-devel] status of the guitar code ?

2006-07-29 Thread D. Michael 'Silvan' McIntyre
On Saturday 29 July 2006 2:09 pm, Pedro Lopez-Cabanillas wrote: > I don't have a "show fretboard" command. I think that you need to set the > fretboard mode, pressing the button without a real icon (next to the "text" No real icon? I committed an icon for this some time back, and it shows up he

Re: [Rosegarden-devel] status of the guitar code ?

2006-07-29 Thread Pedro Lopez-Cabanillas
On Saturday, 29 July 2006 20:25, Stephen Torri wrote: > On Sat, 2006-07-29 at 20:09 +0200, Pedro Lopez-Cabanillas wrote: > > I think that there is a bug: the chord diagrams aren't drawn over the > > notehead you clicked, but one or two beats after it. > > How you suggest I get the position of where

Re: [Rosegarden-devel] step recording chords

2006-07-29 Thread Pedro Lopez-Cabanillas
On Saturday, 29 July 2006 09:50, Chris Cannam wrote: > It works quite well. Give it a try -- you have to > enable "chord overlapping notes" mode in the tools > menu of the notation window. Tried, and it works nicely here. I must say that I've never used the step recording before, so I am not in

Re: [Rosegarden-devel] status of the guitar code ?

2006-07-29 Thread Stephen Torri
On Sat, 2006-07-29 at 20:09 +0200, Pedro Lopez-Cabanillas wrote: > I think that there is a bug: the chord diagrams aren't drawn over the > notehead > you clicked, but one or two beats after it. How you suggest I get the position of where to play the diagram? At present I try to calculate the cl

Re: [Rosegarden-devel] status of the guitar code ?

2006-07-29 Thread Guillaume Laurent
On Saturday 29 July 2006 19:05, Stephen Torri wrote: > > I am working on the next generation of the guitar chord. What you see at > present is a prototype which is going to be radically changed. The > present prototype allows the user to create, modify or select chords. > The new version is going t

Re: [Rosegarden-devel] status of the guitar code ?

2006-07-29 Thread Pedro Lopez-Cabanillas
On Saturday, 29 July 2006 12:26, Guillaume Laurent wrote: > I can't find a way to invoke it ('show fretboard' fails). > > So what's up ? I don't have a "show fretboard" command. I think that you need to set the fretboard mode, pressing the button without a real icon (next to the "text" mode one)

Re: [Rosegarden-devel] status of the guitar code ?

2006-07-29 Thread Stephen Torri
On Sat, 2006-07-29 at 12:26 +0200, Guillaume Laurent wrote: > Can anyone bring me up to date on the current status of the guitar-related > code ? I'm looking into it right now and it seems to be missing some bits (it > refers to some rc files, guitar.rc fretboardinserter.rc, some classes aren't

Re: [Rosegarden-devel] step recording chords

2006-07-29 Thread D. Michael 'Silvan' McIntyre
On Saturday 29 July 2006 9:26 am, D. Michael 'Silvan' McIntyre wrote: > Hrm. I don't have any of that, because I didn't install last time. It > seems to be on by default. I've compared an older installed build against > the one in RGBuild, and this behavior has changed. Wow! My message just s

Re: [Rosegarden-devel] step recording chords

2006-07-29 Thread D. Michael 'Silvan' McIntyre
On Saturday 29 July 2006 3:50 am, Chris Cannam wrote: > It works quite well. Give it a try -- you have to > enable "chord overlapping notes" mode in the tools > menu of the notation window. Hrm. I don't have any of that, because I didn't install last time. It seems to be on by default. I've

[Rosegarden-devel] status of the guitar code ?

2006-07-29 Thread Guillaume Laurent
Can anyone bring me up to date on the current status of the guitar-related code ? I'm looking into it right now and it seems to be missing some bits (it refers to some rc files, guitar.rc fretboardinserter.rc, some classes aren't used anywhere - GuitarTabEditorWindow), and I can't find a way to

Re: [Rosegarden-devel] step recording chords

2006-07-29 Thread Chris Cannam
G: > Seems to me that this behavior is what people would expect, and I'm not sure > how the oppositve behavior would be at all useful, so I wouldn't even make it > configurable. That is basically what I'm suggesting, but I should have mentioned the disadvantage -- one often plays notes with a

Re: [Rosegarden-devel] step recording chords

2006-07-29 Thread Guillaume Laurent
On Saturday 29 July 2006 09:50, Chris Cannam wrote: > Heikki has just implemented a welcome feature -- one > I meant to do and wrote a comment about years ago, > but got bogged down in trying to think of the perfect > algorithm for rather than sensibly doing the simplest > way. This is making step

[Rosegarden-devel] step recording chords

2006-07-29 Thread Chris Cannam
Heikki has just implemented a welcome feature -- one I meant to do and wrote a comment about years ago, but got bogged down in trying to think of the perfect algorithm for rather than sensibly doing the simplest way. This is making step-record generate chords when it receives notes that over