[Rosegarden-devel] Percussion matrix improvement

2006-03-05 Thread Yves Guillemot
Hello all, Here is a patch adressing 3 issues : 1 - Changing the drum set has no effect on an opened percussion matrix. 2 - Deleting a device (in studio->manage midi device) while a percussion matrix is opened and uses a key mapping coming from this device may cause a crash. 3 - A segment co

Re: [Rosegarden-devel] Percussion matrix improvement

2006-03-05 Thread D. Michael 'Silvan' McIntyre
On Sunday 05 March 2006 6:00 pm, Yves Guillemot wrote: > Here is a patch adressing 3 issues : Thanks very much! We love patches! I don't have time to look this over at the moment, since it's about time to go earn my paycheck, but I'm sure Chris or Guillaume will be right along to react to thi

Re: [Rosegarden-devel] Percussion matrix improvement

2006-03-06 Thread Chris Cannam
On Sunday 05 Mar 2006 23:00, Yves Guillemot wrote: > Here is a patch adressing 3 issues : > > 1 - Changing the drum set has no effect on an opened percussion matrix. > > 2 - Deleting a device (in studio->manage midi device) while a percussion > matrix is opened and uses a key mapping coming from th

Re: [Rosegarden-devel] Percussion matrix improvement

2006-03-06 Thread Yves Guillemot
On Monday 06 March 2006 01:43 pm, Chris Cannam wrote: > A question -- why the QWidgetStack? Were you thinking we could have a > toggle to switch quickly between percussion and pitch keyboard displays, or > something? That might be a nice feature (though inessential). To say the truth, I'm quite

Re: [Rosegarden-devel] Percussion matrix improvement

2006-03-18 Thread Guillaume Laurent
(sorry for jumping in so late) On Monday 06 March 2006 22:32, Yves Guillemot wrote: > On Monday 06 March 2006 01:43 pm, Chris Cannam wrote: > > A question -- why the QWidgetStack? Were you thinking we could have a > > toggle to switch quickly between percussion and pitch keyboard displays, > > or

Re: [Rosegarden-devel] Percussion matrix improvement

2006-03-27 Thread Guillaume Laurent
On Saturday 18 March 2006 19:52, Guillaume Laurent wrote: > > can be removed altogether because you're building m_pitchRulerStack with > m_pianoView->viewport() as the parent, which will delete its children. I > suggest you take a quick look at the Qt tutorial, then try to improve your > patch a bi

Re: [Rosegarden-devel] Percussion matrix improvement

2006-03-31 Thread Yves Guillemot
On Saturday 18 March 2006 19:52, Guillaume Laurent wrote: > (sorry for jumping in so late) Sorry too : it's my turn to reply late > > Have you tried simply > > delete m_pitchRuler; > m_pitchRuler = newPitchRuler; > m_pianoView->addChild(m_pitchRuler) > This seemed to be the obvious way and was,

Re: [Rosegarden-devel] Percussion matrix improvement

2006-03-31 Thread Guillaume Laurent
On Saturday 01 April 2006 00:54, Yves Guillemot wrote: > > Aaaah : I was wondering why there are so few "delete" in RG dtors. I now > begin to understand. > Nevertheless I don't think Qt documentation very clear on this point and I > still need to proceed by myself to some experimentations. Having

Re: [Rosegarden-devel] Percussion matrix improvement

2006-04-01 Thread Yves Guillemot
On Saturday 01 April 2006 01:55, Guillaume Laurent wrote: > Most of the time, if you find the doc is missing something it > just means you haven't found the right page yet : > > http://doc.trolltech.com/3.3/objecttrees.html > True : I don't remember to have ever read this page. Thanks to have poi