Re: [Rosegarden-devel] glasgow pitchtracker patch 2 (with patch)

2011-03-29 Thread Graham Percival
On 29/03/11 16:09, Chris Cannam wrote: > On 29 March 2011 16:00, Graham Percival > wrote: >> Here's a revised patch 2, with the tunings data in xml. > > Looks fine to me. Thanks, committed. Cheers, - Graham -- Enable y

Re: [Rosegarden-devel] glasgow pitchtracker patch 2 (with patch)

2011-03-29 Thread Chris Cannam
On 29 March 2011 16:00, Graham Percival wrote: > Here's a revised patch 2, with the tunings data in xml. Looks fine to me. Chris -- Enable your software for Intel(R) Active Management Technology to meet the growing man

[Rosegarden-devel] glasgow pitchtracker patch 2 (with patch)

2011-03-29 Thread Graham Percival
Hi all, Here's a revised patch 2, with the tunings data in xml. ADDED: + src/sound/Tuning.cpp + src/sound/Tuning.h + data/pitches/tunings.xml MODIFIED: = src/base/NotationTypes.h = src/base/NotationTypes.cpp Cheers, - Graham Index: src/sound/Tuning.cpp

[Rosegarden-devel] glasgow pitchtracker patch 2

2011-03-29 Thread Graham Percival
Hi all, Here's a revised patch 2, with the tunings data in xml. ADDED: + src/sound/Tuning.cpp + src/sound/Tuning.h + data/pitches/tunings.xml MODIFIED: = src/base/NotationTypes.h = src/base/NotationTypes.cpp Cheers, - Graham

Re: [Rosegarden-devel] glasgow pitchtracker patch 2

2011-03-11 Thread Dr Nicholas J Bailey
On Monday 07 Mar 2011 18:28:58 GRAHAM KEITH PERCIVAL wrote: > On 07/03/11 17:27, Nick Bailey wrote: > > On Saturday 05 Mar 2011 11:16:06 you wrote: > >> There's no point writing (or keeping) messy C++ code when a > >> trivially-simple python script will do. And I don't see the point of > >> scala,

Re: [Rosegarden-devel] glasgow pitchtracker patch 2

2011-03-07 Thread Graham Percival
On 07/03/11 17:27, Nick Bailey wrote: > On Saturday 05 Mar 2011 11:16:06 you wrote: >> There's no point writing (or keeping) messy C++ code when a >> trivially-simple python script will do. And I don't see the point of >> scala, other than being a convenient source of pre-written formulae. > That'

Re: [Rosegarden-devel] glasgow pitchtracker patch 2

2011-03-05 Thread Graham Percival
On 04/03/11 13:53, Nick Bailey wrote: > For the moment we only distribute 12-ET and 19-ET files, because all the > microtonal performances we're working with are singing or playing in 19-ET, > but there was a time when we were considering extended mean tone. Because > tuning's a very sophisticated

Re: [Rosegarden-devel] glasgow pitchtracker patch 2

2011-03-04 Thread Nick Bailey
On Friday 04 Mar 2011 13:20:42 Chris Cannam wrote: > On 4 March 2011 12:44, Graham Percival wrote: > > + data/pitches/tunings > > I'm not at all sure about introducing a custom file format and parser. Me neither. I wanted The Doug to write a lex/yacc one, but he refused :) > Why not just use X

Re: [Rosegarden-devel] glasgow pitchtracker patch 2

2011-03-04 Thread Graham Percival
On 04/03/11 13:20, Chris Cannam wrote: > On 4 March 2011 12:44, Graham Percival > wrote: >> + data/pitches/tunings > > I'm not at all sure about introducing a custom file format and parser. > Why not just use XML like all our other configuration files? That's > very easily parsed using Qt. > >

Re: [Rosegarden-devel] glasgow pitchtracker patch 2

2011-03-04 Thread Chris Cannam
On 4 March 2011 12:44, Graham Percival wrote: > + data/pitches/tunings I'm not at all sure about introducing a custom file format and parser. Why not just use XML like all our other configuration files? That's very easily parsed using Qt. I appreciate XML is harder to read and edit than plain

Re: [Rosegarden-devel] glasgow pitchtracker patch 2

2011-03-04 Thread Graham Percival
On 04/03/11 10:50, Graham Percival wrote: > PATCH 2: My apologies; that patch does not compile. Please consider this one instead. PATCH 2: + src/sound/Tunings .h .cpp + data/pitches/tunings === src/base/NotationTypes .h .cpp // no other files modified The change to the existing src/base/No

[Rosegarden-devel] glasgow pitchtracker patch 2

2011-03-04 Thread Graham Percival
PATCH 2: + src/sound/Tunings .h .cpp + data/pitches/tunings // no other files modified Since we haven't modified any GUI files (or indeed, any current rosegarden files), you won't see anything different when you compile Rosegarden. However, getting these files merged now will make the later dif