Re: Bas64 encoding performance

2002-03-10 Thread John Wilson
Here you go John Wilson The Wilson Partnership http://www.wilson.co.uk - Original Message - From: "Jon Scott Stevens" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Sent: Monday, March 11, 2002 1:06 AM Subject: Re: Bas64 encoding performance > on 3/10/02 2:48 PM, "John Wilson" <[EMAIL PRO

RE: Bas64 encoding performance

2002-03-10 Thread Paul Brown
> From: John Wilson [mailto:[EMAIL PROTECTED]] > the code ignores whitespace. > Which I take to mean that "=" or "==" should not be followed by non > whitespace characters. So I think I'm justified in flagging this as an > error. John -- You're right... :) I missed the bytes at the head o

Re: Bas64 encoding performance

2002-03-10 Thread Jon Scott Stevens
on 3/10/02 2:48 PM, "John Wilson" <[EMAIL PROTECTED]> wrote: > > Paul, > > the code ignores whitespace. John, please re-submit your files to the list, your email client line wrapped them. I have gotten the problem with attachments fixed. Or, you could put them on your/a website so that we ca

Re: Bas64 encoding performance

2002-03-10 Thread John Wilson
- Original Message - From: "Paul Brown" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Sent: Sunday, March 10, 2002 10:00 PM Subject: RE: Bas64 encoding performance > > > From: John Wilson [mailto:[EMAIL PROTECTED]] > > Subject: Re: Bas64 encoding performance > > + if (sixBit < 64) {

RE: Bas64 encoding performance

2002-03-10 Thread Paul Brown
> From: John Wilson [mailto:[EMAIL PROTECTED]] > Subject: Re: Bas64 encoding performance > + if (sixBit < 64) { > +if (gotEquals) throw new Error("= character not at end of base64 > value"); Technically, if you look at the RFC (which is probably the correct yardstick for a cross-sys

Re: Bas64 encoding performance

2002-03-10 Thread John Wilson
As the list seems to be eating attachments - here's the patch as a message: Index: src/java/org/apache/xmlrpc/Base64.java === RCS file: /home/cvspublic/xml-rpc/src/java/org/apache/xmlrpc/Base64.java,v retrieving revision 1.2 diff -

Re: Bas64 encoding performance

2002-03-10 Thread Rick Blair
Hi all, John has always been a great supporter and maintainer. He is also a great resource. I say +1 to be a committer. Rick At 10:15 AM 3/10/02 +0100, you wrote: >Jason van Zyl wrote: > >> >>Definitely. I know you've been on the helma mailing lists and have >>always helped out, that

[patch] fix javadoc warnings

2002-03-10 Thread Martin Poeschl
Index: ./src/java/org/apache/xmlrpc/WebServer.java === RCS file: /home/cvspublic/xml-rpc/src/java/org/apache/xmlrpc/WebServer.java,v retrieving revision 1.9 diff -u -r1.9 WebServer.java --- ./src/java/org/apache/xmlrpc/WebServer.java

Re: Bas64 encoding performance

2002-03-10 Thread John Wilson
- Original Message - From: "Jason van Zyl" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Sent: Sunday, March 10, 2002 2:23 AM Subject: Re: Bas64 encoding performance [snip] > Maybe we could combine the code bases somehow? > That would be a little difficult - MinML-RPC is intended for sys

Re: Bas64 encoding performance

2002-03-10 Thread Hannes Wallnoefer
Jason van Zyl wrote: > >Definitely. I know you've been on the helma mailing lists and have >always helped out, that you are very familiar with XmlRpc in general >(MinML-RPC) so I'd say you're more than capable of applying your patches >directly. > >I would like to nominate John for commit access.

Re: Bas64 encoding performance

2002-03-10 Thread John Wilson
One last go - see if the file extension of the attachment is significant. John Wilson The Wilson Partnership http://www.wilson.co.uk

Re: Bas64 encoding performance

2002-03-10 Thread John Wilson
- Original Message - From: "John Wilson" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Cc: <[EMAIL PROTECTED]> Sent: Sunday, March 10, 2002 8:21 AM Subject: Re: Bas64 encoding performance [snip] > I sent an email with the patches as an attachment to the list a couple > of minutes after

Re: Bas64 encoding performance

2002-03-10 Thread John Wilson
- Original Message - From: "Rick Blair" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Sent: Sunday, March 10, 2002 1:03 AM Subject: Re: Bas64 encoding performance > John, > > Looks good. I would like to have them, Any change getting it > patched in the apache surce tree. If so then +1.