Re: [CVS] RPM: rpm-5_3: rpm/ CHANGES rpm/rpmdb/ rpmdb.c

2011-02-16 Thread Jeff Johnson
On Feb 16, 2011, at 11:34 AM, Per Øyvind Karlsen wrote: > send 'subscribe maintainers' to sy...@mandriva.com (IIRC). Done. Likely time to resurrect now that I have industrial strength SPAM filtering in place. 73 de Jeff smime.p7s Description: S/MIME cryptographic signature

Re: [CVS] RPM: rpm-5_3: rpm/ CHANGES rpm/rpmdb/ rpmdb.c

2011-02-16 Thread Jeff Johnson
On Feb 16, 2011, at 11:36 AM, Per Øyvind Karlsen wrote: >> > Would this patch be better? :) > Yah, that looks better for performance and less of a radical change (so less risk) than trying to always attach an accurate count to every iterator. OTOH, performance and clarity are at odds here. Th

Re: [CVS] RPM: rpm-5_3: rpm/ CHANGES rpm/rpmdb/ rpmdb.c

2011-02-16 Thread Per Øyvind Karlsen
2011/2/14 Jeff Johnson : > > On Feb 13, 2011, at 10:56 PM, Per Øyvind Karlsen wrote: > >>> >>> And no I'm not subscribed to , my reply bounced. >> it's an open list, just a matter of subscribing :) >> > > You assume I know more than I do. Until you mentioned, I had no idea. > > And I still don't kn

Re: [CVS] RPM: rpm-5_3: rpm/ CHANGES rpm/rpmdb/ rpmdb.c

2011-02-16 Thread Per Øyvind Karlsen
2011/2/14 Per Øyvind Karlsen : > 2011/2/14 Jeff Johnson : >> >> On Feb 13, 2011, at 9:41 PM, Per Øyvind Karlsen wrote: >> >>> 2011/2/14 Jeff Johnson : Hmmm ... rpmmiCount is supposed to be invoked lazily when needed, not as part of every iteration. The conditions in rpmmiCount()

Re: [CVS] RPM: rpm-5_3: rpm/ CHANGES rpm/rpmdb/ rpmdb.c

2011-02-13 Thread Jeff Johnson
On Feb 13, 2011, at 10:56 PM, Per Øyvind Karlsen wrote: >> >> And no I'm not subscribed to , my reply bounced. > it's an open list, just a matter of subscribing :) > You assume I know more than I do. Until you mentioned, I had no idea. And I still don't know what list is where even if open.

Re: [CVS] RPM: rpm-5_3: rpm/ CHANGES rpm/rpmdb/ rpmdb.c

2011-02-13 Thread Per Øyvind Karlsen
2011/2/14 Jeff Johnson : > > On Feb 13, 2011, at 10:15 PM, Jeff Johnson wrote: >> >> Hmm the rpmiPrune() just above psm.c:1666 might need to >> looked at ... until yesterday it really dinna matter whether >> %trigger's worked beyond the toy test cases I originally >> wrote when implementing. Its pr

Re: [CVS] RPM: rpm-5_3: rpm/ CHANGES rpm/rpmdb/ rpmdb.c

2011-02-13 Thread Per Øyvind Karlsen
2011/2/14 Jeff Johnson : > > On Feb 13, 2011, at 9:41 PM, Per Øyvind Karlsen wrote: > >> 2011/2/14 Jeff Johnson : >>> Hmmm ... rpmmiCount is supposed to be invoked lazily when needed, >>> not as part of every iteration. >>> >>> The conditions in rpmmiCount() may need adjustment. That I can >>> easi

Re: [CVS] RPM: rpm-5_3: rpm/ CHANGES rpm/rpmdb/ rpmdb.c

2011-02-13 Thread Jeff Johnson
On Feb 13, 2011, at 10:15 PM, Jeff Johnson wrote: > > Hmm the rpmiPrune() just above psm.c:1666 might need to > looked at ... until yesterday it really dinna matter whether > %trigger's worked beyond the toy test cases I originally > wrote when implementing. Its probably ok, rpmmiPrune() is used

Re: [CVS] RPM: rpm-5_3: rpm/ CHANGES rpm/rpmdb/ rpmdb.c

2011-02-13 Thread Jeff Johnson
On Feb 13, 2011, at 9:41 PM, Per Øyvind Karlsen wrote: > 2011/2/14 Jeff Johnson : >> Hmmm ... rpmmiCount is supposed to be invoked lazily when needed, >> not as part of every iteration. >> >> The conditions in rpmmiCount() may need adjustment. That I can >> easily believe. > in lib/psm.c:1666 >

Re: [CVS] RPM: rpm-5_3: rpm/ CHANGES rpm/rpmdb/ rpmdb.c

2011-02-13 Thread Per Øyvind Karlsen
2011/2/14 Jeff Johnson : > Hmmm ... rpmmiCount is supposed to be invoked lazily when needed, > not as part of every iteration. > > The conditions in rpmmiCount() may need adjustment. That I can > easily believe. in lib/psm.c:1666 rpmmiCount() is used, where rpmmiNext() has already created mi->mi_d

Re: [CVS] RPM: rpm-5_3: rpm/ CHANGES rpm/rpmdb/ rpmdb.c

2011-02-13 Thread Jeff Johnson
On Feb 13, 2011, at 9:15 PM, Jeff Johnson wrote: >> >> Log: >> set mi->mi_count when rpmmiNext() initializes db cursor so that >> rpmmiCount() won't break (mdvbz#62267) >> Note that using %trigger* in order to re-create symlinks when a package is upgraded is just wrong as well. Yes you can

Re: [CVS] RPM: rpm-5_3: rpm/ CHANGES rpm/rpmdb/ rpmdb.c

2011-02-13 Thread Jeff Johnson
Hmmm ... rpmmiCount is supposed to be invoked lazily when needed, not as part of every iteration. The conditions in rpmmiCount() may need adjustment. That I can easily believe. But an extra dbiGet() and dbiCount() call introduced into rpmmiNext() is almost certainly neither the right fix, nor the