Re: [Rpm-maint] [PATCH 1/2] Extending rpm plugin interface, part 1

2012-11-09 Thread Panu Matilainen
On 11/08/2012 01:01 PM, Reshetova, Elena wrote: Okay then, done and pushed. Now that I looked closer, I spotted (and fixed) a couple of more "issues": a tiny memleak from early rpmtsSetupTransactionPlugins() return and some further cosmetics (two soft-tabs instead of one hard-tab, trailing white

Re: [Rpm-maint] [PATCH 1/2] Extending rpm plugin interface, part 1

2012-11-09 Thread Reshetova, Elena
>> Oh and one other thing I noticed just now that'll need further thought: >> currently the script setup hook only runs for external scripts, but >> not the > embedded Lua-scripts. Which are getting more and more common... >> They'll obviously need to be handled quite differently as they run >> w

Re: [Rpm-maint] [PATCH 1/2] Extending rpm plugin interface, part 1

2012-11-09 Thread Panu Matilainen
On 11/09/2012 02:27 PM, Reshetova, Elena wrote: Oh and one other thing I noticed just now that'll need further thought: currently the script setup hook only runs for external scripts, but not the embedded Lua-scripts. Which are getting more and more common... They'll obviously need to be handle