Re: [Rpm-maint] [rpm] Support Apache Subversion as SCM in the BUILD arena. (#55)

2016-01-28 Thread Andreas Scherer
Keyword "process substitution": http://mywiki.wooledge.org/Bashism --- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/55#issuecomment-176393161___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http

Re: [Rpm-maint] [rpm] Support Apache Subversion as SCM in the BUILD arena. (#55)

2016-01-28 Thread Andreas Scherer
@lkardos Thanks for the hint; that syntax was new to me. In a first attempt, it indeed works from the console with `quilt` and `.zip`ped patches. However, `<(cat)` seems to be **bash** syntax. Both **debbuild** and **rpmbuild** use `#!/bin/sh` as the executing shell interpreter, which – at least

Re: [Rpm-maint] [rpm] Add RPMCALLBACK_ELEM_PROGRESS callback type (#36)

2016-01-28 Thread Florian Festi
Closed #36. --- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/36#event-529895073___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm] Add RPMCALLBACK_ELEM_PROGRESS callback type (#36)

2016-01-28 Thread Florian Festi
Pushed. --- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/36#issuecomment-176251217___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm] Permit dynamic selection of SCM. (#56)

2016-01-28 Thread Lubos Kardos
Closed #56. --- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/56#event-529846565___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm] Permit dynamic selection of SCM. (#56)

2016-01-28 Thread Lubos Kardos
Applied as ff30bf02b52b5de0acf1175bdc0d75ddb7028584 --- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/56#issuecomment-176238538___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.or

Re: [Rpm-maint] [rpm] Support Apache Subversion as SCM in the BUILD arena. (#55)

2016-01-28 Thread Lubos Kardos
Also following works too: cat test.patch | svn patch /proc/self/fd/0 --- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/55#issuecomment-176227507___ Rpm-maint mailing list Rpm-maint@lists.rp

Re: [Rpm-maint] [rpm] Support Apache Subversion as SCM in the BUILD arena. (#55)

2016-01-28 Thread Lubos Kardos
Are you really tried that because I tried following command in my test svn repository: cat test.patch | svn patch <(cat) and it worked. --- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/55#issuecomment-176226064__

Re: [Rpm-maint] [rpm] Support Apache Subversion as SCM in the BUILD arena. (#55)

2016-01-28 Thread Andreas Scherer
No, `svn patch` _requires_ a genuine file as input argument. If it _would_ accept input from `STDIN`, the `%{uncompress:...}` macro already takes care of choosing the right programme, including `cat` for uncompressed patches. Just as with `quilt`, the pipe stream of `%{uncompress:...}` is simpl

Re: [Rpm-maint] [rpm] Support Apache Subversion as SCM in the BUILD arena. (#55)

2016-01-28 Thread Lubos Kardos
Maybe instead of %{1} you can try <(cat) and maybe this will work also for compressed patches but I didn't tried that, just an idea. --- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/55#issuecomment-176209706

Re: [Rpm-maint] [rpm] Doc (#48)

2016-01-28 Thread Florian Festi
Ok, added all the doc updates. Changed the commit message for the GROUPS patch. I close this although the translation updates were dropped. --- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/48#issuecomment-176191782_

Re: [Rpm-maint] [rpm] Doc (#48)

2016-01-28 Thread Florian Festi
Closed #48. --- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/48#event-529695803___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm] Support Apache Subversion as SCM in the BUILD arena. (#55)

2016-01-28 Thread Andreas Scherer
> @@ -1120,6 +1122,23 @@ done \ > %{__patch} %{-p:-p%{-p*}} %{-q:-s}\ > %{__bzr} commit %{-q} -m %{-m*} > > +# Subversion > +%__scm_setup_svn(q)\ > +%{__svnadmin} create .svnrepos\ > +%{__svn} mkdir %{-q} -m "Create directory structure." > file://`pwd`/.svnrepos/trunk\ > +%{__svn} checkout %{-

Re: [Rpm-maint] [rpm] Doc (#48)

2016-01-28 Thread ニール・ゴンパ
@cgwalters I'm not sure if I would say the Groups were a failure, unless you're willing to elaborate on why. --- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/48#issuecomment-176185394___ Rpm-main

Re: [Rpm-maint] [rpm] Support Apache Subversion as SCM in the BUILD arena. (#55)

2016-01-28 Thread ニール・ゴンパ
> @@ -1120,6 +1122,23 @@ done \ > %{__patch} %{-p:-p%{-p*}} %{-q:-s}\ > %{__bzr} commit %{-q} -m %{-m*} > > +# Subversion > +%__scm_setup_svn(q)\ > +%{__svnadmin} create .svnrepos\ > +%{__svn} mkdir %{-q} -m "Create directory structure." > file://`pwd`/.svnrepos/trunk\ > +%{__svn} checkout %{-

Re: [Rpm-maint] [rpm] Doc (#48)

2016-01-28 Thread Florian Festi
Sorry, but the translations are done at https://www.transifex.com/rpm-team/rpm/ Changes to the translation files will just be overwritten. --- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/48#issuecomment-176184096___

Re: [Rpm-maint] [rpm] Support Apache Subversion as SCM in the BUILD arena. (#55)

2016-01-28 Thread Andreas Scherer
> @@ -1120,6 +1122,23 @@ done \ > %{__patch} %{-p:-p%{-p*}} %{-q:-s}\ > %{__bzr} commit %{-q} -m %{-m*} > > +# Subversion > +%__scm_setup_svn(q)\ > +%{__svnadmin} create .svnrepos\ > +%{__svn} mkdir %{-q} -m "Create directory structure." > file://`pwd`/.svnrepos/trunk\ > +%{__svn} checkout %{-

Re: [Rpm-maint] [rpm] Add lua function posix.close (#44)

2016-01-28 Thread Florian Festi
This pull request is not sufficient to fix the problem. For one there is no io.open in rpm's lua so far. Also we probably do not want random scriptlets to mess with with the file descriptors of the rpm process. So this would need some kind of protection (as we already added to exec and exit). I

Re: [Rpm-maint] [rpm] Support Apache Subversion as SCM in the BUILD arena. (#55)

2016-01-28 Thread ニール・ゴンパ
> @@ -1120,6 +1122,23 @@ done \ > %{__patch} %{-p:-p%{-p*}} %{-q:-s}\ > %{__bzr} commit %{-q} -m %{-m*} > > +# Subversion > +%__scm_setup_svn(q)\ > +%{__svnadmin} create .svnrepos\ > +%{__svn} mkdir %{-q} -m "Create directory structure." > file://`pwd`/.svnrepos/trunk\ > +%{__svn} checkout %{-

Re: [Rpm-maint] [rpm] Support Apache Subversion as SCM in the BUILD arena. (#55)

2016-01-28 Thread Andreas Scherer
> @@ -1120,6 +1122,23 @@ done \ > %{__patch} %{-p:-p%{-p*}} %{-q:-s}\ > %{__bzr} commit %{-q} -m %{-m*} > > +# Subversion > +%__scm_setup_svn(q)\ > +%{__svnadmin} create .svnrepos\ > +%{__svn} mkdir %{-q} -m "Create directory structure." > file://`pwd`/.svnrepos/trunk\ > +%{__svn} checkout %{-

Re: [Rpm-maint] [rpm] Permit dynamic selection of SCM. (#56)

2016-01-28 Thread ニール・ゴンパ
@ascherer Eck, I didn't override the macro properly to test, that's why... It's all good to me :+1: --- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/56#issuecomment-176159440___ Rpm-maint mailin

Re: [Rpm-maint] [rpm] Support Apache Subversion as SCM in the BUILD arena. (#55)

2016-01-28 Thread ニール・ゴンパ
> @@ -1120,6 +1122,23 @@ done \ > %{__patch} %{-p:-p%{-p*}} %{-q:-s}\ > %{__bzr} commit %{-q} -m %{-m*} > > +# Subversion > +%__scm_setup_svn(q)\ > +%{__svnadmin} create .svnrepos\ > +%{__svn} mkdir %{-q} -m "Create directory structure." > file://`pwd`/.svnrepos/trunk\ > +%{__svn} checkout %{-

Re: [Rpm-maint] [rpm] Put all Perl-related macros in a single file. (#37)

2016-01-28 Thread Andreas Scherer
Personally, I don't use the Perl macros, but I know of [at least this project](https://github.com/pld-linux/perl-Pod-Simple/blob/master/perl-Pod-Simple.spec#L5) that makes use of `macros.perl`. (I suggested to [use `%_rpmconfigdir`](https://github.com/pld-linux/perl-Pod-Simple/pull/1) for the l

Re: [Rpm-maint] [rpm] Unknown tag %ifdef. (#39)

2016-01-28 Thread Florian Festi
Thanks for spotting this! --- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/39#issuecomment-176156624___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-mai

Re: [Rpm-maint] [rpm] Unknown tag %ifdef. (#39)

2016-01-28 Thread Florian Festi
Closed #39. --- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/39#event-529599270___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm] Put all Perl-related macros in a single file. (#37)

2016-01-28 Thread Florian Festi
Not sure if those macro can just be hidden away. We'd need to check how much packages this is going to break before doing such a change. It might be necessary to go the opposite direction (including the macros.perl unconditionally) and leave removing it again to the distros. --- Reply to this e

Re: [Rpm-maint] [rpm] Permit dynamic selection of SCM. (#56)

2016-01-28 Thread Andreas Scherer
What error do you get? I just checked, installed _this_ branch and edited [MMIX specfile](https://github.com/ascherer/mmix/blob/local/mmix.spec#L36) accordingly. ``` debbuild -bp SPECS/mmix.spec ``` runs perfectly with `-S git`, `-S git_am`, `-S patch`, and `-S quilt`, but **not** with `-S svn`

Re: [Rpm-maint] [rpm] fix %doc with glob with some locales (#45)

2016-01-28 Thread Lubos Kardos
Applied as b30d6657e221a9fe606477987aeb8a02a63b9de4 --- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/45#issuecomment-176147129___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.or

Re: [Rpm-maint] [rpm] alias -P on --provides (#47)

2016-01-28 Thread Lubos Kardos
Applied as 90da220a4c5300c0c84da760624f46ab99fc26a0 --- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/47#issuecomment-176147073___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.or

Re: [Rpm-maint] [rpm] fix %doc with glob with some locales (#45)

2016-01-28 Thread Lubos Kardos
Closed #45. --- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/45#event-529570408___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm] alias -P on --provides (#47)

2016-01-28 Thread Lubos Kardos
Closed #47. --- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/47#event-529570135___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm] 'quilt push' has option '-q'. (#54)

2016-01-28 Thread Lubos Kardos
Applied as 3dbcbd1a03c8d47b5177623c2ed211dfb2d7ea71 --- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/54#issuecomment-176146981___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.o

Re: [Rpm-maint] [rpm] 'quilt push' has option '-q'. (#54)

2016-01-28 Thread Lubos Kardos
Closed #54. --- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/54#event-529569788___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm] Fix reloadConfig method documentation (#51)

2016-01-28 Thread Lubos Kardos
Closed #51. --- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/51#event-529569356___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm] Fix reloadConfig method documentation (#51)

2016-01-28 Thread Lubos Kardos
Applied as 1fc5c16853e6161f4928964388c388a1d0e20169 --- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/51#issuecomment-176146829___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.or

Re: [Rpm-maint] [rpm] Support Apache Subversion as SCM in the BUILD arena. (#55)

2016-01-28 Thread Andreas Scherer
> @@ -1120,6 +1122,23 @@ done \ > %{__patch} %{-p:-p%{-p*}} %{-q:-s}\ > %{__bzr} commit %{-q} -m %{-m*} > > +# Subversion > +%__scm_setup_svn(q)\ > +%{__svnadmin} create .svnrepos\ > +%{__svn} mkdir %{-q} -m "Create directory structure." > file://`pwd`/.svnrepos/trunk\ > +%{__svn} checkout %{-

Re: [Rpm-maint] [rpm] Permit dynamic selection of SCM. (#56)

2016-01-28 Thread ニール・ゴンパ
@ascherer It doesn't look like -S is supported anymore in `%autosetup`. Does `%autosetup -S git` or something like that still work correctly? --- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/56#issuecomment-176122690___

Re: [Rpm-maint] [rpm] Support Apache Subversion as SCM in the BUILD arena. (#55)

2016-01-28 Thread ニール・ゴンパ
> @@ -1120,6 +1122,23 @@ done \ > %{__patch} %{-p:-p%{-p*}} %{-q:-s}\ > %{__bzr} commit %{-q} -m %{-m*} > > +# Subversion > +%__scm_setup_svn(q)\ > +%{__svnadmin} create .svnrepos\ > +%{__svn} mkdir %{-q} -m "Create directory structure." > file://`pwd`/.svnrepos/trunk\ > +%{__svn} checkout %{-