Re: [Rpm-maint] [rpm-software-management/rpm] find-debuginfo.sh: make sure that debugsourcefiles.list is generated … (#285)

2017-07-28 Thread Florian Festi
Merged #285. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/285#event-1183251098___ Rpm-maint mailing list Rpm-maint@lists.rpm.o

Re: [Rpm-maint] [rpm-software-management/rpm] _debugsource_packages sometimes crashes due to non-existing debugsourcefiles.list (#279)

2017-07-28 Thread Florian Festi
Closed #279 via #285. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/279#event-1183251099___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http:/

[Rpm-maint] [PATCH] Add two testcases for generating debugsource packages.

2017-07-28 Thread Mark Wielaard
These tests define _debugsource_packages and check a debugsource package is created that contains the source of the program created. Without the fix to make sure that debugsourcefiles.list is generated in the build dir the second testcase will fail with: error: Could not open %files file Signed-o

[Rpm-maint] [rpm-software-management/rpm] exclude respective debug files for files which are excluded (#286)

2017-07-28 Thread Igor Gnatenko
You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/286 -- Commit Summary -- * remove duplicated call to strlen() * store path of excluded files * exclude respective debug files for files which are excluded -- File Changes

[Rpm-maint] [PATCH] Warn and create empty debugsource package if there are no sources.

2017-07-28 Thread Mark Wielaard
Signed-off-by: Mark Wielaard --- scripts/find-debuginfo.sh | 13 + tests/rpmbuild.at | 33 + 2 files changed, 46 insertions(+) diff --git a/scripts/find-debuginfo.sh b/scripts/find-debuginfo.sh index d8725ad..9b3815a 100755 --- a/scripts/find-d

Re: [Rpm-maint] [PATCH] Add two testcases for generating debugsource packages.

2017-07-28 Thread Florian Festi
Thanks! Pushed. Florian On 07/28/2017 02:11 PM, Mark Wielaard wrote: > These tests define _debugsource_packages and check a debugsource package > is created that contains the source of the program created. > > Without the fix to make sure that debugsourcefiles.list is generated in > the build di

Re: [Rpm-maint] [rpm-software-management/rpm] exclude respective debug files for files which are excluded (#286)

2017-07-28 Thread Igor Gnatenko
@ignatenkobrain pushed 3 commits. e56ebda fixup! exclude respective debug files for files which are excluded 3b6043d store mapping for renamed files 7299900 reference proper debug files whenever RemovePathPostfixes is used -- You are receiving this because you are subscribed to this thread.

[Rpm-maint] [PATCH] Add rpmbuild debuginfo subpackages tests.

2017-07-28 Thread Mark Wielaard
This adds various tests for making sure multiple subpackages are build correctly. Without debuginfo subpackages, with subpackages, subpackages with unique debug file and source dir paths and with separate debugsources. Signed-off-by: Mark Wielaard --- tests/Makefile.am | 1

Re: [Rpm-maint] [rpm-software-management/rpm] Adding an LMDB backend to RPM (#281)

2017-07-28 Thread Jeff Johnson
In order to run queries as non-root, there are three minor changes: 1) lock.mdb (an 8Kb file) needs to be 0666, other perms as expected. 2) don't bother retrying mdb_env_open(): I added this line to display errors as well: ``` rpmlog(RPMLOG_ERR, "lmdb: %s(%s/lock.mdb): %s\n", __FUNCTION__, dbhom

Re: [Rpm-maint] [PATCH] Add rpmbuild debuginfo subpackages tests.

2017-07-28 Thread Dmitry V. Levin
On Fri, Jul 28, 2017 at 09:55:24PM +0200, Mark Wielaard wrote: > This adds various tests for making sure multiple subpackages are build > correctly. Without debuginfo subpackages, with subpackages, subpackages > with unique debug file and source dir paths and with separate debugsources. [...] > +#

Re: [Rpm-maint] [rpm-software-management/rpm] Adding an LMDB backend to RPM (#281)

2017-07-28 Thread Jeff Johnson
One last comparison: RPM5 uses BerkeleyDB too, but with different tunables than RPM4. Here's essentially the same measurement as the previous comment: ``` 1.15user 0.87system 0:02.11elapsed 96%CPU (0avgtext+0avgdata 584900maxresident)k 240inputs+390776outputs (7major+355303minor)pagefaults 0swaps

[Rpm-maint] [PATCH 1/2] Test split debuginfo packages with excluded files.

2017-07-28 Thread Mark Wielaard
If split debuginfo code doesn't know about excluded files it fails: error: Installed (but unpackaged) file(s) found: /usr/lib/debug/bin/hello3-1.0-1.x86_64.debug Signed-off-by: Mark Wielaard --- tests/Makefile.am | 1 + tests/data/SPECS/test-subpackages-exclude.

[Rpm-maint] [PATCH 2/2] Test split debuginfo packages with RemovePathPostfixes.

2017-07-28 Thread Mark Wielaard
If split debuginfo code doesn't know about RemovePathPostfixes it fails: error: Installed (but unpackaged) file(s) found: /usr/lib/debug/bin/hello.foobar-1.0-1.x86_64.debug Signed-off-by: Mark Wielaard --- tests/Makefile.am | 1 + .../data/SPECS/test-subpack

Re: [Rpm-maint] [rpm-software-management/rpm] Couple fixes for debuginfo subpackages (#286)

2017-07-28 Thread ニール・ゴンパ
@ignatenkobrain The PR looks okay to me, but put a `Fixes: #280` on the second line of your PR message so that when this is merged, it will close that issue automatically. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: htt

Re: [Rpm-maint] [rpm-software-management/rpm] Adding an LMDB backend to RPM (#281)

2017-07-28 Thread Jeff Johnson
For completeness, here is the same measurement with RPM+NDB: ``` $ /usr/bin/time ./rpm -qa --ndb > /dev/null 3.25user 0.13system 0:03.38elapsed 100%CPU (0avgtext+0avgdata 17664maxresident)k 0inputs+0outputs (0major+8164minor)pagefaults 0swaps ``` -- You are receiving this because you are subscrib

Re: [Rpm-maint] [rpm-software-management/rpm] Couple fixes for debuginfo subpackages (#286)

2017-07-28 Thread Igor Gnatenko
@Conan-Kudo doesn't matter, it is referenced from one of commits. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/286#issuecomment-318807088_

Re: [Rpm-maint] [rpm-software-management/rpm] Adding an LMDB backend to RPM (#281)

2017-07-28 Thread Jeff Johnson
After adding equivalent disabling of fsync and its ilk to mdb_env_open(): ``` eflags |= MDB_FIXEDMAP; #ifndef HACK eflags |= MDB_WRITEMAP; eflags |= MDB_NOMETASYNC; eflags |= MDB_MAPASYNC; eflags |= MDB_NOSYNC; eflags |= MDB_NOTLS; eflags |= M