Re: [Rpm-maint] [rpm-software-management/rpm] Add zstd compressed payload support to RPM (from @n3npq in #256) (#295)

2017-07-31 Thread Igor Gnatenko
ignatenkobrain commented on this pull request. > @@ -348,6 +348,12 @@ static char *getIOFlags(Package pkg) compr = "lzma"; (void) rpmlibNeedsFeature(pkg, "PayloadIsLzma", "4.4.6-1"); #endif +#if HAVE_ZSTD_H + } else if (rstreq(s+1, "zstdio")) { + compr =

Re: [Rpm-maint] [rpm-software-management/rpm] Add zstd compressed payload support to RPM (from @n3npq in #256) (#295)

2017-07-31 Thread Igor Gnatenko
ignatenkobrain commented on this pull request. > @@ -1278,6 +1278,11 @@ static const struct rpmlibProvides_s rpmlibProvides[] > = { { "rpmlib(RichDependencies)","4.12.0-1", ( RPMSENSE_EQUAL), N_("support for rich dependencies.") }, +#if HAVE_ZSTD_H +{ "rp

Re: [Rpm-maint] [rpm-software-management/rpm] Add zstd compressed payload support to RPM (from @n3npq in #256) (#295)

2017-07-31 Thread Igor Gnatenko
ignatenkobrain commented on this pull request. > @@ -203,6 +204,20 @@ AC_CHECK_HEADERS([lzma.h],[ AC_SUBST(WITH_LZMA_LIB) #= +# Check for zstd library. + +dnl # Facebook Zstd +RPM_CHECK_LIB( instead of this hug macro I would probably prefer to stick with pkg-config.. -- Yo

Re: [Rpm-maint] [rpm-software-management/rpm] Add zstd compressed payload support to RPM (from @n3npq in #256) (#295)

2017-07-31 Thread Jeff Johnson
n3npq commented on this pull request. > @@ -348,6 +348,12 @@ static char *getIOFlags(Package pkg) compr = "lzma"; (void) rpmlibNeedsFeature(pkg, "PayloadIsLzma", "4.4.6-1"); #endif +#if HAVE_ZSTD_H + } else if (rstreq(s+1, "zstdio")) { + compr = "zstd"; +

Re: [Rpm-maint] [rpm-software-management/rpm] Add zstd compressed payload support to RPM (from @n3npq in #256) (#295)

2017-07-31 Thread Igor Gnatenko
ignatenkobrain commented on this pull request. > @@ -348,6 +348,12 @@ static char *getIOFlags(Package pkg) compr = "lzma"; (void) rpmlibNeedsFeature(pkg, "PayloadIsLzma", "4.4.6-1"); #endif +#if HAVE_ZSTD_H + } else if (rstreq(s+1, "zstdio")) { + compr =

Re: [Rpm-maint] [rpm-software-management/rpm] Add zstd compressed payload support to RPM (from @n3npq in #256) (#295)

2017-07-31 Thread Jeff Johnson
n3npq commented on this pull request. > @@ -203,6 +204,20 @@ AC_CHECK_HEADERS([lzma.h],[ AC_SUBST(WITH_LZMA_LIB) #= +# Check for zstd library. + +dnl # Facebook Zstd +RPM_CHECK_LIB( RPM_CHECK_LIB uses pkgconfig (when available). I'm not sure what you wish. -- You are recei

Re: [Rpm-maint] [rpm-software-management/rpm] Add zstd compressed payload support to RPM (from @n3npq in #256) (#295)

2017-07-31 Thread Jeff Johnson
n3npq commented on this pull request. > @@ -348,6 +348,12 @@ static char *getIOFlags(Package pkg) compr = "lzma"; (void) rpmlibNeedsFeature(pkg, "PayloadIsLzma", "4.4.6-1"); #endif +#if HAVE_ZSTD_H + } else if (rstreq(s+1, "zstdio")) { + compr = "zstd"; +

Re: [Rpm-maint] [rpm-software-management/rpm] Add zstd compressed payload support to RPM (from @n3npq in #256) (#295)

2017-07-31 Thread Jeff Johnson
n3npq commented on this pull request. > @@ -1278,6 +1278,11 @@ static const struct rpmlibProvides_s rpmlibProvides[] > = { { "rpmlib(RichDependencies)","4.12.0-1", ( RPMSENSE_EQUAL), N_("support for rich dependencies.") }, +#if HAVE_ZSTD_H +{ "rpmlib(Payl

Re: [Rpm-maint] [rpm-software-management/rpm] Add LMDB backend for RPMDB to RPM (from @n3npq in #281) (#291)

2017-07-31 Thread Michael Schroeder
Please remove the part that patches ndb/glue.c from this commit. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/291#issuecomment-319020600__

Re: [Rpm-maint] [rpm-software-management/rpm] RPM+NDB should implement ndb_dump/ndb_load/ndb_stat for database dumps. (#289)

2017-07-31 Thread Michael Schroeder
Wouldn't it be better if rpmdb gets dump/load/stat options? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/289#issuecomment-319025432_

Re: [Rpm-maint] [rpm-software-management/rpm] Run binary package generation via thread pools (#226)

2017-07-31 Thread Alexander Kanavin
@ignatenkobrain The patches have been merged to Yocto project: http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=84e0bb8d936f1b9094c9d5a92825e9d22e1bc7e3 As @pmatilai said he will not look at them until after 4.14 is ready (which is two months away), right now I am not in a particular hur

Re: [Rpm-maint] [rpm-software-management/rpm] RPM+NDB should implement ndb_dump/ndb_load/ndb_stat for database dumps. (#289)

2017-07-31 Thread Jeff Johnson
Bundling into rpmdb would be fine: just there needs to be a common interchange format. E.g. libvirt uses db_dump and is opposed to NDB because it lacks an equivalent. The textual non-hex format is occasionally useful as well (but with digests/signatures one cannot just edit the database). -- Y

Re: [Rpm-maint] [rpm-software-management/rpm] Add zstd compressed payload support to RPM (from @n3npq in #256) (#295)

2017-07-31 Thread ニール・ゴンパ
Conan-Kudo commented on this pull request. > @@ -348,6 +348,12 @@ static char *getIOFlags(Package pkg) compr = "lzma"; (void) rpmlibNeedsFeature(pkg, "PayloadIsLzma", "4.4.6-1"); #endif +#if HAVE_ZSTD_H + } else if (rstreq(s+1, "zstdio")) { + compr = "zst

Re: [Rpm-maint] [rpm-software-management/rpm] Add LMDB backend for RPMDB to RPM (from @n3npq in #281) (#291)

2017-07-31 Thread ニール・ゴンパ
@mlschroe Fixed. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/291#issuecomment-319041353___ Rpm-maint mailing list Rpm-maint@l

Re: [Rpm-maint] [rpm-software-management/rpm] Add zstd compressed payload support to RPM (from @n3npq in #256) (#295)

2017-07-31 Thread ニール・ゴンパ
Conan-Kudo commented on this pull request. > @@ -203,6 +204,20 @@ AC_CHECK_HEADERS([lzma.h],[ AC_SUBST(WITH_LZMA_LIB) #= +# Check for zstd library. + +dnl # Facebook Zstd +RPM_CHECK_LIB( `RPM_CHECK_LIB` makes it work when pkgconfig isn't available (macOS, etc.). It also mak

Re: [Rpm-maint] [rpm-software-management/rpm] RPM+NDB should implement ndb_dump/ndb_load/ndb_stat for database dumps. (#289)

2017-07-31 Thread Jeff Johnson
FWIW, there are other markups that could be usefully added to rpmdb, like CUDF (or other SAT solver inputs). The real issue is compatibility with commonly used external tools, not so much whether the output markup is implemented in an existing rpmdb executable or a separate ndb_dump utility. -