> the two cases only differ by the actual token, you should handle them
> by the same code and without unnecessary + 5 "magic" calculations.
Will be improved in the next version.
> auxBuf is not used to modify the contents so it should be const
Will be changed in the next version.
> Having
My bad, I used [semantic versioning](https://semver.org/) terminology
(major.minor.patch).
I wasn't referring to distro-managed patchsets.
So this change will likely never make it into any rpm release?
Will there be a replacement?
--
You are receiving this because you are subscribed to this
Thanks for the pointer. I'm afraid very few people know about this (me the
first)!
Please don't just test for non-zero, test any write on stderr, otherwise you
get those weird stderr messages appearing without any trace of what triggered
them.
--
You are receiving this because you are
In rpm >= 4.14 you can get the exact command and exact file triggering with -vv
--rpmfcdebug
Rpm is not interested in the stderr of dependency generators but we could
probably provide better diagnostics automatically when a depgen returns with
non-zero code.
--
You are receiving this because
Trivial as this change may be, the commit message is not really helpful as it
completely fails to tell the actual story. The rationale(s) behind a change
belongs to the commit message, not here in GH discussion.
--
You are receiving this because you are subscribed to this thread.
Reply to this
Merged, thanks for the patch!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/623#issuecomment-460232204___
Rpm-maint mailing
Merged #623 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/623#event-2115527651___
Rpm-maint mailing list
- the two cases only differ by the actual token, you should handle them by the
same code and without unnecessary + 5 "magic" calculations.
- auxBuf is not used to modify the contents so it should be const
- Having several places parse the same tokens is generally an indication of
something being
Commit b3fcaba3816aa00f3360efe728dafa72e394f65b added a tag reservation
basically just for this purpose but the implementation got stalled with various
underlying defiences, side-issues and API considerations.
--
You are receiving this because you are subscribed to this thread.
Reply to this
rpm.org does not get to say what goes into distros as patches on top of the
upstream releases they're based on.
Anyway, this commit is more likely to be reverted upstream than backported
anywhere.
--
You are receiving this because you are subscribed to this thread.
Reply to this email
10 matches
Mail list logo
