Typo in the first sentence of the commit message: "odrering"
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Merged #679 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/679#event-2340075923___
Rpm-maint mailing list
pavlinamv commented on this pull request.
> +size_t textLen;
+const char *text;
+int withArgs;
+int isConditional;
+int wrongPrecursors;
+const char *info_text;
+} * parsedSpecLine;
+
+static struct parsedSpecLine_s const lineTypes[] = {
+{ LINE_ENDIF,
pavlinamv commented on this pull request.
> @@ -462,6 +430,16 @@ int readLine(rpmSpec spec, int strip)
lineType = parseLineType(s);
if (!lineType)
goto after_classification;
+
+/* for a conditional check its ordering */
+if (lineType->isConditional &&
+
Maybe third time's the charm... while walking the dog I remembered the hash
table added in commit e33045e35c09cda530a9e665c367693e285b6511 that wasn't
there when these patches were created needs thread protection now.
--
You are receiving this because you are subscribed to this thread.
Reply
@pmatilai pushed 1 commit.
b42103a0f539c600a8b3de423d9db76501623b98 fixup! Run file classification in
parallel threads
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
@ffesti spotted a bug in the binaryPackages() for loop logic, fixed in the
first push but then a regression introduced in commit
0f21bdd0d7b2c45564ddb5a24bbebd530867bd54 caused one test to fail. Now rebased
on top of the regression fix... pffft.
--
You are receiving this because you are
Merged #705 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/705#event-2339744626___
Rpm-maint mailing list
…bd54
Unlike typical fooFree() functions in rpm, Fclose() doesn't set the
pointer to NULL so there's a use-after-free in checking for Ferror()
that segfaults and stuff. Delay Fclose() until the end so we actually
catch io errors too, that was another thing that went missing in
commit
Actually it's not this patch that should be discussed but the behavior overall,
but that belongs to a ticket or a PR implementing something new.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Merged #700 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/700#event-2339406668___
Rpm-maint mailing list
Anyway, dropped the docstring change from the "expand all macros" commit, its
all in the cleanup commit instead.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
And yeah there is going to be some overhead from using a hash, but otoh this
also eliminates a whole lot of overhead that is currently running on each file,
and if we ever want to run more than one file at a time through a generator
there's not a whole lot of choice.
--
You are receiving this
Oh, I left the doc string fix as a separate commit because it eliminates *all*
the useless docstrings from rpmfc so its not really related to these.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Merged #704 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/704#event-2339355061___
Rpm-maint mailing list
Looks good. Please squash the doc string fix and push upstream!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
I was first concerned that all this "putting stuff in data structures" might
create overhead. After having a deeper look this is not a problem. Storing a
few more integers while we have the whole set of file names in memory will
probably not kill anyone.
--
You are receiving this because you
pmatilai commented on this pull request.
> * @param dsContext RPMSENSE_FIND_PROVIDES or RPMSENSE_FIND_REQUIRES
* @param tagN RPMTAG_PROVIDENAME or RPMTAG_REQUIRENAME
* @return 0 on success
*/
static int rpmfcHelper(rpmfc fc, int ix, const struct exclreg_s *excl,
-
ffesti commented on this pull request.
> * @param dsContext RPMSENSE_FIND_PROVIDES or RPMSENSE_FIND_REQUIRES
* @param tagN RPMTAG_PROVIDENAME or RPMTAG_REQUIRENAME
* @return 0 on success
*/
static int rpmfcHelper(rpmfc fc, int ix, const struct exclreg_s *excl,
-
pmatilai commented on this pull request.
> * @param dsContext RPMSENSE_FIND_PROVIDES or RPMSENSE_FIND_REQUIRES
* @param tagN RPMTAG_PROVIDENAME or RPMTAG_REQUIRENAME
* @return 0 on success
*/
static int rpmfcHelper(rpmfc fc, int ix, const struct exclreg_s *excl,
-
ffesti commented on this pull request.
> * @param dsContext RPMSENSE_FIND_PROVIDES or RPMSENSE_FIND_REQUIRES
* @param tagN RPMTAG_PROVIDENAME or RPMTAG_REQUIRENAME
* @return 0 on success
*/
static int rpmfcHelper(rpmfc fc, int ix, const struct exclreg_s *excl,
-
Merged #701 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/701#event-2339264198___
Rpm-maint mailing list
Closed #689 via 7ca03925d88d27266a4f8bec7a35e8c3b1117279.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Merged #693 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/693#event-2339204434___
Rpm-maint mailing list
Commit message updated
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/704#issuecomment-492120276___
Rpm-maint mailing list
Merged #697 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/697#event-2339191927___
Rpm-maint mailing list
I can certainly clarify it though.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/704#issuecomment-492118767___
Rpm-maint
Hmm, it's not a typo, it refers both to the chroot and root user inside the
user namespace.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Merged #692 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/692#event-2339175588___
Rpm-maint mailing list
"userns-root" in the patch description looks like a typo.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Merged #699 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/699#event-2339160393___
Rpm-maint mailing list
31 matches
Mail list logo
