Re: [Rpm-maint] [rpm-software-management/rpm] Implement %elif (#710)

2019-05-22 Thread pavlinamv
pavlinamv commented on this pull request. > rl->lastConditional = lineType; spec->readStack = rl; spec->line[0] = '\0'; +} else if (lineType->id & (LINE_ELIF | LINE_ELIFARCH | LINE_ELIFOS)) { It is changed in the new version. -- You are receiving this because you

Re: [Rpm-maint] [rpm-software-management/rpm] Couple of python binding cleanups (#711)

2019-05-22 Thread Panu Matilainen
@pmatilai pushed 1 commit. 9e1d52a05b6e3a2b1c7fe7cc49d658b6091b6baa Un-inline utf8FromString() python helper now that we can -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Implement %elif (#710)

2019-05-22 Thread Panu Matilainen
pmatilai commented on this pull request. > rl->lastConditional = lineType; spec->readStack = rl; spec->line[0] = '\0'; +} else if (lineType->id & (LINE_ELIF | LINE_ELIFARCH | LINE_ELIFOS)) { The various ELIF's are another candidate for a bit mask, this set is repeated

Re: [Rpm-maint] [rpm-software-management/rpm] Implement %elif (#710)

2019-05-22 Thread pavlinamv
Panu's comments are incorporated. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/710#issuecomment-494773665___ Rpm-maint

[Rpm-maint] [rpm-software-management/rpm] Couple of python binding cleanups (#711)

2019-05-22 Thread Panu Matilainen
Remove remnants of long dead code, and eliminate unnecessary hoops for header object creation from spec. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/711 -- Commit Summary -- * Drop now unnecessary PyCapsule foobar from