The commit message should be a bit more precise. The condition is actually
correct. It's just using a sub optimal style.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/737
Fix verified by @dashea in
https://github.com/rpm-software-management/rpm/issues/723#issuecomment-498761620
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/734#issuecomment
Closed #723 via 143b9ead7ffd7ab234ace05f25c6d1de1d700a7e.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/723#event-2390339867_
Merged #734 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/734#event-2390339788___
Rpm-maint mailing list
Rpm-maint
Thanks for verifying, and for the script! I'll try to make a test-case out of
that as time permits.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/723#issuecomment-49897
Merged #737 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/737#event-2390571644___
Rpm-maint mailing list
Rpm-maint
pmatilai approved this pull request.
Looking fine now.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/737#pullrequestreview-245886981
Closed #735.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/735#event-2390586544___
Rpm-maint mailing list
Rpm-maint@lists.rpm
Fixed in commit 9aae21d7610a7e8067ae932f36d1c8bb8583fe59
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/735#issuecomment-499003984__
Oh btw, when submitting a PR with an associated ticket, it's useful to put
"Closes: #" into the commit message to get the ticket automatically
closed when the PR is merged. Saves that little bit of administrative trivia
clickety-click.
--
You are receiving this because you are subscribed to th
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/738
-- Commit Summary --
* Fix --without-lua build.
* Skip tests that use lua (indirectly) when configured --without-lua.
-- File Changes --
M rpmio/rpmlua.h (5)
M
> BTW do you know where is popt git repo?
As of roughly 15 minutes ago, thanks to @Conan-Kudo 's cvs conversion effort,
there is one now here: https://github.com/rpm-software-management/popt
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or vi
When building RPMs that have %changelog sections with changelog entries with
full timestamps, RPM did not take the time zone into account. Now the timezone
description is taken into account using function tzset(). It handles correctly
timezone descriptions like:
"Europe/London",
"GMT-5", or
"NZ
Merged #738 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/738#event-2390783069___
Rpm-maint mailing list
Rpm-maint
The luaL_Reg thing is annoying, I wish there was a nicer way around it. Anyway,
at least it's just internal cruft that's not exposed in our public API, *shrug*.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.
On 6/4/19 12:28 AM, Mark Wielaard wrote:
commit 62bd62 "Add a rpmlua wrapper function for registering libraries"
moved the rpmluaRegister function definition into rpmio/rpmlua.h and
added an #include . This made that file not compile anymore
when lua-devel isn't installed and configuring --withou
it would be great to get it as a test so we don't break it at some point
accidentally.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/739#issuecomment-499029727___
On 6/5/19 1:29 PM, Panu Matilainen wrote:
On 6/4/19 12:28 AM, Mark Wielaard wrote:
commit 62bd62 "Add a rpmlua wrapper function for registering libraries"
moved the rpmluaRegister function definition into rpmio/rpmlua.h and
added an #include . This made that file not compile anymore
when lua-dev
pmatilai commented on this pull request.
> %autosetup(a:b:cDn:TvNS:p:)\
%setup %{-a} %{-b} %{-c} %{-D} %{-n} %{-T} %{!-v:-q}\
%{-S:%global __scm %{-S*}}\
%{expand:%__scm_setup_%{__scm} %{!-v:-q}}\
%{!-N:%autopatch %{-v} %{-p:-p%{-p*}}}
+# Macro to remove or replace tilde from version.
+#
If you were getting worried that we'll be stuck on 4.14.x forever, you
were not alone in that. Getting the originally planned feature set
implemented prolonged the cycle way out of proportion, and there have
been all sorts of other environment and circumstancial obstacles to
overcome as well
@pavlinamv pushed 2 commits.
1b44c113b06574e24ae5cd1e92aa2ae132975081 Return non-zero exit status if
changelog order fails
e4dc76e450dd0277fe5f15d4b74df3935dc2ae58 Test effects of time zone in chanelog
timestamp
--
You are receiving this because you are subscribed to this thread.
View it on
BTW it would be really good to make new popt release :)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/724#issuecomment-499100987_
That's probably going to be a while. We'll need to figure out what the distros
are doing to popt, clean them up, and integrate them into the git repo before
we consider making a new release.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or vie
Tests were added. Moreover they already help to show, that exit status 0 is
returned when changelog order fails. Thus I add an additional commit that
corrects this behaviour (regression).
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view i
ignatenkobrain commented on this pull request.
> @@ -30,10 +30,12 @@ static int sameDate(const struct tm *ot, const struct tm
> *nt)
ot->tm_wday == nt->tm_wday);
}
+#define TZ_MAX_LENGTH 80
It would be great if this number was described. I mean why not 67 or 93 :)
--
You are r
For the time being, our plans with popt are limited to giving it a home and a
place where people can file bugs and submit patches and see what happens.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-s
pmatilai commented on this pull request.
> @@ -30,10 +30,12 @@ static int sameDate(const struct tm *ot, const struct tm
> *nt)
ot->tm_wday == nt->tm_wday);
}
+#define TZ_MAX_LENGTH 80
Just use dynamic allocation to avoid arbitrary limits that need explanations :)
--
You are re
27 matches
Mail list logo
