Re: [Rpm-maint] [rpm-software-management/rpm] Split verbose make flags to a separate macro (#799)

2019-07-31 Thread ニール・ゴンパ
Conan-Kudo approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/799#pullrequestreview-269359569___

Re: [Rpm-maint] [rpm-software-management/rpm] Split verbose make flags to a separate macro (#799)

2019-07-31 Thread Jason Tibbitts
jasontibbitts commented on this pull request. > @@ -1073,7 +1073,8 @@ package or when debugging this package.\ #-- # The "make" analogue, hiding the _smp_mflags magic from specs -%make_build %{__make}

Re: [Rpm-maint] [rpm-software-management/rpm] Fix off-by-one in hdrblobGet() making last entry unreachable (RhBug:1… (#803)

2019-07-31 Thread Florian Festi
Merged #803 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/803#event-2523238395___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Take changelog timezone in account (RhBug 1715412) (#739)

2019-07-31 Thread ニール・ゴンパ
@pavlinamv The `date` command can do exactly the same thing as this. ``` $ date --date='Wed 31 Jul 2019 09:02:40 AM EDT' +'%s' 1564578160 $ date --date='@1564578160' Wed 31 Jul 2019 09:02:40 AM EDT $ date --date='@1564578160' --utc Wed 31 Jul 2019 01:02:40 PM UTC ``` Cf.

Re: [Rpm-maint] [rpm-software-management/rpm] Fix off-by-one in hdrblobGet() making last entry unreachable (RhBug:1… (#803)

2019-07-31 Thread Panu Matilainen
Oh and before anybody asks, the reason there's not an accompanying testcase is that creating a sufficiently large package in the testsuite is just prohibitively expensive (as is including a binary sample) -- You are receiving this because you are subscribed to this thread. Reply to this email

[Rpm-maint] [rpm-software-management/rpm] Fix off-by-one in hdrblobGet() making last entry unreachable (RhBug:1… (#803)

2019-07-31 Thread Panu Matilainen
…722921) hdrblobGet() introduced in commits acfde0d0e812e9f8e153ab6be8c9f2682bdd4763 and 9821de18811db97238c34a564221e315f5f35b44 has an off-by-one thinko (perhaps the idea was to skip the first, region tag) which causes the last entry to be unreachable. In typical packages, that is