[Rpm-maint] [rpm-software-management/rpm] expression expansion (#834)

2019-09-11 Thread Michael Schroeder
There's a lot of expansion going on in the %expr macro. Witness this: ./rpm --eval '%{expr: ""}' % The string gets expanded - at the start of doFoo when it expands the argument - in rdToken when it parses a string - at the end of doFoo because of issue #313 I'm somewhat surprised that

Re: [Rpm-maint] [rpm-software-management/rpm] Cannot leave comments after %endif (#829)

2019-09-11 Thread Ernestas Kulik
As far as 3 goes, does anything other than text belong there? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Cannot leave comments after %endif (#829)

2019-09-11 Thread Panu Matilainen
Never said it'd be easy to retrofit. But basically 1) Macros are handled by the macro engine, not spec. The macro body is always literal and must remain so, so that auto_register_macro_post() macro would essentially emit a #-comment line. 2) Comments in build-scriptlets are shell comments, not

Re: [Rpm-maint] [rpm-software-management/rpm] Change the default crypto implementation to libgcrypt (from NSS) (#832)

2019-09-11 Thread Panu Matilainen
Merged #832 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/832#event-2624616599___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Do not allow to divide by 0 in the expression evaluation (#833)

2019-09-11 Thread Panu Matilainen
Nice catch! It's not a question of allowing or not allowing though, it's simply an error which we now trap instead of crashing. So drop the "not allowed" from the error message, and adjust the commit message to that tune too. -- You are receiving this because you are subscribed to this thread.