@Conan-kudo I see, I’ve mentioned #88 in issue #925 that explains the more
general issue of rpmvercmp() taking as equal versions that are really
different. And also elaborated a little bit why I needed the + character to be
taken into account.
This is just a fix for a particular case of the
Conan-Kudo approved this pull request.
LGTM. The only thing missing is a fix for the changelog timestamps stuff, but
that's not even fixed in master yet. :(
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
This was attempted originally as #88 and was rejected, which is why we switched
to `^`.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
There are cases when the `rpmvercmp()` function compares two different version
strings as equal.
For example, in some cases adding a plus `+` character at the end of the
version denotes that this version is the base version plus some changes. This
is the case of the Linux kernel build system
This commit adds supports for sorting the plus (+) character higher
than
base version. Its similar to what commit c7e711bba58 (Add support for
sorting caret (^) higher than base version) did for the caret
character.
A plus character is used for example by the Linux kernel build system to
denote
Preparation for 4.15.1 release, consisting of
- critical bugfixes here and there (arm, dynamic buildrequires rpmlib(), revert
dbus shutdown)
- handful of various %{expr:...} related fixes
- ndb fixes (replacing PR #908 )
- add support for gcrypt crypto
- bunch of documentation updates
- misc
One thing caught my eye there: we're returning with exit code zero from invalid
queryformat, which can't be right. That behavior is probably ages old, and only
related to this patch in that the behavior shows in the added test. But if you
want to have a look at that, feel free.
--
You are
pmatilai approved this pull request.
Yup, looks fine to me.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Merged #922 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/922#event-2767230933___
Rpm-maint mailing list
