@opoplawski pushed 1 commit.
fc670e136d3549810178a91666a209fb6fca222f Also use --reject with git am
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
Conan-Kudo approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/928#pullrequestreview-312588583___
Done
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/928#issuecomment-550397650___
Rpm-maint mailing list
@elros34 Ah, so the issue is that Busybox diff only supports unified diffs. I
think it may make sense to just adjust check-files to use unified diff format
universally, then.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
There is no output because sed never matches "-/path/to/file" output generated
by busybox diff. It expects "< /path/to/file"
This is problem in sailfishos which use busybox tools in many places thus there
is no "Installed (but unpackaged) file(s) found" even if they are unpackaged
files.
--
@elros34 Could you please paste in what the output looks like?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
busybox diff use different output format: + and - instead
and
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/928
-- Commit Summary --
* Make check-files compatible with busybox diff
-- File Changes --
M
Header id wraparound is not the most acute of our problems sure, but it's also
a bit like a "here be dragons" sign at the edge of the map :) Certainly not the
only one of its kind either.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view
Conan-Kudo requested changes on this pull request.
Could you also add `--reject` to the `git am` call?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Conan-Kudo approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/927#pullrequestreview-312483209___
I wouldn't worry too much about that wrap around: if you add a new rpm header
every tenth of a second, you'll need 13 years for the hdrid to wrap.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Okay, you track inode to detect rebuilds, that will cover the rebuilddb case
but not the id wraparound one which ultimately needs to be handled anyway.
And yeah I know AUTOINCREMENT, but it comes with a cost.
BTW just realized that this change actually doesn't really change anything at
all in
The rebuilddb case is handled by stat()ing the database. A rebuilt database
will have a different inode number.
(You probably already know this, but sqlite will guarantee increasing numbers
when you use the AUTOINCREMENT keyword.)
--
You are receiving this because you are subscribed to this
It's not like sqlite *has to* do it this way now or ever, it's just handy. But
id recycling does already happen, this would just make it a little more common
(sqlite only recycles on wraparound and if the largest rowid is removed)
--
You are receiving this because you are subscribed to this
Hmm, header ids being stable is not a safe assumption regardless of this, they
will get renumbered and recycling can occur on --rebuilddb.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Just FYI, recycling previously used header ids will break libsolv's
`repo_add_rpmdb()` function, which uses the packages from an old solv file if
the header id matches.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
16 matches
Mail list logo
