Yeah I noticed the #if 0 -block and its similarity, I just assumed it was a
leftover/work-in-progress thing related to, well prefix search :)
I remember a fleeting thought "why is there no flags field in the index
iterator struct where I could stuff this in", but somehow the thought of
putting
Updated to reuse the #if 0'ed codeblock, renamed to ii_skipdata and commit
messages adjusted, they were somewhat mixed up with the latter commit speaking
about updating backends, which was obviously done in the first commit.
--
You are receiving this because you are subscribed to this thread.
R
Merged #971 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/971#event-2865572295___
Rpm-maint mailing list
Rpm-maint
Oh and thanks for the review!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/971#issuecomment-563147244___
Rpm-maint mailing lis
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/972
-- Commit Summary --
* Simplify sqlite cursor preparation logic
* Never reuse cursors for different purposes in sqlite
* Trash the stupid sqlite statement cache
* Us
Conan-Kudo requested changes on this pull request.
> @@ -584,11 +558,8 @@ static rpmRC sqlite_idxdbIter(dbiIndex dbi, dbiCursor
> dbc, const char *keyp, siz
dbc->key = sqlite3_column_blob(dbc->stmt, 0);
}
dbc->keylen = sqlite3_column_bytes(dbc->stmt, 0);
- if (
scripts/pythondistdeps: Only add setuptools requirement for egg-info packages.
This should address issue #954
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/973
-- Commit Summary --
* scripts/pythondistdeps: Only add setu
LGTM. @hroncok r?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/973#issuecomment-563426375___
Rpm-maint mailing list
Rpm-maint@
Conan-Kudo approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/973#pullrequestreview-329214227___
Rpm
pmatilai commented on this pull request.
> @@ -584,11 +558,8 @@ static rpmRC sqlite_idxdbIter(dbiIndex dbi, dbiCursor
> dbc, const char *keyp, siz
dbc->key = sqlite3_column_blob(dbc->stmt, 0);
}
dbc->keylen = sqlite3_column_bytes(dbc->stmt, 0);
- if (set) {
-
10 matches
Mail list logo
