Re: [Rpm-maint] [rpm-software-management/rpm] Add dbus-announce plugin (#1255)

2020-06-25 Thread Colin Walters
> imposes its own signal handling on users when the db is open Can turn that off since 56f49d7f5af7c1c8a3eb478431356195adbfdd25 right? > and our ABI hasn't been particularly stable historically Maintaining C shared libraries is indeed extremely hard. I've messed up in the past and only just

Re: [Rpm-maint] [rpm-software-management/rpm] Fix python(abi) requires generator, it picked files from almost good directories (#1272)

2020-06-25 Thread ニール・ゴンパ
I guess given that the magic stuff hasn't worked in forever, it's fine to just drop it and not worry about it flaking in the future. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Fix python(abi) requires generator, it picked files from almost good directories (#1272)

2020-06-25 Thread Miro Hrončok
> To be clear, `%__foo_path` and `%__foo_magic` filters are a union, not an > intersection? That's actually somewhat surprising behavior... Union by default but can be switched with `magic_and_path` flag in `%__foo_flags` to intersection. -- You are receiving this because you are subscribed

Re: [Rpm-maint] [rpm-software-management/rpm] Fix python(abi) requires generator, it picked files from almost good directories (#1272)

2020-06-25 Thread ニール・ゴンパ
@pmatilai To be clear, `%__foo_path` and `%__foo_magic` filters are a union, not an intersection? That's actually somewhat surprising behavior... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Fix python(abi) requires generator, it picked files from almost good directories (#1272)

2020-06-25 Thread ニール・ゴンパ
@Conan-Kudo approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1272#pullrequestreview-437395755___

Re: [Rpm-maint] [rpm-software-management/rpm] Fix python(abi) requires generator, it picked files from almost good directories (#1272)

2020-06-25 Thread torsava
The change looks good to me. And we've been using this in RHEL for a while with good results. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[Rpm-maint] [rpm-software-management/rpm] Fix bogus test-suite failure when input is not a tty (#1290) (#1291)

2020-06-25 Thread Panu Matilainen
When running with a non-tty input (such as inside mock), the --addsign test will fail due to GPG_TTY related warning getting emitted since commit 52c0198e245fcac55440ed1e0211d33f84681a7a. Our test-keys do not have passphrases that need to be asked, so just silence the warning by manually setting

Re: [Rpm-maint] [rpm-software-management/rpm] GPG_TTY warning causes test-suite failure in mock (#1290)

2020-06-25 Thread Panu Matilainen
Here's an simple reproducer that doesn't need messing with mock: > [pmatilai︎lumikko rpm]$ cp tests/data/RPMS/hello-2.0-1.x86_64.rpm /tmp/ [pmatilai︎lumikko rpm]$ ./rpmsign --addsign /tmp/hello-2.0-1.x86_64.rpm < /dev/null /tmp/hello-2.0-1.x86_64.rpm: warning: Could not set GPG_TTY to stdin:

Re: [Rpm-maint] [rpm-software-management/rpm] Fix python(abi) requires generator, it picked files from almost good directories (#1272)

2020-06-25 Thread Miro Hrončok
Ack. I'll ping people. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1272#issuecomment-649284471___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Add dbus-announce plugin (#1255)

2020-06-25 Thread Panu Matilainen
One important aspect of dbus vs librpm API is that not everybody wants to link to librpm, which imposes its own signal handling on users when the db is open, and our ABI hasn't been particularly stable historically, dbus library itself is much more stable AIUI. -- You are receiving this

Re: [Rpm-maint] [rpm-software-management/rpm] Fix python(abi) requires generator, it picked files from almost good directories (#1272)

2020-06-25 Thread Panu Matilainen
I was kinda expecting others from the Python camp to evaluate, I'm out of loop with what's going on in this land these days. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: