Re: [Rpm-maint] [rpm-software-management/rpm] debugedit: Distinguish files from directories in src list file (#1436)

2020-11-16 Thread Vitalio
@vt-alt pushed 1 commit. 8ab1e3646607711c81860998bdf49cc2ffe81fdd debugedit: Distinguish files from directories in src list file -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1436/files/01dee60d8dd1f

Re: [Rpm-maint] [rpm-software-management/rpm] debugedit: Do not 'edit_dwarf2' when just extracting build-id (#1435)

2020-11-16 Thread Vitalio
@vt-alt pushed 1 commit. 3e2cf02947c2048df90cf9161bfa8a7df60d4061 debugedit: Do not 'edit_dwarf2' when just extracting build-id -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1435/files/d47fece7584778

Re: [Rpm-maint] [rpm-software-management/rpm] \x1a (ASCII unit separator) cannot be escaped (#1438)

2020-11-16 Thread Demi Marie Obenour
Indeed it is, but not being able to write `quote_array` is somewhat concerning, especially since `\x1a` is technically a valid character in filenames. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-so

Re: [Rpm-maint] [rpm-software-management/rpm] Add %postbuild section / Allow dynamic sub packages (#1239)

2020-11-16 Thread Panu Matilainen
Been thinking about this on and off, and it still rubs me the wrong way. The spec is a convoluted mess as it is, and even the experienced packagers and macro developers have difficulties understanding and remembering the different time and space contexts of macros and build scriptlets which sit

[Rpm-maint] [PATCH] [NFC] debugedit: Move code to separate functions.

2020-11-16 Thread Mark Wielaard
Hi, This looks OK. I added a description of which functions were separate from where to the commit message and rebased the commit to the master branch. Cheers, Mark From ca137a2fa64eacfd0ad42b89c8436d78e1143820 Mon Sep 17 00:00:00 2001 From: Jan Kratochvil Date: Mon, 17 Aug 2020 21:58:19 +0200

[Rpm-maint] debugedit: Fix handling in caller for errors in called read_dwarf2_line.

2020-11-16 Thread Mark Wielaard
Hi, I don't fully understand what this patch is intended to do. Why is it necessary? > commit 0da448c337d481f1c50af212246ceb213a7d80cc (HEAD -> master) > Author: Jan Kratochvil > Date: Mon Aug 17 21:46:47 2020 +0200 > > debugedit: Fix handling in caller for errors in called > read_dwarf2_

[Rpm-maint] [PATCH] [NFC] debugedit: Protect macro arguments by parentheses

2020-11-16 Thread Mark Wielaard
Hi, The attached patch is part of the proposed patch series for PR/1332 and looks good. It can be applied independently IMHO. Cheers, Mark From aabd13f513eefe7e7db35a668e650a304def85d5 Mon Sep 17 00:00:00 2001 From: Jan Kratochvil Date: Mon, 17 Aug 2020 16:56:56 +0200 Subject: [PATCH] [NFC] deb

Re: [Rpm-maint] [rpm-software-management/rpm] Defining %global macro in %pre results empty in %post (#1440)

2020-11-16 Thread Giovanni Bertoncelli
Thank you... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1440#issuecomment-727879588___ Rpm-maint mailing list Rpm-maint@li

Re: [Rpm-maint] [rpm-software-management/rpm] Defining %global macro in %pre results empty in %post (#1440)

2020-11-16 Thread Panu Matilainen
Scriptlets are separate processes, basically the only common thing between them is the parent PID. If you need to share data between scriptlets, you need to put it on the filesystem. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on

Re: [Rpm-maint] [rpm-software-management/rpm] Defining %global macro in %pre results empty in %post (#1440)

2020-11-16 Thread Panu Matilainen
Closed #1440. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1440#event-3999465778___ Rpm-maint mailing list Rpm-maint@lists.r

[Rpm-maint] [rpm-software-management/rpm] Defining %global macro in %pre results empty in %post (#1440)

2020-11-16 Thread Giovanni Bertoncelli
I have to retrieve in the SPEC file the previous installed version of the package. I'm trying to define this custom macro inside %pre: ```spec %pre PREVIOUS_VERSION=$(/path/to/executable --version) %global _prevver $(echo $PREVIOUS_VERSION) ``` I will use it in the %post phase: ```spec %post

Re: [Rpm-maint] [rpm-software-management/rpm] \x1a (ASCII unit separator) cannot be escaped (#1438)

2020-11-16 Thread Panu Matilainen
Rpm macro engine is just a very simple-minded text processor. Handling binary data is out of scope. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1438#issuecomment-7278