Re: [Rpm-maint] [rpm-software-management/rpm] Enhanced checks and a fuzz harness (#1559)

2021-03-01 Thread Panu Matilainen
@DemiMarie , I know you're trying to help and thanks for that, but please stop trying so hard :slightly_smiling_face: When I said it's time to cool it and step back a little for a strategic regroup, it didn't mean that you should go and invent and implement a whole new strategy overnight. It m

[Rpm-maint] [rpm-software-management/rpm] Bump CI Fedora version to 34 (#1560)

2021-03-01 Thread Panu Matilainen
For whatever reason, builds inside Fedora 33 container image randomly fail due to phantom directories reported during configure/make. This doesn't seem to happen on 34 which is closing in on a beta release so should be stable enough for our purposes. You can view, comment on, or merge this pull req

Re: [Rpm-maint] [rpm-software-management/rpm] Bump CI Fedora version to 34 (#1560)

2021-03-01 Thread Panu Matilainen
Closed #1560. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1560#event-4388626643___ Rpm-maint mailing list Rpm-maint@lists.rpm

Re: [Rpm-maint] [rpm-software-management/rpm] Bump CI Fedora version to 34 (#1560)

2021-03-01 Thread Panu Matilainen
Nope, the mixture when running on semaphoreci is broken in even weirder ways... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1560#issuecomment-787829276__

Re: [Rpm-maint] [rpm-software-management/rpm] Bump CI Fedora version to 34 (#1560)

2021-03-01 Thread Panu Matilainen
Reopened #1560. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1560#event-4388648122___ Rpm-maint mailing list Rpm-maint@lists.r

Re: [Rpm-maint] [rpm-software-management/rpm] Bump CI Fedora version to 34 (#1560)

2021-03-01 Thread Panu Matilainen
Closed #1560. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1560#event-4388658388___ Rpm-maint mailing list Rpm-maint@lists.rpm

[Rpm-maint] [rpm-software-management/rpm] Fix regression causing access to already closed sqlite handle (#1561)

2021-03-01 Thread Panu Matilainen
Commit fb5888417727edbd8ce1b389b1b6ee9ac899d8e4 introduced a regression where on database open failure we end up accessing the already freed handle when trying to report the error. Now that we're no longer implicitly creating non-existent databases, just simplify the whole logic to get rid of it.

Re: [Rpm-maint] [rpm-software-management/rpm] Avoid using a freed SQLite DB connection (#1553)

2021-03-01 Thread Panu Matilainen
Ahh, the error message... that was the clue I was missing. Besides a bug this is also a regression. With the implicit database initialization gone, the whole retry logic looks just fishy. Addressed differently in #1561 (better to nuke the imaginary loop), thanks for the report + patch! though

Re: [Rpm-maint] [rpm-software-management/rpm] Avoid using a freed SQLite DB connection (#1553)

2021-03-01 Thread Panu Matilainen
Closed #1553. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1553#event-4388874566___ Rpm-maint mailing list Rpm-maint@lists.rpm

Re: [Rpm-maint] [rpm-software-management/rpm] Fix regression causing access to already closed sqlite handle (#1561)

2021-03-01 Thread Panu Matilainen
Merged #1561 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1561#event-4388878052___ Rpm-maint mailing list Rpm-mai

[Rpm-maint] [rpm-software-management/rpm] Error out on --eval if stdout write fails (#1444) (#1562)

2021-03-01 Thread Michal Domonkos
Since --eval only has one job - to actually *print* something to stdout, we should fail completely if that's not possible due to an external error, instead of just not printing anything. One particular case is redirecting stdout to a file on a file system that's full (generating the ENOSPC error).

Re: [Rpm-maint] [rpm-software-management/rpm] %{**} loses whitespace (#1439)

2021-03-01 Thread Michal Domonkos
What you're looking for is the `%{quote:...}` macro, documented [here](https://rpm.org/user_doc/macros.html). Example without the quote macro: ``` $ rpm --define 'hello() %{**}' --eval "%hello 1 2" 1 2 ``` And with the macro: ``` $ rpm --define 'hello() %{**}' --eval "%hello 1 %{quote: 2}

Re: [Rpm-maint] [rpm-software-management/rpm] %{**} loses whitespace (#1439)

2021-03-01 Thread Michal Domonkos
Closed #1439. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1439#event-4390300429___ Rpm-maint mailing list Rpm-maint@lists.r

Re: [Rpm-maint] [rpm-software-management/rpm] Fix regression causing access to already closed sqlite handle (#1561)

2021-03-01 Thread Demi Marie Obenour
@pmatilai Thank you for the fix! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1561#issuecomment-788235881___ Rpm-maint mailing

Re: [Rpm-maint] [rpm-software-management/rpm] Enhanced checks and a fuzz harness (#1559)

2021-03-01 Thread Demi Marie Obenour
> @DemiMarie , I know you're trying to help and thanks for that, but please > stop trying so hard :slightly_smiling_face: > > When I said it's time to cool it and step back a little for a strategic > regroup, it didn't mean that you should go and invent and implement a whole > new strategy over